Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH v2 1/1] package/iwd: drop dbus check
@ 2022-10-17  6:21 Lang Daniel via buildroot
  2022-10-30 20:36 ` Thomas Petazzoni via buildroot
  2022-11-13 15:53 ` Peter Korsgaard
  0 siblings, 2 replies; 3+ messages in thread
From: Lang Daniel via buildroot @ 2022-10-17  6:21 UTC (permalink / raw)
  To: buildroot@buildroot.org

Since 6f5f6bc dbus is selected when iwd is selected.
It is only a runtime dependency, so drop the build
dependency.

Signed-off-by: Daniel Lang <d.lang@abatec.at>
---
Changed v1 -> v2:
  - dbus is only a runtime dependency, drop
    the build dependency (thanks Yann).

 package/iwd/iwd.mk | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/package/iwd/iwd.mk b/package/iwd/iwd.mk
index 297e1fabe9..002988cf33 100644
--- a/package/iwd/iwd.mk
+++ b/package/iwd/iwd.mk
@@ -15,16 +15,11 @@ IWD_SELINUX_MODULES = networkmanager
 
 IWD_CONF_OPTS = \
 	--disable-manual-pages \
-	--enable-external-ell
+	--enable-external-ell \
+	--enable-dbus-policy \
+	--with-dbus-datadir=/usr/share
 IWD_DEPENDENCIES = ell
 
-ifeq ($(BR2_PACKAGE_DBUS),y)
-IWD_CONF_OPTS += --enable-dbus-policy --with-dbus-datadir=/usr/share
-IWD_DEPENDENCIES += dbus
-else
-IWD_CONF_OPTS += --disable-dbus-policy
-endif
-
 ifeq ($(BR2_PACKAGE_READLINE),y)
 # iwd client depends on readline (GPL-3.0+)
 IWD_LICENSE += , GPL-3.0+ (client)
-- 
2.25.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH v2 1/1] package/iwd: drop dbus check
  2022-10-17  6:21 [Buildroot] [PATCH v2 1/1] package/iwd: drop dbus check Lang Daniel via buildroot
@ 2022-10-30 20:36 ` Thomas Petazzoni via buildroot
  2022-11-13 15:53 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni via buildroot @ 2022-10-30 20:36 UTC (permalink / raw)
  To: Lang Daniel via buildroot; +Cc: Lang Daniel

On Mon, 17 Oct 2022 06:21:18 +0000
Lang Daniel via buildroot <buildroot@buildroot.org> wrote:

> Since 6f5f6bc dbus is selected when iwd is selected.
> It is only a runtime dependency, so drop the build
> dependency.
> 
> Signed-off-by: Daniel Lang <d.lang@abatec.at>
> ---
> Changed v1 -> v2:
>   - dbus is only a runtime dependency, drop
>     the build dependency (thanks Yann).

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH v2 1/1] package/iwd: drop dbus check
  2022-10-17  6:21 [Buildroot] [PATCH v2 1/1] package/iwd: drop dbus check Lang Daniel via buildroot
  2022-10-30 20:36 ` Thomas Petazzoni via buildroot
@ 2022-11-13 15:53 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2022-11-13 15:53 UTC (permalink / raw)
  To: Lang Daniel via buildroot; +Cc: Lang Daniel

>>>>> "Lang" == Lang Daniel via buildroot <buildroot@buildroot.org> writes:

 > Since 6f5f6bc dbus is selected when iwd is selected.
 > It is only a runtime dependency, so drop the build
 > dependency.

 > Signed-off-by: Daniel Lang <d.lang@abatec.at>
 > ---
 > Changed v1 -> v2:
 >   - dbus is only a runtime dependency, drop
 >     the build dependency (thanks Yann).

Committed to 2022.08.x and 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-11-13 15:53 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-17  6:21 [Buildroot] [PATCH v2 1/1] package/iwd: drop dbus check Lang Daniel via buildroot
2022-10-30 20:36 ` Thomas Petazzoni via buildroot
2022-11-13 15:53 ` Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox