* [Buildroot] [git commit] package/nodejs: fix 'Duplicate v8 target errors when cross-compiling' error
@ 2022-09-25 8:18 Thomas Petazzoni
2022-10-11 18:45 ` Peter Korsgaard
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Petazzoni @ 2022-09-25 8:18 UTC (permalink / raw)
To: buildroot
commit: https://git.buildroot.net/buildroot/commit/?id=5708c5b04f09f49a99c2c9d7a1894d24bce6a3e7
branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master
Reported also via:
https://github.com/nodejs/node/issues/37441
Patched in:
https://github.com/minrk/node/commit/5e533cb943eef68b270f55f0cba02c0ec67c699d
The error is:
```
ninja: Entering directory `out/Release'
ninja: error: obj.host/tools/v8_gypfiles/run_torque.ninja:1356: multiple rules generate gen/torque-generated/bit-fields.h [-w dupbuild=err]
make[2]: *** [Makefile:127: node] Error 1
make[1]: *** [package/pkg-generic.mk:293: <buildroot>/output/build/nodejs-16.15.0/.stamp_built] Error 2
make: *** [Makefile:84: _all] Error 2
```
Fixes:
http://autobuild.buildroot.net/results/7fe9132236ee8e3a86dd97fe96ffee42990c2d19/
Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
[Thomas:
- regenerate patch as a git formatted patch, add a link to the
original location, add my own SoB to it
- improve commit log]
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
...3-include-obj-name-in-shared-intermediate.patch | 42 ++++++++++++++++++++++
1 file changed, 42 insertions(+)
diff --git a/package/nodejs/0003-include-obj-name-in-shared-intermediate.patch b/package/nodejs/0003-include-obj-name-in-shared-intermediate.patch
new file mode 100644
index 0000000000..b439c66a0c
--- /dev/null
+++ b/package/nodejs/0003-include-obj-name-in-shared-intermediate.patch
@@ -0,0 +1,42 @@
+From e6e691d093de440e0f408d48971e2b7332a07d58 Mon Sep 17 00:00:00 2001
+From: Min RK <benjaminrk@gmail.com>
+Date: Fri, 19 Feb 2021 11:57:04 +0100
+Subject: [PATCH] include obj name in shared intermediate
+
+avoids duplicate ninja rules for v8 used in host and target
+
+From: https://github.com/minrk/node/commit/5e533cb943eef68b270f55f0cba02c0ec67c699d
+Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
+---
+ tools/gyp/pylib/gyp/generator/ninja.py | 8 +++++++-
+ 1 file changed, 7 insertions(+), 1 deletion(-)
+
+diff --git a/tools/gyp/pylib/gyp/generator/ninja.py b/tools/gyp/pylib/gyp/generator/ninja.py
+index d173bf2299..efaeee53ef 100644
+--- a/tools/gyp/pylib/gyp/generator/ninja.py
++++ b/tools/gyp/pylib/gyp/generator/ninja.py
+@@ -42,7 +42,7 @@ generator_default_variables = {
+ # the start of a string, while $| is used for variables that can appear
+ # anywhere in a string.
+ "INTERMEDIATE_DIR": "$!INTERMEDIATE_DIR",
+- "SHARED_INTERMEDIATE_DIR": "$!PRODUCT_DIR/gen",
++ "SHARED_INTERMEDIATE_DIR": "$!PRODUCT_DIR/$|OBJ/gen",
+ "PRODUCT_DIR": "$!PRODUCT_DIR",
+ "CONFIGURATION_NAME": "$|CONFIGURATION_NAME",
+ # Special variables that may be used by gyp 'rule' targets.
+@@ -285,6 +285,12 @@ class NinjaWriter:
+ CONFIGURATION_NAME = "$|CONFIGURATION_NAME"
+ path = path.replace(CONFIGURATION_NAME, self.config_name)
+
++ obj = "obj"
++ if self.toolset != "target":
++ obj += "." + self.toolset
++
++ path = path.replace("$|OBJ", obj)
++
+ return path
+
+ def ExpandRuleVariables(self, path, root, dirname, source, ext, name):
+--
+2.37.3
+
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-10-11 18:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-25 8:18 [Buildroot] [git commit] package/nodejs: fix 'Duplicate v8 target errors when cross-compiling' error Thomas Petazzoni
2022-10-11 18:45 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox