[Buildroot] [PATCH 1/1] size-stats: count compiled python (.pyc) files

[Buildroot] [PATCH 1/1] size-stats: count compiled python (.pyc) files

[Michael Klein via buildroot]

Any .pyc files generated by the pycompile script during target
finalization are currently counted in the "Unknown" package,
because packages-file-list.txt only contains the source .py file.

If a .py file is added to filesdict, add the corresponding .pyc
file as well.

Signed-off-by: Michael Klein <m.klein@mvz-labor-lb.de>
---
 support/scripts/size-stats | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/support/scripts/size-stats b/support/scripts/size-stats
index e4389e99b5..79c0dc571e 100755
--- a/support/scripts/size-stats
+++ b/support/scripts/size-stats
@@ -54,6 +54,9 @@ class Config:
 # pkg: package to which the file belongs
 #
 def add_file(filesdict, relpath, abspath, pkg):
+    if relpath.endswith(".py"):
+        # also check for compiled .pyc file
+        add_file(filesdict, relpath + "c", abspath + "c", pkg)
     if not os.path.exists(abspath):
         return
     if os.path.islink(abspath):
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] size-stats: count compiled python (.pyc) files

[Thomas Petazzoni]

On Thu, 1 Sep 2022 13:40:07 +0200
Michael Klein via buildroot <buildroot@buildroot.org> wrote:

> Any .pyc files generated by the pycompile script during target
> finalization are currently counted in the "Unknown" package,
> because packages-file-list.txt only contains the source .py file.
> 
> If a .py file is added to filesdict, add the corresponding .pyc
> file as well.
> 
> Signed-off-by: Michael Klein <m.klein@mvz-labor-lb.de>
> ---
>  support/scripts/size-stats | 3 +++
>  1 file changed, 3 insertions(+)

We indeed don't have a very good mechanism to "connect" files generated
during the target-finalize step with their original package in a
generic way, so for now what you did is I believe good enough to solve
this very common case of .pyc files, and therefore I've applied to
master. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] size-stats: count compiled python (.pyc) files

[Peter Korsgaard]

>>>>> "Michael" == Michael Klein via buildroot <buildroot@buildroot.org> writes:

 > Any .pyc files generated by the pycompile script during target
 > finalization are currently counted in the "Unknown" package,
 > because packages-file-list.txt only contains the source .py file.

 > If a .py file is added to filesdict, add the corresponding .pyc
 > file as well.

 > Signed-off-by: Michael Klein <m.klein@mvz-labor-lb.de>

Committed to 2022.02.x, 2022.05.x and 2022.08.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot