Re: [Buildroot] [PATCH 1/5] package/gnutls: disable library search in /usr/lib

From: Peter Korsgaard <peter@korsgaard.com>
To: "Arnout Vandecappelle (Essensium/Mind)" <arnout@mind.be>
Cc: Matt Weber <matthew.weber@collins.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/5] package/gnutls: disable library search in /usr/lib
Date: Sat, 28 May 2022 12:54:50 +0200	[thread overview]
Message-ID: <87o7zi9bb9.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20220512160116.2011627-1-arnout@mind.be> (Arnout Vandecappelle's message of "Thu, 12 May 2022 18:01:12 +0200")

>>>>> "Arnout" == Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> writes:

 > gnutls's configure script has a weird approach where it first searches
 > for dependent libraries in the path specified by --prefix, before
 > searching in the default search path. Since we set --prefix to /usr,
 > and it doesn't take into account DESTDIR (which is anyway not set at
 > configure time), that means it will first search /usr/lib before
 > searching $(STAGING_DIR)/usr/lib.

 > Ideally, this would be fixed in the configure script itself. However,
 > the m4 file that does this is pretty complex, it's not immediately clear
 > where to add $DESTDIR. In addition it comes from gnulib which is a
 > somewhat annoying upstream.

 > Therefore, instead, bypass the prefix lookup with
 > --without-libfoo-prefix. Note that we could set
 > --with-libfoo-prefix=$(STAGING_DIR)/usr (the latter is already done for
 > librt and libpthread), but that's pretty pointless -
 > --without-libfoo-prefix in fact reverts to what should have been done in
 > the first place, i.e. use the toolchain search path.

 > Add --without-libfoo-prefix for all options defined in configure (found
 > with ./configure --help | grep without-.*-prefix). Most of these are
 > only used in tests (e.g. libcrypto) or even not at all (e.g. libiconv),
 > but it's fairly hard to discover this and to be sure that they are
 > indeed not needed, so better pass all of them.

 > Remove the now-redundant arguments for librt and libpthread.

 > Add a comment to remind people to revisit these when bumping the
 > version.

 > Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
 > Cc: Peter Korsgaard <peter@korsgaard.com>
 > ---
 > This is for stable, but need to check if the same prefix options exist
 > in 3.7.3.

I instead bumped 2022.02.x to 3.7.4 as it contains fixes and applied the
entire series to 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot