[Buildroot] [PATCH 1/1] package/uftrace: needs NPTL

[Buildroot] [PATCH 1/1] package/uftrace: needs NPTL

[Fabrice Fontaine]

uftrace needs NPTL since its addition in commit
09c97972d9f90b69cfc36f9ffe9e22c13daf9307 and
https://github.com/namhyung/uftrace/commit/543fe53c256ceaef2d4d7cc44925bf1ad5a068a8:

buildroot/build/uftrace-0.10/buildroot/build/uftrace-0.10/cmds/record.c:670: undefined reference to `pthread_setname_np'

Fixes:
 - http://autobuild.buildroot.org/results/8f884efb9d45f9145a4799981157c9226390b423

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/uftrace/Config.in | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/package/uftrace/Config.in b/package/uftrace/Config.in
index 98ddb7cbfb..8f8c5d25fd 100644
--- a/package/uftrace/Config.in
+++ b/package/uftrace/Config.in
@@ -8,7 +8,7 @@ config BR2_PACKAGE_UFTRACE_ARCH_SUPPORTS
 config BR2_PACKAGE_UFTRACE
 	bool "uftrace"
 	depends on BR2_PACKAGE_UFTRACE_ARCH_SUPPORTS
-	depends on BR2_TOOLCHAIN_HAS_THREADS
+	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # pthread_setname_np()
 	depends on !BR2_STATIC_LIBS
 	select BR2_PACKAGE_ARGP_STANDALONE if \
 	       BR2_TOOLCHAIN_USES_UCLIBC || \
@@ -23,6 +23,6 @@ config BR2_PACKAGE_UFTRACE
 
 	  https://github.com/namhyung/uftrace
 
-comment "uftrace needs a toolchain w/ threads, dynamic library"
+comment "uftrace needs a toolchain w/ NPTL, dynamic library"
 	depends on BR2_PACKAGE_UFTRACE_ARCH_SUPPORTS
-	depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS
+	depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL || BR2_STATIC_LIBS
-- 
2.35.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/uftrace: needs NPTL

[Arnout Vandecappelle]

On 13/04/2022 21:21, Fabrice Fontaine wrote:
> uftrace needs NPTL since its addition in commit
> 09c97972d9f90b69cfc36f9ffe9e22c13daf9307 and
> https://github.com/namhyung/uftrace/commit/543fe53c256ceaef2d4d7cc44925bf1ad5a068a8:
> 
> buildroot/build/uftrace-0.10/buildroot/build/uftrace-0.10/cmds/record.c:670: undefined reference to `pthread_setname_np'
> 
> Fixes:
>   - http://autobuild.buildroot.org/results/8f884efb9d45f9145a4799981157c9226390b423
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

  Applied to master, thanks.

  Regards,
  Arnout

> ---
>   package/uftrace/Config.in | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/package/uftrace/Config.in b/package/uftrace/Config.in
> index 98ddb7cbfb..8f8c5d25fd 100644
> --- a/package/uftrace/Config.in
> +++ b/package/uftrace/Config.in
> @@ -8,7 +8,7 @@ config BR2_PACKAGE_UFTRACE_ARCH_SUPPORTS
>   config BR2_PACKAGE_UFTRACE
>   	bool "uftrace"
>   	depends on BR2_PACKAGE_UFTRACE_ARCH_SUPPORTS
> -	depends on BR2_TOOLCHAIN_HAS_THREADS
> +	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # pthread_setname_np()
>   	depends on !BR2_STATIC_LIBS
>   	select BR2_PACKAGE_ARGP_STANDALONE if \
>   	       BR2_TOOLCHAIN_USES_UCLIBC || \
> @@ -23,6 +23,6 @@ config BR2_PACKAGE_UFTRACE
>   
>   	  https://github.com/namhyung/uftrace
>   
> -comment "uftrace needs a toolchain w/ threads, dynamic library"
> +comment "uftrace needs a toolchain w/ NPTL, dynamic library"
>   	depends on BR2_PACKAGE_UFTRACE_ARCH_SUPPORTS
> -	depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS
> +	depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL || BR2_STATIC_LIBS
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/uftrace: needs NPTL

[Peter Korsgaard]

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > uftrace needs NPTL since its addition in commit
 > 09c97972d9f90b69cfc36f9ffe9e22c13daf9307 and
 > https://github.com/namhyung/uftrace/commit/543fe53c256ceaef2d4d7cc44925bf1ad5a068a8:

 > buildroot/build/uftrace-0.10/buildroot/build/uftrace-0.10/cmds/record.c:670: undefined reference to `pthread_setname_np'

 > Fixes:
 >  - http://autobuild.buildroot.org/results/8f884efb9d45f9145a4799981157c9226390b423

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed to 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot