Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/3] linux-firmware: fix install for Chelsio T[45]
Date: Mon, 15 Jan 2018 21:10:31 +0100	[thread overview]
Message-ID: <87o9luubm0.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20180115165743.GB2533@scaer> (Yann E. MORIN's message of "Mon, 15 Jan 2018 17:57:43 +0100")

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > Ricardo, All,
 > On 2018-01-14 21:41 -0200, Ricardo Martincoski spake thusly:
 >> It's broken for the last 3 version bumps, since
 >> 1c9846ecc9 "linux-firmware: Bump to the latest version"
 >> 
 >> Fix it by updating the name of the file to install.
 >> Do not use * since it would install also old versions that would take
 >> 1MB extra space in the target.

 > I would prefer if we were to keep installing the older version, because
 > presumably older kernel versions (even if they request the unversionned
 > t4fw.bin) would probably have been working with earlier versions of the
 > firmware, so I'd prefer we leave to the user the option to redirect the
 > symlink to the correct version they want to use.

That might indeed be nice, but should be done as a separate patch. A
nice thing about install t4fw*bin would be that this kind of problems
wouldn't happen again.

Will you send a patch?

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2018-01-15 20:10 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-14 23:41 [Buildroot] [PATCH 1/3] linux-firmware: fail build for missing file Ricardo Martincoski
2018-01-14 23:41 ` [Buildroot] [PATCH 2/3] linux-firmware: fix install for Chelsio T[45] Ricardo Martincoski
2018-01-15 16:57   ` Yann E. MORIN
2018-01-15 20:10     ` Peter Korsgaard [this message]
2018-01-15 20:31       ` Yann E. MORIN
2018-01-15 20:08   ` Peter Korsgaard
2018-01-14 23:41 ` [Buildroot] [PATCH 3/3] armbian-firmware: fail build for missing file Ricardo Martincoski
2018-01-15 16:53   ` Yann E. MORIN
2018-01-15 17:07     ` Ricardo Martincoski
2018-01-15 17:17       ` Ricardo Martincoski
2018-01-15 20:11   ` Peter Korsgaard
2018-01-15 17:00 ` [Buildroot] [PATCH 1/3] linux-firmware: " Yann E. MORIN
2018-01-15 20:05 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o9luubm0.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox