From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/3] linux-firmware: fail build for missing file
Date: Mon, 15 Jan 2018 21:05:51 +0100 [thread overview]
Message-ID: <87wp0iubts.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1515973281-3997-1-git-send-email-ricardo.martincoski@gmail.com> (Ricardo Martincoski's message of "Sun, 14 Jan 2018 21:41:19 -0200")
>>>>> "Ricardo" == Ricardo Martincoski <ricardo.martincoski@gmail.com> writes:
> When a file is listed to be installed but is missing from the package
> source currently the first tar command exits with error code but it is
> ignored and the build succeeds.
> This issue by itself is minor because those listed files that are
> present in the package source get installed to the target.
> But the code is currently error prone, e.g. to a typo in the file list.
> Fix this by first creating a tarball in the build directory and then
> installing it, instead of using a pipe between the two tar invocations.
> Also use && between the commands, so the first command that exits with
> error code fails the build.
> Since the two tar invocations remain in use, the desired behavior
> remains the same:
> - list of files can contain *;
> - list of files can contain file inside path, and the path is then
> replicated in the target;
> - symlinks are not followed but are installed.
> Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: Peter Korsgaard <peter@korsgaard.com>
> Cc: Peter Seiderer <ps.report@gmx.net>
> Cc: Yann E. MORIN <yann.morin.1998@free.fr>
> Cc: Yegor Yefremov <yegorslists@googlemail.com>
> ---
> Should it go to 2017.11.x and 2017.08.x too? See next patch
Committed, thanks.
--
Bye, Peter Korsgaard
prev parent reply other threads:[~2018-01-15 20:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-14 23:41 [Buildroot] [PATCH 1/3] linux-firmware: fail build for missing file Ricardo Martincoski
2018-01-14 23:41 ` [Buildroot] [PATCH 2/3] linux-firmware: fix install for Chelsio T[45] Ricardo Martincoski
2018-01-15 16:57 ` Yann E. MORIN
2018-01-15 20:10 ` Peter Korsgaard
2018-01-15 20:31 ` Yann E. MORIN
2018-01-15 20:08 ` Peter Korsgaard
2018-01-14 23:41 ` [Buildroot] [PATCH 3/3] armbian-firmware: fail build for missing file Ricardo Martincoski
2018-01-15 16:53 ` Yann E. MORIN
2018-01-15 17:07 ` Ricardo Martincoski
2018-01-15 17:17 ` Ricardo Martincoski
2018-01-15 20:11 ` Peter Korsgaard
2018-01-15 17:00 ` [Buildroot] [PATCH 1/3] linux-firmware: " Yann E. MORIN
2018-01-15 20:05 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wp0iubts.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox