* [Buildroot] [PATCH] vo-aacenc: disable arm optimizations on thumb2-only variants
@ 2016-10-02 15:37 Peter Korsgaard
2016-10-02 19:53 ` Peter Korsgaard
0 siblings, 1 reply; 2+ messages in thread
From: Peter Korsgaard @ 2016-10-02 15:37 UTC (permalink / raw)
To: buildroot
Fixes:
http://autobuild.buildroot.org/results/258/258e14227cdd5a6f5cc83ab7fd176eb5b5b8445a/
http://autobuild.buildroot.org/results/634/6345b4c491fca952cd692844e3ac2932ac4836dc/
The ARM assembly optimizations in vo-aacenc requires ARM instructions
support, so disable for ARM variants without ARM instruction support (E.G.
cortex-m).
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
package/vo-aacenc/vo-aacenc.mk | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/package/vo-aacenc/vo-aacenc.mk b/package/vo-aacenc/vo-aacenc.mk
index 23d7e62..ecdd584 100644
--- a/package/vo-aacenc/vo-aacenc.mk
+++ b/package/vo-aacenc/vo-aacenc.mk
@@ -15,6 +15,7 @@ VO_AACENC_CFLAGS = $(TARGET_CFLAGS)
# arm specific asm optimizations
ifeq ($(BR2_arm),y)
+ifeq ($(BR2_ARM_CPU_HAS_ARM),y)
# vo-aacenc has ARM assembly code that cannot be compiled in Thumb2
# mode, so we must force the traditional ARM mode.
VO_AACENC_CFLAGS += -marm
@@ -33,6 +34,10 @@ VO_AACENC_CONF_OPTS += --disable-armv5e
endif
endif # !neon
+
+else
+VO_AACENC_CONF_OPTS += --disable-armv7neon --disable-armv5e
+endif # has-arm
endif # arm
VO_AACENC_CONF_ENV = \
--
2.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Buildroot] [PATCH] vo-aacenc: disable arm optimizations on thumb2-only variants
2016-10-02 15:37 [Buildroot] [PATCH] vo-aacenc: disable arm optimizations on thumb2-only variants Peter Korsgaard
@ 2016-10-02 19:53 ` Peter Korsgaard
0 siblings, 0 replies; 2+ messages in thread
From: Peter Korsgaard @ 2016-10-02 19:53 UTC (permalink / raw)
To: buildroot
>>>>> "Peter" == Peter Korsgaard <peter@korsgaard.com> writes:
> Fixes:
> http://autobuild.buildroot.org/results/258/258e14227cdd5a6f5cc83ab7fd176eb5b5b8445a/
> http://autobuild.buildroot.org/results/634/6345b4c491fca952cd692844e3ac2932ac4836dc/
> The ARM assembly optimizations in vo-aacenc requires ARM instructions
> support, so disable for ARM variants without ARM instruction support (E.G.
> cortex-m).
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Committed, thanks.
--
Venlig hilsen,
Peter Korsgaard
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-10-02 19:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-02 15:37 [Buildroot] [PATCH] vo-aacenc: disable arm optimizations on thumb2-only variants Peter Korsgaard
2016-10-02 19:53 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox