Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] package/nginx: fix build failure
@ 2014-10-12 20:14 Samuel Martin
  2014-10-12 22:05 ` Thomas Petazzoni
  2014-10-25  0:47 ` Peter Korsgaard
  0 siblings, 2 replies; 5+ messages in thread
From: Samuel Martin @ 2014-10-12 20:14 UTC (permalink / raw)
  To: buildroot

Correctly set NGX_SYS_NERR, even when it is 0.

Fixes:
  http://autobuild.buildroot.org/results/666/666d780bf61e10c9f89f765bb04ddc1afc11d0d1/
  http://autobuild.buildroot.org/?reason=nginx-1.6.2&&arch=powerpc

Signed-off-by: Samuel Martin <s.martin49@gmail.com>
---
 .../nginx-0005-auto-unix-make-sys_nerr-guessing-cross-friendly.patch   | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/package/nginx/nginx-0005-auto-unix-make-sys_nerr-guessing-cross-friendly.patch b/package/nginx/nginx-0005-auto-unix-make-sys_nerr-guessing-cross-friendly.patch
index 4c00755..d02de68 100644
--- a/package/nginx/nginx-0005-auto-unix-make-sys_nerr-guessing-cross-friendly.patch
+++ b/package/nginx/nginx-0005-auto-unix-make-sys_nerr-guessing-cross-friendly.patch
@@ -22,7 +22,7 @@ new file mode 100644
 index 0000000..25e7c22
 --- /dev/null
 +++ b/auto/os/sys_nerr
-@@ -0,0 +1,77 @@
+@@ -0,0 +1,78 @@
 +
 +# Copyright (C) Samuel Martin <s.martin49@gmail.com>
 +
@@ -89,6 +89,7 @@ index 0000000..25e7c22
 +
 +if test -z $ngx_sys_nerr ; then
 +    ngx_size=0
++    ngx_sys_nerr=0
 +fi
 +
 +cat << END >> $NGX_AUTO_CONFIG_H
-- 
2.1.2

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH] package/nginx: fix build failure
  2014-10-12 20:14 [Buildroot] [PATCH] package/nginx: fix build failure Samuel Martin
@ 2014-10-12 22:05 ` Thomas Petazzoni
  2014-10-13  4:38   ` Samuel Martin
  2014-10-25  0:47 ` Peter Korsgaard
  1 sibling, 1 reply; 5+ messages in thread
From: Thomas Petazzoni @ 2014-10-12 22:05 UTC (permalink / raw)
  To: buildroot

Dear Samuel Martin,

On Sun, 12 Oct 2014 22:14:39 +0200, Samuel Martin wrote:
> Correctly set NGX_SYS_NERR, even when it is 0.
> 
> Fixes:
>   http://autobuild.buildroot.org/results/666/666d780bf61e10c9f89f765bb04ddc1afc11d0d1/
>   http://autobuild.buildroot.org/?reason=nginx-1.6.2&&arch=powerpc
> 
> Signed-off-by: Samuel Martin <s.martin49@gmail.com>
> ---
>  .../nginx-0005-auto-unix-make-sys_nerr-guessing-cross-friendly.patch   | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/package/nginx/nginx-0005-auto-unix-make-sys_nerr-guessing-cross-friendly.patch b/package/nginx/nginx-0005-auto-unix-make-sys_nerr-guessing-cross-friendly.patch
> index 4c00755..d02de68 100644
> --- a/package/nginx/nginx-0005-auto-unix-make-sys_nerr-guessing-cross-friendly.patch
> +++ b/package/nginx/nginx-0005-auto-unix-make-sys_nerr-guessing-cross-friendly.patch

Description + SoB in the patch ?

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH] package/nginx: fix build failure
  2014-10-12 22:05 ` Thomas Petazzoni
@ 2014-10-13  4:38   ` Samuel Martin
  2014-10-13 20:28     ` Thomas Petazzoni
  0 siblings, 1 reply; 5+ messages in thread
From: Samuel Martin @ 2014-10-13  4:38 UTC (permalink / raw)
  To: buildroot

On Mon, Oct 13, 2014 at 12:05 AM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Dear Samuel Martin,
>
> On Sun, 12 Oct 2014 22:14:39 +0200, Samuel Martin wrote:
>> Correctly set NGX_SYS_NERR, even when it is 0.
>>
>> Fixes:
>>   http://autobuild.buildroot.org/results/666/666d780bf61e10c9f89f765bb04ddc1afc11d0d1/
>>   http://autobuild.buildroot.org/?reason=nginx-1.6.2&&arch=powerpc
>>
>> Signed-off-by: Samuel Martin <s.martin49@gmail.com>
>> ---
>>  .../nginx-0005-auto-unix-make-sys_nerr-guessing-cross-friendly.patch   | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/package/nginx/nginx-0005-auto-unix-make-sys_nerr-guessing-cross-friendly.patch b/package/nginx/nginx-0005-auto-unix-make-sys_nerr-guessing-cross-friendly.patch
>> index 4c00755..d02de68 100644
>> --- a/package/nginx/nginx-0005-auto-unix-make-sys_nerr-guessing-cross-friendly.patch
>> +++ b/package/nginx/nginx-0005-auto-unix-make-sys_nerr-guessing-cross-friendly.patch
>
> Description + SoB in the patch ?

Well, this is a change on an existing patch which already contains a
description and my SoB...
I don't think it is needed in this case.

BTW, I did not rename the patch(es) because I prefer doing this in another cset.


Regards,

-- 
Samuel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH] package/nginx: fix build failure
  2014-10-13  4:38   ` Samuel Martin
@ 2014-10-13 20:28     ` Thomas Petazzoni
  0 siblings, 0 replies; 5+ messages in thread
From: Thomas Petazzoni @ 2014-10-13 20:28 UTC (permalink / raw)
  To: buildroot

Dear Samuel Martin,

On Mon, 13 Oct 2014 06:38:26 +0200, Samuel Martin wrote:

> > Description + SoB in the patch ?
> 
> Well, this is a change on an existing patch which already contains a
> description and my SoB...
> I don't think it is needed in this case.

Ah, yes, ok, fair enough. Would have been good to have a better commit
message then that makes it explicit.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH] package/nginx: fix build failure
  2014-10-12 20:14 [Buildroot] [PATCH] package/nginx: fix build failure Samuel Martin
  2014-10-12 22:05 ` Thomas Petazzoni
@ 2014-10-25  0:47 ` Peter Korsgaard
  1 sibling, 0 replies; 5+ messages in thread
From: Peter Korsgaard @ 2014-10-25  0:47 UTC (permalink / raw)
  To: buildroot

>>>>> "Samuel" == Samuel Martin <s.martin49@gmail.com> writes:

 > Correctly set NGX_SYS_NERR, even when it is 0.
 > Fixes:
 >   http://autobuild.buildroot.org/results/666/666d780bf61e10c9f89f765bb04ddc1afc11d0d1/
 >   http://autobuild.buildroot.org/?reason=nginx-1.6.2&&arch=powerpc

 > Signed-off-by: Samuel Martin <s.martin49@gmail.com>

Committed, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2014-10-25  0:47 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-12 20:14 [Buildroot] [PATCH] package/nginx: fix build failure Samuel Martin
2014-10-12 22:05 ` Thomas Petazzoni
2014-10-13  4:38   ` Samuel Martin
2014-10-13 20:28     ` Thomas Petazzoni
2014-10-25  0:47 ` Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox