From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] tiff: ensure directory exists before installing to it
Date: Thu, 25 Sep 2014 11:10:18 +0200 [thread overview]
Message-ID: <87oau4ysjp.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1410488467-2093-1-git-send-email-danomimanchego123@gmail.com> (Danomi Manchego's message of "Thu, 11 Sep 2014 22:21:07 -0400")
>>>>> "Danomi" == Danomi Manchego <danomimanchego123@gmail.com> writes:
> Also, don't ignore errors during installation.
> Signed-off-by: Danomi Manchego <danomimanchego123@gmail.com>
> ---
> package/tiff/tiff.mk | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
> diff --git a/package/tiff/tiff.mk b/package/tiff/tiff.mk
> index 8d2e087..c61894b 100644
> --- a/package/tiff/tiff.mk
> +++ b/package/tiff/tiff.mk
> @@ -76,7 +76,8 @@ ifneq ($(BR2_PACKAGE_TIFF_JBIG),y)
> endif
> define TIFF_INSTALL_TARGET_CMDS
> - -cp -a $(@D)/libtiff/.libs/libtiff.so* $(TARGET_DIR)/usr/lib/
> + mkdir -p $(TARGET_DIR)/usr/lib/
> + cp -a $(@D)/libtiff/.libs/libtiff.so* $(TARGET_DIR)/usr/lib/
Hmm, so what happens with a BR2_PREFER_STATIC_LIB=y build?
>>> tiff 4.0.3 Installing to target
mkdir -p /home/peko/source/buildroot/output/target/usr/lib/
cp -a /home/peko/source/buildroot/output/build/tiff-4.0.3/libtiff/.libs/libtiff.so* /home/peko/source/buildroot/output/target/usr/lib/
cp: cannot stat ?/home/peko/source/buildroot/output/build/tiff-4.0.3/libtiff/.libs/libtiff.so*?: No such file or directory
package/pkg-generic.mk:228: recipe for target '/home/peko/source/buildroot/output/build/tiff-4.0.3/.stamp_target_installed' failed
make: *** [/home/peko/source/buildroot/output/build/tiff-4.0.3/.stamp_target_installed] Error 1
Not good. Why are we not just using 'make install' and removing whatever
binaries / extras we don't want like we do for other packages?
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2014-09-25 9:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-12 2:21 [Buildroot] [PATCH 1/1] tiff: ensure directory exists before installing to it Danomi Manchego
2014-09-12 7:34 ` Thomas Petazzoni
2014-09-22 17:25 ` Thomas Petazzoni
2014-09-22 18:19 ` Danomi Manchego
2014-09-23 7:37 ` Thomas Petazzoni
2014-09-25 9:04 ` Peter Korsgaard
2014-09-25 9:10 ` Peter Korsgaard [this message]
2014-09-25 13:08 ` Danomi Manchego
2014-09-25 19:50 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87oau4ysjp.fsf@dell.be.48ers.dk \
--to=jacmet@uclibc.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox