Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] tiff: ensure directory exists before installing to it
Date: Thu, 25 Sep 2014 11:04:29 +0200	[thread overview]
Message-ID: <87sijgyste.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20140923093751.4addbd77@free-electrons.com> (Thomas Petazzoni's message of "Tue, 23 Sep 2014 09:37:51 +0200")

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

Hi,

 >> I do not have a defconfig that demonstrates this.  I tend to encounter
 >> these kind of error when I do the following trick to observe what
 >> exactly is installed to the target directory:
 >> 
 >> make tiff-rebuild TARGET_DIR=$(pwd)/TIFF
 >> tree TIFF
 >> 
 >> If I hit an error, they I figure that I'm just one mostly empty custom
 >> skeleton and convoluted dependency graph away from hitting the error
 >> in real life.  So then I submit a patch.

 > Ok, thanks for the explanation. However, I'm wondering if we want to
 > support this. By doing this, you completely circumvent the preparation
 > work that is done by Buildroot: when you do make tiff-rebuild, only the
 > building and installation steps are re-executed with a different
 > TARGET_DIR. So any preparation work done before, such as directories
 > created by the global "dirs" target (on which all packages depend) will
 > not be done in your new TARGET_DIR.

 > Peter, Fabio, any opinion on this?

I don't think it is something we should really officially support, but
the specific patch is ok as such, so I will commit it.

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2014-09-25  9:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-12  2:21 [Buildroot] [PATCH 1/1] tiff: ensure directory exists before installing to it Danomi Manchego
2014-09-12  7:34 ` Thomas Petazzoni
2014-09-22 17:25 ` Thomas Petazzoni
2014-09-22 18:19   ` Danomi Manchego
2014-09-23  7:37     ` Thomas Petazzoni
2014-09-25  9:04       ` Peter Korsgaard [this message]
2014-09-25  9:10 ` Peter Korsgaard
2014-09-25 13:08   ` Danomi Manchego
2014-09-25 19:50     ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sijgyste.fsf@dell.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox