* [Buildroot] [PATCH] Add Swfdec Free flash library
@ 2009-09-28 11:03 Emmanuel Riou
2009-09-29 9:48 ` Peter Korsgaard
0 siblings, 1 reply; 9+ messages in thread
From: Emmanuel Riou @ 2009-09-28 11:03 UTC (permalink / raw)
To: buildroot
Signed-off-by: Emmanuel Riou <riou.emmanuel@googlemail.com>
---
package/multimedia/Config.in | 1 +
package/multimedia/swfdec/Config.in | 27 +++++++++++++++++++++++++++
package/multimedia/swfdec/swfdec.mk | 32 ++++++++++++++++++++++++++++++++
3 files changed, 60 insertions(+), 0 deletions(-)
create mode 100644 package/multimedia/swfdec/Config.in
create mode 100644 package/multimedia/swfdec/swfdec.mk
diff --git a/package/multimedia/Config.in b/package/multimedia/Config.in
index c7160a6..49932d0 100644
--- a/package/multimedia/Config.in
+++ b/package/multimedia/Config.in
@@ -21,6 +21,7 @@ source "package/multimedia/madplay/Config.in"
source "package/multimedia/mpg123/Config.in"
source "package/multimedia/mplayer/Config.in"
source "package/multimedia/speex/Config.in"
+source "package/multimedia/swfdec/Config.in"
source "package/multimedia/festival/Config.in"
source "package/multimedia/taglib/Config.in"
source "package/multimedia/vlc/Config.in"
diff --git a/package/multimedia/swfdec/Config.in b/package/multimedia/swfdec/Config.in
new file mode 100644
index 0000000..9b1d03d
--- /dev/null
+++ b/package/multimedia/swfdec/Config.in
@@ -0,0 +1,27 @@
+config BR2_PACKAGE_SWFDEC
+ bool "swfdec"
+ select BR2_PACKAGE_LIBSOUP
+ select BR2_PACKAGE_LIBOIL
+ select BR2_PACKAGE_ALSA_LIB
+ help
+ Library to play Flash Files
+
+ http://swfdec.freedesktop.org/
+
+config BR2_PACKAGE_SWFDEC_GTK_SUPPORT
+ bool "swfdec gtk"
+ depends on BR2_PACKAGE_SWFDEC
+ depends on BR2_PACKAGE_LIBGTK2
+ select BR2_PACKAGE_CAIRO_PNG
+ help
+ Swfdec-gtk library is used for easy integration
+ of swfdec in GTK applications
+
+config BR2_PACKAGE_SWFDEC_GSTREAMER
+ bool "swfdec gstreamer"
+ depends on BR2_PACKAGE_SWFDEC
+ select BR2_PACKAGE_GSTREAMER
+ select BR2_PACKAGE_GST_PLUGINS_BASE
+ help
+ Enables GStreamer support
+
diff --git a/package/multimedia/swfdec/swfdec.mk b/package/multimedia/swfdec/swfdec.mk
new file mode 100644
index 0000000..23ba7b7
--- /dev/null
+++ b/package/multimedia/swfdec/swfdec.mk
@@ -0,0 +1,32 @@
+#############################################################
+#
+# Swfdec
+#
+#############################################################
+SWFDEC_VERSION_MAJOR = 0.8
+SWFDEC_VERSION_MINOR = 4
+SWFDEC_VERSION = $(SWFDEC_VERSION_MAJOR).$(SWFDEC_VERSION_MINOR)
+SWFDEC_SOURCE = swfdec-$(SWFDEC_VERSION).tar.gz
+SWFDEC_SITE = http://swfdec.freedesktop.org/download/swfdec/$(SWFDEC_VERSION_MAJOR)
+
+SWFDEC_LIBTOOL_PATCH = NO
+SWFDEC_INSTALL_STAGING = YES
+SWFDEC_INSTALL_TARGET = YES
+
+SWFDEC_DEPENDENCIES = libsoup liboil alsa-lib ohost-pkgconfig
+
+ifeq ($(BR2_PACKAGE_SWFDEC_GSTREAMER),y)
+SWFDEC_DEPENDENCIES += gstreamer gst-plugins-base
+else
+SWFDEC_CONF_OPT += --disable-gstreamer
+endif
+
+ifeq ($(BR2_PACKAGE_SWFDEC_GTK_SUPPORT),y)
+SWFDEC_DEPENDENCIES += libgtk2
+else
+SWFDEC_CONF_OPT += --disable-gtk
+endif
+
+
+
+$(eval $(call AUTOTARGETS,package/multimedia,swfdec))
--
1.6.0.4
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH] Add Swfdec Free flash library
@ 2009-09-29 9:08 Emmanuel Riou
0 siblings, 0 replies; 9+ messages in thread
From: Emmanuel Riou @ 2009-09-29 9:08 UTC (permalink / raw)
To: buildroot
Signed-off-by: Emmanuel Riou <riou.emmanuel@googlemail.com>
---
package/multimedia/Config.in | 1 +
package/multimedia/swfdec/Config.in | 27 +++++++++++++++++++++++++++
package/multimedia/swfdec/swfdec.mk | 32 ++++++++++++++++++++++++++++++++
3 files changed, 60 insertions(+), 0 deletions(-)
create mode 100644 package/multimedia/swfdec/Config.in
create mode 100644 package/multimedia/swfdec/swfdec.mk
diff --git a/package/multimedia/Config.in b/package/multimedia/Config.in
index c7160a6..49932d0 100644
--- a/package/multimedia/Config.in
+++ b/package/multimedia/Config.in
@@ -21,6 +21,7 @@ source "package/multimedia/madplay/Config.in"
source "package/multimedia/mpg123/Config.in"
source "package/multimedia/mplayer/Config.in"
source "package/multimedia/speex/Config.in"
+source "package/multimedia/swfdec/Config.in"
source "package/multimedia/festival/Config.in"
source "package/multimedia/taglib/Config.in"
source "package/multimedia/vlc/Config.in"
diff --git a/package/multimedia/swfdec/Config.in b/package/multimedia/swfdec/Config.in
new file mode 100644
index 0000000..9b1d03d
--- /dev/null
+++ b/package/multimedia/swfdec/Config.in
@@ -0,0 +1,27 @@
+config BR2_PACKAGE_SWFDEC
+ bool "swfdec"
+ select BR2_PACKAGE_LIBSOUP
+ select BR2_PACKAGE_LIBOIL
+ select BR2_PACKAGE_ALSA_LIB
+ help
+ Library to play Flash Files
+
+ http://swfdec.freedesktop.org/
+
+config BR2_PACKAGE_SWFDEC_GTK_SUPPORT
+ bool "swfdec gtk"
+ depends on BR2_PACKAGE_SWFDEC
+ depends on BR2_PACKAGE_LIBGTK2
+ select BR2_PACKAGE_CAIRO_PNG
+ help
+ Swfdec-gtk library is used for easy integration
+ of swfdec in GTK applications
+
+config BR2_PACKAGE_SWFDEC_GSTREAMER
+ bool "swfdec gstreamer"
+ depends on BR2_PACKAGE_SWFDEC
+ select BR2_PACKAGE_GSTREAMER
+ select BR2_PACKAGE_GST_PLUGINS_BASE
+ help
+ Enables GStreamer support
+
diff --git a/package/multimedia/swfdec/swfdec.mk b/package/multimedia/swfdec/swfdec.mk
new file mode 100644
index 0000000..229dfd7
--- /dev/null
+++ b/package/multimedia/swfdec/swfdec.mk
@@ -0,0 +1,32 @@
+#############################################################
+#
+# Swfdec
+#
+#############################################################
+SWFDEC_VERSION_MAJOR = 0.8
+SWFDEC_VERSION_MINOR = 4
+SWFDEC_VERSION = $(SWFDEC_VERSION_MAJOR).$(SWFDEC_VERSION_MINOR)
+SWFDEC_SOURCE = swfdec-$(SWFDEC_VERSION).tar.gz
+SWFDEC_SITE = http://swfdec.freedesktop.org/download/swfdec/$(SWFDEC_VERSION_MAJOR)
+
+SWFDEC_LIBTOOL_PATCH = NO
+SWFDEC_INSTALL_STAGING = YES
+SWFDEC_INSTALL_TARGET = YES
+
+SWFDEC_DEPENDENCIES = libsoup liboil alsa-lib host-pkgconfig
+
+ifeq ($(BR2_PACKAGE_SWFDEC_GSTREAMER),y)
+SWFDEC_DEPENDENCIES += gstreamer gst-plugins-base
+else
+SWFDEC_CONF_OPT += --disable-gstreamer
+endif
+
+ifeq ($(BR2_PACKAGE_SWFDEC_GTK_SUPPORT),y)
+SWFDEC_DEPENDENCIES += libgtk2
+else
+SWFDEC_CONF_OPT += --disable-gtk
+endif
+
+
+
+$(eval $(call AUTOTARGETS,package/multimedia,swfdec))
--
1.6.0.4
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH] Add Swfdec Free flash library
@ 2009-09-25 15:32 Emmanuel Riou
2009-09-25 18:51 ` Peter Korsgaard
0 siblings, 1 reply; 9+ messages in thread
From: Emmanuel Riou @ 2009-09-25 15:32 UTC (permalink / raw)
To: buildroot
Signed-off-by: Emmanuel Riou <riou.emmanuel@googlemail.com>
---
package/multimedia/Config.in | 1 +
package/multimedia/swfdec/Config.in | 27 +++++++++++++++++++++++++++
package/multimedia/swfdec/swfdec.mk | 32 ++++++++++++++++++++++++++++++++
3 files changed, 60 insertions(+), 0 deletions(-)
create mode 100644 package/multimedia/swfdec/Config.in
create mode 100644 package/multimedia/swfdec/swfdec.mk
diff --git a/package/multimedia/Config.in b/package/multimedia/Config.in
index c7160a6..49932d0 100644
--- a/package/multimedia/Config.in
+++ b/package/multimedia/Config.in
@@ -21,6 +21,7 @@ source "package/multimedia/madplay/Config.in"
source "package/multimedia/mpg123/Config.in"
source "package/multimedia/mplayer/Config.in"
source "package/multimedia/speex/Config.in"
+source "package/multimedia/swfdec/Config.in"
source "package/multimedia/festival/Config.in"
source "package/multimedia/taglib/Config.in"
source "package/multimedia/vlc/Config.in"
diff --git a/package/multimedia/swfdec/Config.in b/package/multimedia/swfdec/Config.in
new file mode 100644
index 0000000..e7f191f
--- /dev/null
+++ b/package/multimedia/swfdec/Config.in
@@ -0,0 +1,27 @@
+config BR2_PACKAGE_SWFDEC
+ bool "swfdec"
+ select BR2_PACKAGE_LIBSOUP
+ select BR2_PACKAGE_LIBOIL
+ select BR2_PACKAGE_ALSA_LIB
+ help
+ Library to play Flash Files
+ http://swfdec.freedesktop.org/
+
+config BR2_PACKAGE_SWFDEC_GTK
+ bool "swfdec gtk"
+ depends on BR2_PACKAGE_SWFDEC
+ depends on BR2_PACKAGE_DIRECTFB || BR2_PACKAGE_XORG7
+ select BR2_PACKAGE_LIBGTK2
+ select BR2_PACKAGE_CAIRO_PNG
+ help
+ Enables swfdec-gtk
+
+config BR2_PACKAGE_SWFDEC_GSTREAMER
+ bool "swfdec gstreamer"
+ default y
+ depends on BR2_PACKAGE_SWFDEC
+ select BR2_PACKAGE_GSTREAMER
+ select BR2_PACKAGE_GST_PLUGINS_BASE
+ help
+ Enables GStreamer support
+
diff --git a/package/multimedia/swfdec/swfdec.mk b/package/multimedia/swfdec/swfdec.mk
new file mode 100644
index 0000000..4a80c40
--- /dev/null
+++ b/package/multimedia/swfdec/swfdec.mk
@@ -0,0 +1,32 @@
+#############################################################
+#
+# Swfdec
+#
+#############################################################
+SWFDEC_VERSION_MAJOR:=0.8
+SWFDEC_VERSION_MINOR:=4
+SWFDEC_VERSION = $(SWFDEC_VERSION_MAJOR).$(SWFDEC_VERSION_MINOR)
+
+SWFDEC_SOURCE:=swfdec-$(SWFDEC_VERSION).tar.gz
+SWFDEC_SITE:=http://swfdec.freedesktop.org/download/swfdec/$(SWFDEC_VERSION_MAJOR)
+SWFDEC_LIBTOOL_PATCH = NO
+SWFDEC_INSTALL_STAGING = YES
+SWFDEC_INSTALL_TARGET = YES
+
+SWFDEC_DEPENDENCIES = libsoup liboil alsa-lib ohost-pkgconfig
+
+ifeq ($(BR2_PACKAGE_SWFDEC_GSTREAMER),y)
+SWFDEC_DEPENDENCIES += gstreamer gst-plugins-base
+else
+SWFDEC_CONF_OPT += --disable-gstreamer
+endif
+
+ifeq ($(BR2_PACKAGE_SWFDEC_GTK),y)
+SWFDEC_DEPENDENCIES += libgtk2
+else
+SWFDEC_CONF_OPT += --disable-gtk
+endif
+
+
+
+$(eval $(call AUTOTARGETS,package/multimedia,swfdec))
--
1.6.0.4
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH] Add Swfdec Free flash library
2009-09-25 15:32 Emmanuel Riou
@ 2009-09-25 18:51 ` Peter Korsgaard
2009-09-28 10:55 ` Emmanuel Riou
0 siblings, 1 reply; 9+ messages in thread
From: Peter Korsgaard @ 2009-09-25 18:51 UTC (permalink / raw)
To: buildroot
>>>>> "Emmanuel" == Emmanuel Riou <riou.emmanuel@googlemail.com> writes:
Emmanuel> Signed-off-by: Emmanuel Riou <riou.emmanuel@googlemail.com>
Emmanuel> ---
Thanks, a few remarks:
Emmanuel> +++ b/package/multimedia/swfdec/Config.in
Emmanuel> @@ -0,0 +1,27 @@
Emmanuel> +config BR2_PACKAGE_SWFDEC
Emmanuel> + bool "swfdec"
Emmanuel> + select BR2_PACKAGE_LIBSOUP
Emmanuel> + select BR2_PACKAGE_LIBOIL
Emmanuel> + select BR2_PACKAGE_ALSA_LIB
Emmanuel> + help
Emmanuel> + Library to play Flash Files
Emmanuel> + http://swfdec.freedesktop.org/
We normally have an empty line before the URL.
Emmanuel> +
Emmanuel> +config BR2_PACKAGE_SWFDEC_GTK
Emmanuel> + bool "swfdec gtk"
Emmanuel> + depends on BR2_PACKAGE_SWFDEC
Emmanuel> + depends on BR2_PACKAGE_DIRECTFB || BR2_PACKAGE_XORG7
Emmanuel> + select BR2_PACKAGE_LIBGTK2
Emmanuel> + select BR2_PACKAGE_CAIRO_PNG
Emmanuel> + help
Emmanuel> + Enables swfdec-gtk
Indentation is wrong for the depends/select lines (should be <tab>). We
normally don't use select for stuff with complicated dependencies like
gtk, so I think it would be nicer to simply depen on libgtk2 - Then you
can also get rid of the directfb || xorg7 stuff.
You furthermore have trailing spaces in the help text. Maybe the config
option and help text should say something like gtk support?
Emmanuel> +
Emmanuel> +config BR2_PACKAGE_SWFDEC_GSTREAMER
Emmanuel> + bool "swfdec gstreamer"
Emmanuel> + default y
Emmanuel> + depends on BR2_PACKAGE_SWFDEC
Emmanuel> + select BR2_PACKAGE_GSTREAMER
Emmanuel> + select BR2_PACKAGE_GST_PLUGINS_BASE
Emmanuel> + help
Emmanuel> + Enables GStreamer support
Same here (identation/trailing spaces). Why should this default to y? (I
don't know much about flash) Is swfdec not very useful without gstreamer
support?
Emmanuel> +#############################################################
Emmanuel> +#
Emmanuel> +# Swfdec
Emmanuel> +#
Emmanuel> +#############################################################
Emmanuel> +SWFDEC_VERSION_MAJOR:=0.8
Emmanuel> +SWFDEC_VERSION_MINOR:=4
Emmanuel> +SWFDEC_VERSION = $(SWFDEC_VERSION_MAJOR).$(SWFDEC_VERSION_MINOR)
Emmanuel> +
Emmanuel> +SWFDEC_SOURCE:=swfdec-$(SWFDEC_VERSION).tar.gz
Emmanuel> +SWFDEC_SITE:=http://swfdec.freedesktop.org/download/swfdec/$(SWFDEC_VERSION_MAJOR)
Emmanuel> +SWFDEC_LIBTOOL_PATCH = NO
Emmanuel> +SWFDEC_INSTALL_STAGING = YES
Emmanuel> +SWFDEC_INSTALL_TARGET = YES
You have a mix of styles here (:= vs =, spaces around =) - Is there any
reason for that?
Otherwise it looks good. Care to fix those issues and resubmit?
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH] Add Swfdec Free flash library
2009-09-25 18:51 ` Peter Korsgaard
@ 2009-09-28 10:55 ` Emmanuel Riou
2009-09-29 9:12 ` Emmanuel Riou
0 siblings, 1 reply; 9+ messages in thread
From: Emmanuel Riou @ 2009-09-28 10:55 UTC (permalink / raw)
To: buildroot
Peter Korsgaard wrote:
>>>>>> "Emmanuel" == Emmanuel Riou <riou.emmanuel@googlemail.com> writes:
>
> Emmanuel> Signed-off-by: Emmanuel Riou <riou.emmanuel@googlemail.com>
> Emmanuel> ---
>
> Thanks, a few remarks:
Hi! Thanks for your remarks and sorry for the slow reply...
>
> Emmanuel> +++ b/package/multimedia/swfdec/Config.in
> Emmanuel> @@ -0,0 +1,27 @@
> Emmanuel> +config BR2_PACKAGE_SWFDEC
> Emmanuel> + bool "swfdec"
> Emmanuel> + select BR2_PACKAGE_LIBSOUP
> Emmanuel> + select BR2_PACKAGE_LIBOIL
> Emmanuel> + select BR2_PACKAGE_ALSA_LIB
> Emmanuel> + help
> Emmanuel> + Library to play Flash Files
> Emmanuel> + http://swfdec.freedesktop.org/
>
> We normally have an empty line before the URL.
Alright I fixed it.
>
> Emmanuel> +
> Emmanuel> +config BR2_PACKAGE_SWFDEC_GTK
> Emmanuel> + bool "swfdec gtk"
> Emmanuel> + depends on BR2_PACKAGE_SWFDEC
> Emmanuel> + depends on BR2_PACKAGE_DIRECTFB || BR2_PACKAGE_XORG7
> Emmanuel> + select BR2_PACKAGE_LIBGTK2
> Emmanuel> + select BR2_PACKAGE_CAIRO_PNG
> Emmanuel> + help
> Emmanuel> + Enables swfdec-gtk
>
> Indentation is wrong for the depends/select lines (should be <tab>). We
> normally don't use select for stuff with complicated dependencies like
> gtk, so I think it would be nicer to simply depen on libgtk2 - Then you
> can also get rid of the directfb || xorg7 stuff.
OK fixed.
>
> You furthermore have trailing spaces in the help text. Maybe the config
> option and help text should say something like gtk support?
You're right, it's a bit more verbose now.
>
> Emmanuel> +
> Emmanuel> +config BR2_PACKAGE_SWFDEC_GSTREAMER
> Emmanuel> + bool "swfdec gstreamer"
> Emmanuel> + default y
> Emmanuel> + depends on BR2_PACKAGE_SWFDEC
> Emmanuel> + select BR2_PACKAGE_GSTREAMER
> Emmanuel> + select BR2_PACKAGE_GST_PLUGINS_BASE
> Emmanuel> + help
> Emmanuel> + Enables GStreamer support
>
> Same here (identation/trailing spaces). Why should this default to y? (I
> don't know much about flash) Is swfdec not very useful without gstreamer
> support?
I removed the default line. I put it as "default y" because it was
needed in my case (not a good reason, I know ;-)). Swfdec relies on
Gstreamer for all the audio and video stuff, but it is not mandatory to
have it since you can have Flash files without audio nor video.
>
> Emmanuel> +#############################################################
> Emmanuel> +#
> Emmanuel> +# Swfdec
> Emmanuel> +#
> Emmanuel> +#############################################################
> Emmanuel> +SWFDEC_VERSION_MAJOR:=0.8
> Emmanuel> +SWFDEC_VERSION_MINOR:=4
> Emmanuel> +SWFDEC_VERSION = $(SWFDEC_VERSION_MAJOR).$(SWFDEC_VERSION_MINOR)
> Emmanuel> +
> Emmanuel> +SWFDEC_SOURCE:=swfdec-$(SWFDEC_VERSION).tar.gz
> Emmanuel> +SWFDEC_SITE:=http://swfdec.freedesktop.org/download/swfdec/$(SWFDEC_VERSION_MAJOR)
> Emmanuel> +SWFDEC_LIBTOOL_PATCH = NO
> Emmanuel> +SWFDEC_INSTALL_STAGING = YES
> Emmanuel> +SWFDEC_INSTALL_TARGET = YES
>
> You have a mix of styles here (:= vs =, spaces around =) - Is there any
> reason for that?
Sorry for this inconsistency, it's fixed as well!
>
> Otherwise it looks good. Care to fix those issues and resubmit?
Thanks, I am resubmitting the patch.
Emmanuel.
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH] Add Swfdec Free flash library
2009-09-28 10:55 ` Emmanuel Riou
@ 2009-09-29 9:12 ` Emmanuel Riou
2009-09-29 10:04 ` Peter Korsgaard
0 siblings, 1 reply; 9+ messages in thread
From: Emmanuel Riou @ 2009-09-29 9:12 UTC (permalink / raw)
To: buildroot
Hi,
There is a typo in the Swfdec patch I submitted yesterday. I have just
resubmitted another one which fixes the typo (ohost-pkconfig instead of
host-pkgconfig), please take this one into account and not the one I
sent yesterday.
Kind regards,
Emmanuel.
Emmanuel Riou wrote:
> Peter Korsgaard wrote:
>>>>>>> "Emmanuel" == Emmanuel Riou <riou.emmanuel@googlemail.com> writes:
>>
>> Emmanuel> Signed-off-by: Emmanuel Riou <riou.emmanuel@googlemail.com>
>> Emmanuel> ---
>>
>> Thanks, a few remarks:
> Hi! Thanks for your remarks and sorry for the slow reply...
>
>>
>> Emmanuel> +++ b/package/multimedia/swfdec/Config.in
>> Emmanuel> @@ -0,0 +1,27 @@
>> Emmanuel> +config BR2_PACKAGE_SWFDEC
>> Emmanuel> + bool "swfdec"
>> Emmanuel> + select BR2_PACKAGE_LIBSOUP
>> Emmanuel> + select BR2_PACKAGE_LIBOIL
>> Emmanuel> + select BR2_PACKAGE_ALSA_LIB
>> Emmanuel> + help
>> Emmanuel> + Library to play Flash Files
>> Emmanuel> + http://swfdec.freedesktop.org/
>>
>> We normally have an empty line before the URL.
> Alright I fixed it.
>
>>
>> Emmanuel> +
>> Emmanuel> +config BR2_PACKAGE_SWFDEC_GTK
>> Emmanuel> + bool "swfdec gtk"
>> Emmanuel> + depends on BR2_PACKAGE_SWFDEC
>> Emmanuel> + depends on BR2_PACKAGE_DIRECTFB || BR2_PACKAGE_XORG7
>> Emmanuel> + select BR2_PACKAGE_LIBGTK2
>> Emmanuel> + select BR2_PACKAGE_CAIRO_PNG
>> Emmanuel> + help
>> Emmanuel> + Enables swfdec-gtk
>> Indentation is wrong for the depends/select lines (should be <tab>). We
>> normally don't use select for stuff with complicated dependencies like
>> gtk, so I think it would be nicer to simply depen on libgtk2 - Then you
>> can also get rid of the directfb || xorg7 stuff.
> OK fixed.
>
>>
>> You furthermore have trailing spaces in the help text. Maybe the config
>> option and help text should say something like gtk support?
> You're right, it's a bit more verbose now.
>
>
>>
>> Emmanuel> +
>> Emmanuel> +config BR2_PACKAGE_SWFDEC_GSTREAMER
>> Emmanuel> + bool "swfdec gstreamer"
>> Emmanuel> + default y
>> Emmanuel> + depends on BR2_PACKAGE_SWFDEC
>> Emmanuel> + select BR2_PACKAGE_GSTREAMER
>> Emmanuel> + select BR2_PACKAGE_GST_PLUGINS_BASE
>> Emmanuel> + help
>> Emmanuel> + Enables GStreamer support
>>
>> Same here (identation/trailing spaces). Why should this default to y? (I
>> don't know much about flash) Is swfdec not very useful without gstreamer
>> support?
> I removed the default line. I put it as "default y" because it was
> needed in my case (not a good reason, I know ;-)). Swfdec relies on
> Gstreamer for all the audio and video stuff, but it is not mandatory to
> have it since you can have Flash files without audio nor video.
>
>>
>> Emmanuel> +#############################################################
>> Emmanuel> +#
>> Emmanuel> +# Swfdec
>> Emmanuel> +#
>> Emmanuel> +#############################################################
>> Emmanuel> +SWFDEC_VERSION_MAJOR:=0.8
>> Emmanuel> +SWFDEC_VERSION_MINOR:=4
>> Emmanuel> +SWFDEC_VERSION =
>> $(SWFDEC_VERSION_MAJOR).$(SWFDEC_VERSION_MINOR)
>> Emmanuel> +
>> Emmanuel> +SWFDEC_SOURCE:=swfdec-$(SWFDEC_VERSION).tar.gz
>> Emmanuel>
>> +SWFDEC_SITE:=http://swfdec.freedesktop.org/download/swfdec/$(SWFDEC_VERSION_MAJOR)
>>
>> Emmanuel> +SWFDEC_LIBTOOL_PATCH = NO
>> Emmanuel> +SWFDEC_INSTALL_STAGING = YES
>> Emmanuel> +SWFDEC_INSTALL_TARGET = YES
>>
>> You have a mix of styles here (:= vs =, spaces around =) - Is there any
>> reason for that?
> Sorry for this inconsistency, it's fixed as well!
>
>>
>> Otherwise it looks good. Care to fix those issues and resubmit?
> Thanks, I am resubmitting the patch.
>
> Emmanuel.
>>
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH] Add Swfdec Free flash library
2009-09-29 9:12 ` Emmanuel Riou
@ 2009-09-29 10:04 ` Peter Korsgaard
2009-09-29 10:12 ` Emmanuel Riou
0 siblings, 1 reply; 9+ messages in thread
From: Peter Korsgaard @ 2009-09-29 10:04 UTC (permalink / raw)
To: buildroot
>>>>> "Emmanuel" == Emmanuel Riou <emmanuel.riou@toumaz.com> writes:
Emmanuel> Hi,
Emmanuel> There is a typo in the Swfdec patch I submitted yesterday. I have just
Emmanuel> resubmitted another one which fixes the typo (ohost-pkconfig instead
Emmanuel> of host-pkgconfig), please take this one into account and not the one
Emmanuel> I sent yesterday.
Yes, I noticed ;) Don't worry, I fixed it up myself and committed your
2nd version.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH] Add Swfdec Free flash library
2009-09-29 10:04 ` Peter Korsgaard
@ 2009-09-29 10:12 ` Emmanuel Riou
0 siblings, 0 replies; 9+ messages in thread
From: Emmanuel Riou @ 2009-09-29 10:12 UTC (permalink / raw)
To: buildroot
Peter Korsgaard wrote:
>>>>>> "Emmanuel" == Emmanuel Riou <emmanuel.riou@toumaz.com> writes:
>
> Emmanuel> Hi,
> Emmanuel> There is a typo in the Swfdec patch I submitted yesterday. I have just
> Emmanuel> resubmitted another one which fixes the typo (ohost-pkconfig instead
> Emmanuel> of host-pkgconfig), please take this one into account and not the one
> Emmanuel> I sent yesterday.
>
> Yes, I noticed ;) Don't worry, I fixed it up myself and committed your
> 2nd version.
>
Thanks Peter!
Emmanuel.
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2009-09-29 10:12 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-09-28 11:03 [Buildroot] [PATCH] Add Swfdec Free flash library Emmanuel Riou
2009-09-29 9:48 ` Peter Korsgaard
-- strict thread matches above, loose matches on Subject: below --
2009-09-29 9:08 Emmanuel Riou
2009-09-25 15:32 Emmanuel Riou
2009-09-25 18:51 ` Peter Korsgaard
2009-09-28 10:55 ` Emmanuel Riou
2009-09-29 9:12 ` Emmanuel Riou
2009-09-29 10:04 ` Peter Korsgaard
2009-09-29 10:12 ` Emmanuel Riou
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox