[Buildroot] [PATCH] directfb: allow to enable debug and trace support

[Buildroot] [PATCH] directfb: allow to enable debug and trace support

[Sven Neumann]

This change adds two new options, BR2_PACKAGE_DIRECTFB_DEBUG
to enable lots of debugging output from DirectFB and
BR2_PACKAGE_DIRECTFB_TRACE to enable support for call traces
in case of a crash.

Signed-off-by: Sven Neumann <s.neumann@raumfeld.com>
---
 package/directfb/Config.in   |   13 ++++++++++++-
 package/directfb/directfb.mk |   15 +++++++++++++++
 2 files changed, 27 insertions(+), 1 deletions(-)

diff --git a/package/directfb/Config.in b/package/directfb/Config.in
index 4642ee0..e616314 100644
--- a/package/directfb/Config.in
+++ b/package/directfb/Config.in
@@ -11,7 +11,18 @@ config BR2_PACKAGE_DIRECTFB_MULTI
 	select BR2_PACKAGE_LINUX_FUSION
 	help
 	  Enable use of multiple concurrent DirectFB applications
-	  http://www.directfb.org/
+
+config BR2_PACKAGE_DIRECTFB_DEBUG
+	bool "directfb debugging"
+	depends on BR2_PACKAGE_DIRECTFB
+	help
+	  Compile DirectFB with lots of debug output
+
+config BR2_PACKAGE_DIRECTFB_TRACE
+	bool "directfb call trace support"
+	depends on BR2_PACKAGE_DIRECTFB
+	help
+	  Enable call tracing for DirectFB applications
 
 config BR2_PACKAGE_DIRECTFB_XSERVER
 	bool "build with X server backend"
diff --git a/package/directfb/directfb.mk b/package/directfb/directfb.mk
index 8456798..b3af0ed 100644
--- a/package/directfb/directfb.mk
+++ b/package/directfb/directfb.mk
@@ -19,6 +19,19 @@ else
 DIRECTFB_MULTI:=
 DIRECTFB_FUSION:=
 endif
+
+ifeq ($(BR2_PACKAGE_DIRECTFB_DEBUG),y)
+DIRECTFB_DEBUG:=--enable-debug
+else
+DIRECTFB_DEBUG:=
+endif
+
+ifeq ($(BR2_PACKAGE_DIRECTFB_TRACE),y)
+DIRECTFB_TRACE:=--enable-trace
+else
+DIRECTFB_TRACE:=
+endif
+
 ifeq ($(BR2_PACKAGE_XSERVER),y)
 DIRECTFB_X:=--enable-x11
 else
@@ -114,6 +127,8 @@ DIRECTFB_CONF_OPT = \
 	--enable-shared \
 	--disable-explicit-deps \
 	$(DIRECTFB_MULTI) \
+	$(DIRECTFB_DEBUG) \
+	$(DIRECTFB_TRACE) \
 	$(DIRECTFB_X) \
 	$(DIRECTFB_JPEG) \
 	$(DIRECTFB_PNG) \
-- 
1.6.0.4

[Buildroot] [PATCH] directfb: allow to enable debug and trace support

[Lionel Landwerlin]

Le jeudi 06 ao?t 2009 ? 12:28 +0200, Sven Neumann a ?crit :
> This change adds two new options, BR2_PACKAGE_DIRECTFB_DEBUG
> to enable lots of debugging output from DirectFB and
> BR2_PACKAGE_DIRECTFB_TRACE to enable support for call traces
> in case of a crash.
> 
> Signed-off-by: Sven Neumann <s.neumann@raumfeld.com>
> ---
>  package/directfb/Config.in   |   13 ++++++++++++-
>  package/directfb/directfb.mk |   15 +++++++++++++++
>  2 files changed, 27 insertions(+), 1 deletions(-)
> 
> diff --git a/package/directfb/Config.in b/package/directfb/Config.in
> index 4642ee0..e616314 100644
> --- a/package/directfb/Config.in
> +++ b/package/directfb/Config.in
> @@ -11,7 +11,18 @@ config BR2_PACKAGE_DIRECTFB_MULTI
>  	select BR2_PACKAGE_LINUX_FUSION
>  	help
>  	  Enable use of multiple concurrent DirectFB applications
> -	  http://www.directfb.org/
> +
> +config BR2_PACKAGE_DIRECTFB_DEBUG
> +	bool "directfb debugging"
> +	depends on BR2_PACKAGE_DIRECTFB
> +	help
> +	  Compile DirectFB with lots of debug output
> +
> +config BR2_PACKAGE_DIRECTFB_TRACE
> +	bool "directfb call trace support"
> +	depends on BR2_PACKAGE_DIRECTFB
> +	help
> +	  Enable call tracing for DirectFB applications
>  
>  config BR2_PACKAGE_DIRECTFB_XSERVER
>  	bool "build with X server backend"
> diff --git a/package/directfb/directfb.mk b/package/directfb/directfb.mk
> index 8456798..b3af0ed 100644
> --- a/package/directfb/directfb.mk
> +++ b/package/directfb/directfb.mk
> @@ -19,6 +19,19 @@ else
>  DIRECTFB_MULTI:=
>  DIRECTFB_FUSION:=
>  endif
> +
> +ifeq ($(BR2_PACKAGE_DIRECTFB_DEBUG),y)
> +DIRECTFB_DEBUG:=--enable-debug
> +else
> +DIRECTFB_DEBUG:=
> +endif
> +
> +ifeq ($(BR2_PACKAGE_DIRECTFB_TRACE),y)
> +DIRECTFB_TRACE:=--enable-trace
> +else
> +DIRECTFB_TRACE:=
> +endif
> +
>  ifeq ($(BR2_PACKAGE_XSERVER),y)
>  DIRECTFB_X:=--enable-x11
>  else
> @@ -114,6 +127,8 @@ DIRECTFB_CONF_OPT = \
>  	--enable-shared \
>  	--disable-explicit-deps \
>  	$(DIRECTFB_MULTI) \
> +	$(DIRECTFB_DEBUG) \
> +	$(DIRECTFB_TRACE) \
>  	$(DIRECTFB_X) \
>  	$(DIRECTFB_JPEG) \
>  	$(DIRECTFB_PNG) \

Also proposed in https://bugs.busybox.net/show_bug.cgi?id=471

I'm using --enable-debug and --enable-debug-support instead of
--enable-debug only. Does it make sense ?


-- 
Lionel Landwerlin <lionel.landwerlin@openwide.fr>

[Buildroot] [PATCH] directfb: allow to enable debug and trace support

[Sven Neumann]

Hi,

On Thu, 2009-08-06 at 14:17 +0200, Lionel Landwerlin wrote:

> Also proposed in https://bugs.busybox.net/show_bug.cgi?id=471
> 
> I'm using --enable-debug and --enable-debug-support instead of
> --enable-debug only. Does it make sense ?

--enable-debug-support is on by default anyway. But these two options
are definitely confusing. I am having trouble to understand does what.

My main point was to add support for the --enable-trace option. Perhaps
I should have done that separately.


Sven

[Buildroot] [PATCH] directfb: allow to enable debug and trace support

[Thomas Petazzoni]

Le Thu,  6 Aug 2009 12:28:15 +0200,
Sven Neumann <s.neumann@raumfeld.com> a ?crit :

> This change adds two new options, BR2_PACKAGE_DIRECTFB_DEBUG
> to enable lots of debugging output from DirectFB and
> BR2_PACKAGE_DIRECTFB_TRACE to enable support for call traces
> in case of a crash.

Pulled and pushed into my for-2009.08 branch, that should be pulled by
Peter when he comes back from holidays.

 http://git.buildroot.net/~tpetazzoni/git/buildroot/log/?h=for-2009.08

Thanks,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers and embedded Linux development,
consulting, training and support.
http://free-electrons.com

[Buildroot] [PATCH] directfb: allow to enable debug and trace support

[Peter Korsgaard]

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 Thomas> Le Thu,  6 Aug 2009 12:28:15 +0200,
 Thomas> Sven Neumann <s.neumann@raumfeld.com> a ?crit :

 >> This change adds two new options, BR2_PACKAGE_DIRECTFB_DEBUG
 >> to enable lots of debugging output from DirectFB and
 >> BR2_PACKAGE_DIRECTFB_TRACE to enable support for call traces
 >> in case of a crash.

 Thomas> Pulled and pushed into my for-2009.08 branch, that should be pulled by
 Thomas> Peter when he comes back from holidays.

Done.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH] directfb: allow to enable debug and trace support

[Thomas Petazzoni]

Le Mon, 24 Aug 2009 22:59:49 +0200,
Peter Korsgaard <jacmet@uclibc.org> a ?crit :

>  Thomas> Pulled and pushed into my for-2009.08 branch, that should be
>  Thomas> pulled by Peter when he comes back from holidays.
> 
> Done.

Thanks!

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers and embedded Linux development,
consulting, training and support.
http://free-electrons.com