[Buildroot] [PATCH 1/1] package/libgeos: needs gcc >= 4.9

[Buildroot] [PATCH 1/1] package/libgeos: needs gcc >= 4.9

[Fabrice Fontaine]

libgeos needs gcc >= 4.9 since bump to version 3.12.0 in commit
16727d4595dd1972a46e92bbd2260a896cc19b60 and
https://github.com/libgeos/geos/commit/289ed4efb26a9944f4385381e1574184b1e7448e:

In file included from /home/thomas/autobuild/instance-0/output-1/build/libgeos-3.12.0/src/algorithm/ConvexHull.cpp:30:0:
/home/thomas/autobuild/instance-0/output-1/build/libgeos-3.12.0/include/geos/util.h:38:12: error: 'std::make_unique' has not been declared
 using std::make_unique;
            ^

Fixes:
 - http://autobuild.buildroot.org/results/56bb572fb1d56d45dbb950a73b9b888239fa6968

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/libgeos/Config.in | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/package/libgeos/Config.in b/package/libgeos/Config.in
index 8411627d43..2a27c6f2a4 100644
--- a/package/libgeos/Config.in
+++ b/package/libgeos/Config.in
@@ -3,6 +3,7 @@ config BR2_PACKAGE_LIBGEOS
 	depends on BR2_INSTALL_LIBSTDCPP
 	depends on BR2_USE_WCHAR
 	depends on BR2_TOOLCHAIN_HAS_THREADS
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # C++14
 	depends on !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597
 	help
 	  GEOS (Geometry Engine - Open Source) is a C++ port of the
@@ -13,7 +14,8 @@ config BR2_PACKAGE_LIBGEOS
 
 	  https://trac.osgeo.org/geos
 
-comment "libgeos needs a toolchain w/ C++, wchar, threads not binutils bug 27597"
+comment "libgeos needs a toolchain w/ C++, wchar, gcc >= 4.9, threads not binutils bug 27597"
 	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \
 		   !BR2_TOOLCHAIN_HAS_THREADS || \
+		   !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 || \
 		   BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597
-- 
2.42.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/libgeos: needs gcc >= 4.9

[Maxim Kochetkov via buildroot]

On 15.10.2023 23:14, Fabrice Fontaine wrote:
> libgeos needs gcc >= 4.9 since bump to version 3.12.0 in commit
> 16727d4595dd1972a46e92bbd2260a896cc19b60 and
> https://github.com/libgeos/geos/commit/289ed4efb26a9944f4385381e1574184b1e7448e:
> 
> In file included from /home/thomas/autobuild/instance-0/output-1/build/libgeos-3.12.0/src/algorithm/ConvexHull.cpp:30:0:
> /home/thomas/autobuild/instance-0/output-1/build/libgeos-3.12.0/include/geos/util.h:38:12: error: 'std::make_unique' has not been declared
>   using std::make_unique;
>              ^
> 
> Fixes:
>   - http://autobuild.buildroot.org/results/56bb572fb1d56d45dbb950a73b9b888239fa6968
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Reviewed-by: Maxim Kochetkov <fido_max@inbox.ru>
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/libgeos: needs gcc >= 4.9

[Thomas Petazzoni via buildroot]

On Sun, 15 Oct 2023 22:14:49 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> libgeos needs gcc >= 4.9 since bump to version 3.12.0 in commit
> 16727d4595dd1972a46e92bbd2260a896cc19b60 and
> https://github.com/libgeos/geos/commit/289ed4efb26a9944f4385381e1574184b1e7448e:
> 
> In file included from /home/thomas/autobuild/instance-0/output-1/build/libgeos-3.12.0/src/algorithm/ConvexHull.cpp:30:0:
> /home/thomas/autobuild/instance-0/output-1/build/libgeos-3.12.0/include/geos/util.h:38:12: error: 'std::make_unique' has not been declared
>  using std::make_unique;
>             ^
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/56bb572fb1d56d45dbb950a73b9b888239fa6968
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/libgeos/Config.in | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

I've applied, but you had forgotten to look at the reverse dependencies
of BR2_PACKAGE_LIBGEOS. Namely, BR2_PACKAGE_POSTGIS selects
BR2_PACKAGE_LIBGEOS, so it needs to inherit this dependency on gcc >=
4.9, so I fixed that when applying.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/libgeos: needs gcc >= 4.9

[Peter Korsgaard]

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > libgeos needs gcc >= 4.9 since bump to version 3.12.0 in commit
 > 16727d4595dd1972a46e92bbd2260a896cc19b60 and
 > https://github.com/libgeos/geos/commit/289ed4efb26a9944f4385381e1574184b1e7448e:

 > In file included from /home/thomas/autobuild/instance-0/output-1/build/libgeos-3.12.0/src/algorithm/ConvexHull.cpp:30:0:
 > /home/thomas/autobuild/instance-0/output-1/build/libgeos-3.12.0/include/geos/util.h:38:12: error: 'std::make_unique' has not been declared
 >  using std::make_unique;
 >             ^

 > Fixes:
 >  - http://autobuild.buildroot.org/results/56bb572fb1d56d45dbb950a73b9b888239fa6968

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed to 2023.08.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot