[Buildroot] [git commit] package/nettle: add missing host-gmp dependency

[Buildroot] [git commit] package/nettle: add missing host-gmp dependency

[Thomas Petazzoni via buildroot]

commit: https://git.buildroot.net/buildroot/commit/?id=db3a730e8ce42b8f70f469eafe53e9e5981e57b7
branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master

Since the generic package infrastructure removed auto derivation of
host dependencies [1] (2016.08), the host dependencies must be
explicitly set.

While adding the nettle host variant [2] the gmp dependency was not
duplicated and host-nettle was built without host-gmp (or built with
gmp installed on the build machine).

While building host-gnutls required for building mkeficapsule u-boot
tool, the configure script check if Libhogweed (nettle's companion
library) is build with libgmp support.

If internal toolchain is used, luckily host-gmp is built before
building host-nettle (and host-gnutls). But when using prebuilt
external toolchain, following error shows up :

Libhogweed (nettle's companion library) 3.6 was not found. Note that you must compile nettle with gmp support.

[1] https://gitlab.com/buildroot.org/buildroot/-/commit/4bdb067e380e72c3a6cb9c6ccf3791a6cf8661e0
[2] https://gitlab.com/buildroot.org/buildroot/-/commit/dac6e3011883ce3b35cbf64ec156186153bf0032
[3] https://gitlab.com/gnutls/gnutls/-/commit/eb24bfa808ee029e9b3b198d66d29256eea3fd08

Signed-off-by: Fabien Thomas <fabien.thomas@smile.fr>
Reviewed-by: Romain Naour <romain.naour@smile.fr>
Acked-by: Romain Naour <romain.naour@smile.fr>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
 package/nettle/nettle.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/nettle/nettle.mk b/package/nettle/nettle.mk
index 04e3adb84e..adeaf40868 100644
--- a/package/nettle/nettle.mk
+++ b/package/nettle/nettle.mk
@@ -15,7 +15,7 @@ NETTLE_CPE_ID_VENDOR = nettle_project
 # with static linking
 NETTLE_CONF_OPTS = --disable-openssl
 
-HOST_NETTLE_DEPENDENCIES = host-m4
+HOST_NETTLE_DEPENDENCIES = host-m4 host-gmp
 
 # ARM assembly requires v6+ ISA
 ifeq ($(BR2_ARM_CPU_ARMV4)$(BR2_ARM_CPU_ARMV5)$(BR2_ARM_CPU_ARMV7M),y)
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [git commit] package/nettle: add missing host-gmp dependency

[Peter Korsgaard]

>>>>> "Thomas" == Thomas Petazzoni via buildroot <buildroot@buildroot.org> writes:

 > commit: https://git.buildroot.net/buildroot/commit/?id=db3a730e8ce42b8f70f469eafe53e9e5981e57b7
 > branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master

 > Since the generic package infrastructure removed auto derivation of
 > host dependencies [1] (2016.08), the host dependencies must be
 > explicitly set.

 > While adding the nettle host variant [2] the gmp dependency was not
 > duplicated and host-nettle was built without host-gmp (or built with
 > gmp installed on the build machine).

 > While building host-gnutls required for building mkeficapsule u-boot
 > tool, the configure script check if Libhogweed (nettle's companion
 > library) is build with libgmp support.

 > If internal toolchain is used, luckily host-gmp is built before
 > building host-nettle (and host-gnutls). But when using prebuilt
 > external toolchain, following error shows up :

 > Libhogweed (nettle's companion library) 3.6 was not found. Note that you must compile nettle with gmp support.

 > [1] https://gitlab.com/buildroot.org/buildroot/-/commit/4bdb067e380e72c3a6cb9c6ccf3791a6cf8661e0
 > [2] https://gitlab.com/buildroot.org/buildroot/-/commit/dac6e3011883ce3b35cbf64ec156186153bf0032
 > [3] https://gitlab.com/gnutls/gnutls/-/commit/eb24bfa808ee029e9b3b198d66d29256eea3fd08

 > Signed-off-by: Fabien Thomas <fabien.thomas@smile.fr>
 > Reviewed-by: Romain Naour <romain.naour@smile.fr>
 > Acked-by: Romain Naour <romain.naour@smile.fr>
 > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Committed to 2023.02.x and 2023.08.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot