Re: [Buildroot] [next 08/25] package/pugixml: unconditionally set BUILD_DEFINES

[Peter Korsgaard <peter@korsgaard.com>]

>>>>> "Ricardo" == Ricardo Martincoski <ricardo.martincoski@gmail.com> writes:

 > The ifdef construct intended to avoid passing -DBUILD_DEFINES="" was
 > never needed, because even upstream version v1.9 used in 2019 when the
 > configuration options were added, can handle an empty string for
 > BUILD_DEFINES.
 > In fact an empty string is the default for v1.9 if it is not passed
 > during configure.

 > Also, the host variant already sets BUILD_DEFINES unconditionally.

 > So remove the unneeded conditional.

 > Cc: Arnout Vandecappelle <arnout@mind.be>
 > Cc: Theo Debrouwere <t.debrouwere@televic.com>
 > Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
 > ---
 > NOTE 1:
 > For versions starting from v1.11 this flag BUILD_DEFINES is ignored, but
 > it will be fixed in the next patch.
 > I had split into 2 patches because this first one applies to old
 > versions of the package too. Someone could theoretically decide to
 > backport to a local copy of buildroot 2020.05.x for instance.

 > NOTE 2:
 > It doesn't test much, since BUILD_DEFINES is ignored, but anyway:
 > https://gitlab.com/RicardoMartincoski/buildroot/-/pipelines/704554673
 > 44 builds, 1 skipped, 0 build failed, 0 legal-info failed, 0 show-info failed
 > test-pkg config:
 > BR2_PACKAGE_PUGIXML=y

Committed to 2022.11.x and 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot