Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: Ricardo Martincoski <ricardo.martincoski@gmail.com>
Cc: "Yann E . MORIN" <yann.morin.1998@free.fr>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	buildroot@buildroot.org, Romain Naour <romain.naour@gmail.com>,
	Giulio Benetti <giulio.benetti@benettiengineering.com>,
	Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
Subject: Re: [Buildroot] [next 13/25] toolchain/toolchain-buildroot: add comment about using virtual package infra
Date: Mon, 06 Feb 2023 12:26:29 +0100	[thread overview]
Message-ID: <87fsbjavbu.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20221127130739.1862398-14-ricardo.martincoski@gmail.com> (Ricardo Martincoski's message of "Sun, 27 Nov 2022 10:07:27 -0300")

>>>>> "Ricardo" == Ricardo Martincoski <ricardo.martincoski@gmail.com> writes:

 > Commit "9a8ec9195c toolchain/toolchain-buildroot: migrate to virtual
 > package infrastructure" made the packages toolchain and
 > toolchain-buildroot to use the virtual package infra even they being
 > generic packages.
 > This works because on package/pkg-virtual.mk when a package do not
 > define neither _PROVIDES_ or _HAS_ symbols, only _IS_VIRTUAL is set to
 > YES and _VERSION and _SOURCE are set to empty before relaying the call
 > to inner-generic-package.

 > Add a comment explaining why the virtual package infra is used in these
 > cases.

 > Cc: Giulio Benetti <giulio.benetti@benettiengineering.com>
 > Cc: Romain Naour <romain.naour@gmail.com>
 > Cc: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
 > Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
 > Cc: Yann E. MORIN <yann.morin.1998@free.fr>
 > Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>

Committed, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2023-02-06 11:26 UTC|newest]

Thread overview: 74+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-27 13:07 [Buildroot] [next 00/25] check-symbols v2 Ricardo Martincoski
2022-11-27 13:07 ` [Buildroot] [next 01/25] *: fix typo for separate(d|) in text Ricardo Martincoski
2023-02-06 10:23   ` Peter Korsgaard
2023-02-22 16:08   ` Peter Korsgaard
2022-11-27 13:07 ` [Buildroot] [next 02/25] package, legacy: fix typo for "daemon" on help text Ricardo Martincoski
2023-02-06 10:24   ` Peter Korsgaard
2023-02-22 16:08   ` Peter Korsgaard
2022-11-27 13:07 ` [Buildroot] [next 03/25] Config.in.legacy: fix typo on BR2_PACKAGE_MEDIAART_BACKEND_QT Ricardo Martincoski
2023-02-06 10:26   ` Peter Korsgaard
2023-02-22 16:08   ` Peter Korsgaard
2022-11-27 13:07 ` [Buildroot] [next 04/25] utils/checkpackagelib: warn about redefined config Ricardo Martincoski
2023-02-06 11:03   ` Peter Korsgaard
2023-02-22 16:09   ` Peter Korsgaard
2022-11-27 13:07 ` [Buildroot] [next 05/25] support/scripts/generate-gitlab-ci-yml: improve test-pkg support Ricardo Martincoski
2023-02-06 11:04   ` Peter Korsgaard
2023-02-22 16:38   ` Peter Korsgaard
2022-11-27 13:07 ` [Buildroot] [next 06/25] package/fwts: use ifeq instead of ifdef Ricardo Martincoski
2023-02-06 11:04   ` Peter Korsgaard
2023-02-22 16:38   ` Peter Korsgaard
2022-11-27 13:07 ` [Buildroot] [next 07/25] package/live555: fix build config with locale Ricardo Martincoski
2023-02-06 11:06   ` Peter Korsgaard
2023-02-22 16:38   ` Peter Korsgaard
2022-11-27 13:07 ` [Buildroot] [next 08/25] package/pugixml: unconditionally set BUILD_DEFINES Ricardo Martincoski
2023-02-06 11:07   ` Peter Korsgaard
2023-02-22 16:39   ` Peter Korsgaard
2022-11-27 13:07 ` [Buildroot] [next 09/25] package/pugixml: fix configuration options Ricardo Martincoski
2023-02-06 11:09   ` Peter Korsgaard
2023-02-22 16:40   ` Peter Korsgaard
2022-11-27 13:07 ` [Buildroot] [next 10/25] package/pugixml: use explicit build options Ricardo Martincoski
2023-02-06 11:12   ` Peter Korsgaard
2023-02-22 16:41   ` Peter Korsgaard
2022-11-27 13:07 ` [Buildroot] [next 11/25] package/busybox: add comment about variable override Ricardo Martincoski
2023-02-06 11:13   ` Peter Korsgaard
2023-02-22 16:41   ` Peter Korsgaard
2022-11-27 13:07 ` [Buildroot] [next 12/25] utils/checkpackagelib: warn about ifdef on .mk Ricardo Martincoski
2023-02-06 11:15   ` Peter Korsgaard
2023-02-22 16:44   ` Peter Korsgaard
2022-11-27 13:07 ` [Buildroot] [next 13/25] toolchain/toolchain-buildroot: add comment about using virtual package infra Ricardo Martincoski
2023-02-06 11:26   ` Peter Korsgaard [this message]
2023-02-22 16:44   ` Peter Korsgaard
2022-11-27 13:07 ` [Buildroot] [next 14/25] boot/uboot: remove use of legacy xloader symbol Ricardo Martincoski
2023-02-06 11:26   ` Peter Korsgaard
2023-02-22 16:45   ` Peter Korsgaard
2022-11-27 13:07 ` [Buildroot] [next 15/25] system: remove use of legacy md5 option Ricardo Martincoski
2023-02-06 11:27   ` Peter Korsgaard
2023-02-22 16:45   ` Peter Korsgaard
2022-11-27 13:07 ` [Buildroot] [next 16/25] package/linux-headers: remove bogus symbol BR2_PACKAGE_HOST_LINUX_HEADERS Ricardo Martincoski
2023-02-06 11:29   ` Peter Korsgaard
2023-02-22 16:46   ` Peter Korsgaard
2022-11-27 13:07 ` [Buildroot] [next 17/25] package/gitlab-runner: ensure use of LIBCURL_OPENSSL Ricardo Martincoski
2023-02-06 11:37   ` Peter Korsgaard
2023-02-06 15:05     ` Peter Korsgaard
2022-11-27 13:07 ` [Buildroot] [next 18/25] package/openpowerlink: properly handle legacy options Ricardo Martincoski
2023-02-06 11:45   ` Peter Korsgaard
2023-02-22 16:47   ` Peter Korsgaard
2022-11-27 13:07 ` [Buildroot] [next 19/25] package/gcc: properly handle legacy for renamed ARC option Ricardo Martincoski
2023-02-06 11:48   ` Peter Korsgaard
2023-02-22 16:47   ` Peter Korsgaard
2022-11-27 13:07 ` [Buildroot] [next 20/25] package/lua: properly handle legacy for removed version Ricardo Martincoski
2023-02-06 13:22   ` Peter Korsgaard
2023-02-22 16:48   ` Peter Korsgaard
2022-11-27 13:07 ` [Buildroot] [next 21/25] package/ti-sgx-km: properly handle legacy for removed options Ricardo Martincoski
2023-02-06 13:25   ` Peter Korsgaard
2023-02-22 16:49   ` Peter Korsgaard
2022-11-27 13:07 ` [Buildroot] [next 22/25] package/openjdk: properly handle legacy for renamed options Ricardo Martincoski
2023-02-06 13:27   ` Peter Korsgaard
2023-02-22 16:49   ` Peter Korsgaard
2022-11-27 13:07 ` [Buildroot] [next 23/25] package/sunxi-mali-utgard: " Ricardo Martincoski
2023-02-06 13:28   ` Peter Korsgaard
2023-02-22 16:50   ` Peter Korsgaard
2022-11-27 13:07 ` [Buildroot] [next 24/25] package/rpi-userland: fix typo for BR2_aarch64 Ricardo Martincoski
2023-02-06 13:28   ` Peter Korsgaard
2022-11-27 13:07 ` [Buildroot] [next 25/25] utils/check-symbols: new script Ricardo Martincoski
2023-02-06 15:30   ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fsbjavbu.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@buildroot.org \
    --cc=giulio.benetti@benettiengineering.com \
    --cc=ricardo.martincoski@gmail.com \
    --cc=romain.naour@gmail.com \
    --cc=thomas.de_schampheleire@nokia.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=yann.morin.1998@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox