[Buildroot] [PATCH 1/1] php: intl support needs dynamic library

[Buildroot] [PATCH 1/1] php: intl support needs dynamic library

[Fabrice Fontaine]

getArgTypeList is defined in ext/intl/msgformat/msgformat_helpers.cpp
and icu library so add a !BR2_STATIC_LIBS dependency to
BR2_PACKAGE_PHP_EXT_INTL

Fixes:
 - http://autobuild.buildroot.org/results/628b677d1ceb8b404265d89357225e0a1dce1407

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/php/Config.ext | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/package/php/Config.ext b/package/php/Config.ext
index 3082462b4f..7e6b3e0e25 100644
--- a/package/php/Config.ext
+++ b/package/php/Config.ext
@@ -201,14 +201,15 @@ config BR2_PACKAGE_PHP_EXT_INTL
 	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # icu
 	depends on !BR2_BINFMT_FLAT # icu
 	depends on BR2_TOOLCHAIN_HAS_THREADS # icu
+	depends on !BR2_STATIC_LIBS
 	select BR2_PACKAGE_ICU
 	help
 	  Internationalization support
 
-comment "intl support needs a toolchain w/ C++, wchar, threads, gcc >= 4.8, host gcc >= 4.8"
+comment "intl support needs a toolchain w/ C++, wchar, threads, dynamic library, gcc >= 4.8, host gcc >= 4.8"
 	depends on !BR2_BINFMT_FLAT
 	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \
-		!BR2_TOOLCHAIN_HAS_THREADS || \
+		!BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS || \
 		!BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 || \
 		!BR2_HOST_GCC_AT_LEAST_4_8
 
-- 
2.17.1

[Buildroot] [PATCH 1/1] php: intl support needs dynamic library

[Peter Korsgaard]

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > getArgTypeList is defined in ext/intl/msgformat/msgformat_helpers.cpp

s/in/in both/

> and icu library so add a !BR2_STATIC_LIBS dependency to
 > BR2_PACKAGE_PHP_EXT_INTL

 > Fixes:
 >  - http://autobuild.buildroot.org/results/628b677d1ceb8b404265d89357225e0a1dce1407

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed with that changed, thanks.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH 1/1] php: intl support needs dynamic library

[Peter Korsgaard]

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > getArgTypeList is defined in ext/intl/msgformat/msgformat_helpers.cpp
 > and icu library so add a !BR2_STATIC_LIBS dependency to
 > BR2_PACKAGE_PHP_EXT_INTL

 > Fixes:
 >  - http://autobuild.buildroot.org/results/628b677d1ceb8b404265d89357225e0a1dce1407

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed to 2018.02.x and 2018.08.x, thanks.

-- 
Bye, Peter Korsgaard