From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] rp-pppoe: install helper scripts
Date: Wed, 03 Dec 2014 23:45:22 +0100 [thread overview]
Message-ID: <87ppc0wdx9.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20141203233939.1b8a856a@free-electrons.com> (Thomas Petazzoni's message of "Wed, 3 Dec 2014 23:39:39 +0100")
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
Hi,
> On a second thought, we could do:
> RP_PPPOE_TARGET_FILES = src/foo src/bar scripts/baz scripts/bleh
> and then do:
> for ff in $(RP_PPPOE_TARGET_FILES); do \
> $(INSTALL) -m 0755 $(@D)/$$ff $(TARGET_DIR)/usr/sbin/$$ff || exit 1; \
> done
Then you whould need to strip the directory part of $$ff for the
destination to not end up in $(TARGET_DIR)/usr/sbin/src/foo.
> Not sure it matters much, though.
I think keeping it in two loops is a bit more readable.
--
Venlig hilsen,
Peter Korsgaard
next prev parent reply other threads:[~2014-12-03 22:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-02 23:21 [Buildroot] [PATCH 1/2] rp-pppoe: install default conf file Ryan Coe
2014-12-02 23:21 ` [Buildroot] [PATCH 2/2] rp-pppoe: install helper scripts Ryan Coe
2014-12-03 15:05 ` Matthew Weber
2014-12-03 22:26 ` Thomas Petazzoni
2014-12-03 22:32 ` Peter Korsgaard
2014-12-03 22:38 ` Thomas Petazzoni
2014-12-03 22:39 ` Thomas Petazzoni
2014-12-03 22:45 ` Peter Korsgaard [this message]
2014-12-03 22:26 ` Peter Korsgaard
2014-12-03 15:03 ` [Buildroot] [PATCH 1/2] rp-pppoe: install default conf file Matthew Weber
2014-12-03 22:26 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ppc0wdx9.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox