Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] rp-pppoe: install helper scripts
Date: Wed, 03 Dec 2014 23:32:08 +0100	[thread overview]
Message-ID: <87tx1cwejb.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20141203232625.0ce7b9a5@free-electrons.com> (Thomas Petazzoni's message of "Wed, 3 Dec 2014 23:26:25 +0100")

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 > Dear Ryan Coe,
 > On Tue,  2 Dec 2014 15:21:03 -0800, Ryan Coe wrote:
 >> Signed-off-by: Ryan Coe <bluemrp9@gmail.com>
 >> ---
 >> package/rp-pppoe/rp-pppoe.mk | 5 +++++
 >> 1 file changed, 5 insertions(+)
 >> 
 >> diff --git a/package/rp-pppoe/rp-pppoe.mk b/package/rp-pppoe/rp-pppoe.mk
 >> index 70b4437..9c3e3e4 100644
 >> --- a/package/rp-pppoe/rp-pppoe.mk
 >> +++ b/package/rp-pppoe/rp-pppoe.mk
 >> @@ -11,6 +11,8 @@ RP_PPPOE_LICENSE_FILES = doc/LICENSE
 >> RP_PPPOE_DEPENDENCIES = pppd
 >> RP_PPPOE_SUBDIR = src
 >> RP_PPPOE_TARGET_FILES = pppoe pppoe-server pppoe-relay pppoe-sniff
 >> +RP_PPPOE_TARGET_SCRIPTS = pppoe-connect pppoe-init pppoe-setup pppoe-start \
 >> +	pppoe-stop

 > Any reason why we need a new variable instead of adding new values to
 > RP_PPPOE_TARGET_FILES ?

 >> @@ -23,6 +25,9 @@ define RP_PPPOE_INSTALL_TARGET_CMDS
 >> for ff in $(RP_PPPOE_TARGET_FILES); do \
 >> $(INSTALL) -m 0755 $(@D)/src/$$ff $(TARGET_DIR)/usr/sbin/$$ff || exit 1; \
 >> done
 >> +	for ff in $(RP_PPPOE_TARGET_SCRIPTS); do \
 >> +		$(INSTALL) -m 0755 $(@D)/scripts/$$ff $(TARGET_DIR)/usr/sbin/$$ff || exit 1; \
 >> +	done

 > Both variables do the same thing.

No, they copy from two different subdirs?

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2014-12-03 22:32 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-02 23:21 [Buildroot] [PATCH 1/2] rp-pppoe: install default conf file Ryan Coe
2014-12-02 23:21 ` [Buildroot] [PATCH 2/2] rp-pppoe: install helper scripts Ryan Coe
2014-12-03 15:05   ` Matthew Weber
2014-12-03 22:26   ` Thomas Petazzoni
2014-12-03 22:32     ` Peter Korsgaard [this message]
2014-12-03 22:38       ` Thomas Petazzoni
2014-12-03 22:39         ` Thomas Petazzoni
2014-12-03 22:45           ` Peter Korsgaard
2014-12-03 22:26   ` Peter Korsgaard
2014-12-03 15:03 ` [Buildroot] [PATCH 1/2] rp-pppoe: install default conf file Matthew Weber
2014-12-03 22:26 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tx1cwejb.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox