* [Buildroot] [git commit] avahi: fix avahi-ui build with libgtk3
@ 2014-10-31 11:50 Peter Korsgaard
2014-10-31 12:40 ` Thomas Petazzoni
2014-10-31 23:46 ` Jörg Krause
0 siblings, 2 replies; 14+ messages in thread
From: Peter Korsgaard @ 2014-10-31 11:50 UTC (permalink / raw)
To: buildroot
commit: http://git.buildroot.net/buildroot/commit/?id=e6c04e6daae674f8983ec2fb106fb897c6803c32
branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master
Fixes:
http://autobuild.buildroot.net/results/daa/daad247db16818f25ab33402e26e27257defbe13/
http://autobuild.buildroot.net/results/720/720e2c8a5eab8b47d2510fe03b4a90ec8beafc17/
http://autobuild.buildroot.net/results/02b/02b4ab9ee07707ee4a4d4ea2b9c67bee91b1392d/
http://autobuild.buildroot.net/results/819/81914317ce82dc1321484d8c2b65647f92aa6929/
And many others.
avahi-ui uses deprecated gtk functionality, but explicitly requests to
disable the deprecated API support in gtk - Breaking the build when building
against libgtk3.
Patch is taken from Fedora:
https://bugzilla.redhat.com/show_bug.cgi?id=1001676
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
package/avahi/avahi-no-gtk-deprecations.patch | 31 +++++++++++++++++++++++++
package/avahi/avahi.mk | 1 +
2 files changed, 32 insertions(+), 0 deletions(-)
diff --git a/package/avahi/avahi-no-gtk-deprecations.patch b/package/avahi/avahi-no-gtk-deprecations.patch
new file mode 100644
index 0000000..3a284d0
--- /dev/null
+++ b/package/avahi/avahi-no-gtk-deprecations.patch
@@ -0,0 +1,31 @@
+Patch from http://pkgs.fedoraproject.org/cgit/avahi.git/plain/avahi-0.6.31-no-deprecations.patch?id=b3f4de05e331258c5123e3acc144e452595c2112
+
+Don't disable deprecated GTK support, as that breaks builds with modern GTK3
+versions.
+
+For more details, see the Fedora bugzilla:
+https://bugzilla.redhat.com/show_bug.cgi?id=1001676
+
+Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
+--- avahi-0.6.31/avahi-ui/Makefile.am.orig 2013-09-21 16:47:28.677659361 +0200
++++ avahi-0.6.31/avahi-ui/Makefile.am 2013-09-21 16:47:34.852520537 +0200
+@@ -15,7 +15,7 @@
+ # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307
+ # USA.
+
+-AM_CFLAGS=-I$(top_srcdir) -DG_DISABLE_DEPRECATED=1 -DGDK_DISABLE_DEPRECATED=1 -DGTK_DISABLE_DEPRECATED=1
++AM_CFLAGS=-I$(top_srcdir)
+
+ # This cool debug trap works on i386/gcc only
+ AM_CFLAGS+='-DDEBUG_TRAP=__asm__("int $$3")'
+--- avahi-0.6.31/configure.ac.orig 2013-09-21 16:46:43.750669413 +0200
++++ avahi-0.6.31/configure.ac 2013-09-21 16:47:02.566246400 +0200
+@@ -92,7 +92,7 @@
+ AC_MSG_CHECKING([whether stack-smashing protection is available])
+ ssp_old_cflags="$CFLAGS"
+ ssp_old_ldflags="$LDFLAGS"
+- CFLAGS="$CFLAGS -Werror -fstack-protector-all -fPIC"
++ CFLAGS="$CFLAGS -fstack-protector-all -fPIC"
+ LDFLAGS="$LDFLAGS -Wl,-z,defs"
+ cat confdefs.h > conftest.c
+ cat >>conftest.c <<_ACEOF
diff --git a/package/avahi/avahi.mk b/package/avahi/avahi.mk
index 4e5dbc6..e4c327d 100644
--- a/package/avahi/avahi.mk
+++ b/package/avahi/avahi.mk
@@ -16,6 +16,7 @@ AVAHI_SITE = http://www.avahi.org/download
AVAHI_LICENSE = LGPLv2.1+
AVAHI_LICENSE_FILES = LICENSE
AVAHI_INSTALL_STAGING = YES
+AVAHI_AUTORECONF = YES
AVAHI_CONF_ENV = ac_cv_func_strtod=yes \
ac_fsusage_space=yes \
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [Buildroot] [git commit] avahi: fix avahi-ui build with libgtk3
2014-10-31 11:50 [Buildroot] [git commit] avahi: fix avahi-ui build with libgtk3 Peter Korsgaard
@ 2014-10-31 12:40 ` Thomas Petazzoni
2014-10-31 13:19 ` Peter Korsgaard
2014-10-31 23:46 ` Jörg Krause
1 sibling, 1 reply; 14+ messages in thread
From: Thomas Petazzoni @ 2014-10-31 12:40 UTC (permalink / raw)
To: buildroot
Dear Peter Korsgaard,
On Fri, 31 Oct 2014 12:50:49 +0100, Peter Korsgaard wrote:
> package/avahi/avahi-no-gtk-deprecations.patch | 31 +++++++++++++++++++++++++
Don't we have a patch naming policy?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Buildroot] [git commit] avahi: fix avahi-ui build with libgtk3
2014-10-31 12:40 ` Thomas Petazzoni
@ 2014-10-31 13:19 ` Peter Korsgaard
2014-10-31 13:30 ` Thomas Petazzoni
0 siblings, 1 reply; 14+ messages in thread
From: Peter Korsgaard @ 2014-10-31 13:19 UTC (permalink / raw)
To: buildroot
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
> Dear Peter Korsgaard,
> On Fri, 31 Oct 2014 12:50:49 +0100, Peter Korsgaard wrote:
>> package/avahi/avahi-no-gtk-deprecations.patch | 31 +++++++++++++++++++++++++
> Don't we have a patch naming policy?
We do, but this matches the rest of the patches and Samuel's megapatch
hasn't been applied yet so I chose match the others.
--
Venlig hilsen,
Peter Korsgaard
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Buildroot] [git commit] avahi: fix avahi-ui build with libgtk3
2014-10-31 13:19 ` Peter Korsgaard
@ 2014-10-31 13:30 ` Thomas Petazzoni
2014-10-31 16:18 ` Peter Korsgaard
0 siblings, 1 reply; 14+ messages in thread
From: Thomas Petazzoni @ 2014-10-31 13:30 UTC (permalink / raw)
To: buildroot
Dear Peter Korsgaard,
On Fri, 31 Oct 2014 14:19:44 +0100, Peter Korsgaard wrote:
> > Don't we have a patch naming policy?
>
> We do, but this matches the rest of the patches and Samuel's megapatch
> hasn't been applied yet so I chose match the others.
Ok, fair enough.
Do we want to apply Samuel's megapatch?
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Buildroot] [git commit] avahi: fix avahi-ui build with libgtk3
2014-10-31 13:30 ` Thomas Petazzoni
@ 2014-10-31 16:18 ` Peter Korsgaard
0 siblings, 0 replies; 14+ messages in thread
From: Peter Korsgaard @ 2014-10-31 16:18 UTC (permalink / raw)
To: buildroot
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
> Dear Peter Korsgaard,
> On Fri, 31 Oct 2014 14:19:44 +0100, Peter Korsgaard wrote:
>> > Don't we have a patch naming policy?
>>
>> We do, but this matches the rest of the patches and Samuel's megapatch
>> hasn't been applied yet so I chose match the others.
> Ok, fair enough.
> Do we want to apply Samuel's megapatch?
Yes, even though I dislike big changes I think we should rather do it
now and get over with it.
I'll look into it this weekend.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Buildroot] [git commit] avahi: fix avahi-ui build with libgtk3
2014-10-31 11:50 [Buildroot] [git commit] avahi: fix avahi-ui build with libgtk3 Peter Korsgaard
2014-10-31 12:40 ` Thomas Petazzoni
@ 2014-10-31 23:46 ` Jörg Krause
2014-11-01 9:29 ` Peter Korsgaard
2014-11-01 19:13 ` Yann E. MORIN
1 sibling, 2 replies; 14+ messages in thread
From: Jörg Krause @ 2014-10-31 23:46 UTC (permalink / raw)
To: buildroot
On Fr, 2014-10-31 at 12:50 +0100, Peter Korsgaard wrote:
> commit: http://git.buildroot.net/buildroot/commit/?id=e6c04e6daae674f8983ec2fb106fb897c6803c32
> branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master
>
> Fixes:
> http://autobuild.buildroot.net/results/daa/daad247db16818f25ab33402e26e27257defbe13/
> http://autobuild.buildroot.net/results/720/720e2c8a5eab8b47d2510fe03b4a90ec8beafc17/
> http://autobuild.buildroot.net/results/02b/02b4ab9ee07707ee4a4d4ea2b9c67bee91b1392d/
> http://autobuild.buildroot.net/results/819/81914317ce82dc1321484d8c2b65647f92aa6929/
>
> And many others.
>
> avahi-ui uses deprecated gtk functionality, but explicitly requests to
> disable the deprecated API support in gtk - Breaking the build when building
> against libgtk3.
>
> Patch is taken from Fedora:
> https://bugzilla.redhat.com/show_bug.cgi?id=1001676
>
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
> ---
> package/avahi/avahi-no-gtk-deprecations.patch | 31 +++++++++++++++++++++++++
> package/avahi/avahi.mk | 1 +
> 2 files changed, 32 insertions(+), 0 deletions(-)
>
> diff --git a/package/avahi/avahi-no-gtk-deprecations.patch b/package/avahi/avahi-no-gtk-deprecations.patch
> new file mode 100644
> index 0000000..3a284d0
> --- /dev/null
> +++ b/package/avahi/avahi-no-gtk-deprecations.patch
> @@ -0,0 +1,31 @@
> +Patch from http://pkgs.fedoraproject.org/cgit/avahi.git/plain/avahi-0.6.31-no-deprecations.patch?id=b3f4de05e331258c5123e3acc144e452595c2112
> +
> +Don't disable deprecated GTK support, as that breaks builds with modern GTK3
> +versions.
> +
> +For more details, see the Fedora bugzilla:
> +https://bugzilla.redhat.com/show_bug.cgi?id=1001676
> +
> +Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
> +--- avahi-0.6.31/avahi-ui/Makefile.am.orig 2013-09-21 16:47:28.677659361 +0200
> ++++ avahi-0.6.31/avahi-ui/Makefile.am 2013-09-21 16:47:34.852520537 +0200
> +@@ -15,7 +15,7 @@
> + # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307
> + # USA.
> +
> +-AM_CFLAGS=-I$(top_srcdir) -DG_DISABLE_DEPRECATED=1 -DGDK_DISABLE_DEPRECATED=1 -DGTK_DISABLE_DEPRECATED=1
> ++AM_CFLAGS=-I$(top_srcdir)
> +
> + # This cool debug trap works on i386/gcc only
> + AM_CFLAGS+='-DDEBUG_TRAP=__asm__("int $$3")'
> +--- avahi-0.6.31/configure.ac.orig 2013-09-21 16:46:43.750669413 +0200
> ++++ avahi-0.6.31/configure.ac 2013-09-21 16:47:02.566246400 +0200
> +@@ -92,7 +92,7 @@
> + AC_MSG_CHECKING([whether stack-smashing protection is available])
> + ssp_old_cflags="$CFLAGS"
> + ssp_old_ldflags="$LDFLAGS"
> +- CFLAGS="$CFLAGS -Werror -fstack-protector-all -fPIC"
> ++ CFLAGS="$CFLAGS -fstack-protector-all -fPIC"
> + LDFLAGS="$LDFLAGS -Wl,-z,defs"
> + cat confdefs.h > conftest.c
> + cat >>conftest.c <<_ACEOF
> diff --git a/package/avahi/avahi.mk b/package/avahi/avahi.mk
> index 4e5dbc6..e4c327d 100644
> --- a/package/avahi/avahi.mk
> +++ b/package/avahi/avahi.mk
> @@ -16,6 +16,7 @@ AVAHI_SITE = http://www.avahi.org/download
> AVAHI_LICENSE = LGPLv2.1+
> AVAHI_LICENSE_FILES = LICENSE
> AVAHI_INSTALL_STAGING = YES
> +AVAHI_AUTORECONF = YES
>
> AVAHI_CONF_ENV = ac_cv_func_strtod=yes \
> ac_fsusage_space=yes \
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
This patch breaks building avahi for me. Is autoreconf really intended?
Removing it fixed my build.
>>> avahi 0.6.31 Autoreconfiguring
configure.ac:419: warning: macro 'AM_GLIB_GNU_GETTEXT' not found
in library
configure.ac:143: warning: AC_LANG_CONFTEST: no AC_LANG_SOURCE
call detected in body
../../lib/autoconf/lang.m4:193: AC_LANG_CONFTEST is expanded
from...
../../lib/autoconf/general.m4:2590: _AC_COMPILE_IFELSE is
expanded from...
../../lib/autoconf/general.m4:2606: AC_COMPILE_IFELSE is
expanded from...
../../lib/m4sugar/m4sh.m4:639: AS_IF is expanded from...
../../lib/autoconf/general.m4:2031: AC_CACHE_VAL is expanded
from...
../../lib/autoconf/general.m4:2052: AC_CACHE_CHECK is expanded
from...
configure.ac:143: the top level
configure.ac:300: warning: AC_LANG_CONFTEST: no AC_LANG_SOURCE
call detected in body
../../lib/autoconf/lang.m4:193: AC_LANG_CONFTEST is expanded
from...
configure.ac:300: the top level
configure.ac:143: warning: AC_LANG_CONFTEST: no AC_LANG_SOURCE
call detected in body
../../lib/autoconf/lang.m4:193: AC_LANG_CONFTEST is expanded
from...
../../lib/autoconf/general.m4:2590: _AC_COMPILE_IFELSE is
expanded from...
../../lib/autoconf/general.m4:2606: AC_COMPILE_IFELSE is
expanded from...
../../lib/m4sugar/m4sh.m4:639: AS_IF is expanded from...
../../lib/autoconf/general.m4:2031: AC_CACHE_VAL is expanded
from...
../../lib/autoconf/general.m4:2052: AC_CACHE_CHECK is expanded
from...
configure.ac:143: the top level
configure.ac:300: warning: AC_LANG_CONFTEST: no AC_LANG_SOURCE
call detected in body
../../lib/autoconf/lang.m4:193: AC_LANG_CONFTEST is expanded
from...
configure.ac:300: the top level
configure.ac:143: warning: AC_LANG_CONFTEST: no AC_LANG_SOURCE
call detected in body
../../lib/autoconf/lang.m4:193: AC_LANG_CONFTEST is expanded
from...
../../lib/autoconf/general.m4:2590: _AC_COMPILE_IFELSE is
expanded from...
../../lib/autoconf/general.m4:2606: AC_COMPILE_IFELSE is
expanded from...
../../lib/m4sugar/m4sh.m4:639: AS_IF is expanded from...
../../lib/autoconf/general.m4:2031: AC_CACHE_VAL is expanded
from...
../../lib/autoconf/general.m4:2052: AC_CACHE_CHECK is expanded
from...
configure.ac:143: the top level
configure.ac:300: warning: AC_LANG_CONFTEST: no AC_LANG_SOURCE
call detected in body
../../lib/autoconf/lang.m4:193: AC_LANG_CONFTEST is expanded
from...
configure.ac:300: the top level
libtoolize: putting auxiliary files in `.'.
libtoolize: copying file `./ltmain.sh'
libtoolize: putting macros in AC_CONFIG_MACRO_DIR, `common'.
libtoolize: copying file `common/libtool.m4'
libtoolize: copying file `common/ltoptions.m4'
libtoolize: copying file `common/ltsugar.m4'
libtoolize: copying file `common/ltversion.m4'
libtoolize: copying file `common/lt~obsolete.m4'
configure.ac:419: warning: macro 'AM_GLIB_GNU_GETTEXT' not found
in library
configure.ac:143: warning: AC_LANG_CONFTEST: no AC_LANG_SOURCE
call detected in body
../../lib/autoconf/lang.m4:193: AC_LANG_CONFTEST is expanded
from...
../../lib/autoconf/general.m4:2590: _AC_COMPILE_IFELSE is
expanded from...
../../lib/autoconf/general.m4:2606: AC_COMPILE_IFELSE is
expanded from...
../../lib/m4sugar/m4sh.m4:639: AS_IF is expanded from...
../../lib/autoconf/general.m4:2031: AC_CACHE_VAL is expanded
from...
../../lib/autoconf/general.m4:2052: AC_CACHE_CHECK is expanded
from...
configure.ac:143: the top level
configure.ac:300: warning: AC_LANG_CONFTEST: no AC_LANG_SOURCE
call detected in body
../../lib/autoconf/lang.m4:193: AC_LANG_CONFTEST is expanded
from...
configure.ac:300: the top level
configure.ac:143: warning: AC_LANG_CONFTEST: no AC_LANG_SOURCE
call detected in body
../../lib/autoconf/lang.m4:193: AC_LANG_CONFTEST is expanded
from...
../../lib/autoconf/general.m4:2590: _AC_COMPILE_IFELSE is
expanded from...
../../lib/autoconf/general.m4:2606: AC_COMPILE_IFELSE is
expanded from...
../../lib/m4sugar/m4sh.m4:639: AS_IF is expanded from...
../../lib/autoconf/general.m4:2031: AC_CACHE_VAL is expanded
from...
../../lib/autoconf/general.m4:2052: AC_CACHE_CHECK is expanded
from...
configure.ac:143: the top level
configure.ac:300: warning: AC_LANG_CONFTEST: no AC_LANG_SOURCE
call detected in body
../../lib/autoconf/lang.m4:193: AC_LANG_CONFTEST is expanded
from...
configure.ac:300: the top level
configure.ac:143: warning: AC_LANG_CONFTEST: no AC_LANG_SOURCE
call detected in body
../../lib/autoconf/lang.m4:193: AC_LANG_CONFTEST is expanded
from...
../../lib/autoconf/general.m4:2590: _AC_COMPILE_IFELSE is
expanded from...
../../lib/autoconf/general.m4:2606: AC_COMPILE_IFELSE is
expanded from...
../../lib/m4sugar/m4sh.m4:639: AS_IF is expanded from...
../../lib/autoconf/general.m4:2031: AC_CACHE_VAL is expanded
from...
../../lib/autoconf/general.m4:2052: AC_CACHE_CHECK is expanded
from...
configure.ac:143: the top level
configure.ac:300: warning: AC_LANG_CONFTEST: no AC_LANG_SOURCE
call detected in body
../../lib/autoconf/lang.m4:193: AC_LANG_CONFTEST is expanded
from...
configure.ac:300: the top level
configure.ac:419: error: possibly undefined macro:
AM_GLIB_GNU_GETTEXT
If this token and others are legitimate, please use
m4_pattern_allow.
See the Autoconf documentation.
autoreconf: /home/joerg/git/buildroot/output/host/usr/bin/autoconf failed with exit status: 1
package/pkg-generic.mk:172: recipe for target
'/home/joerg/git/buildroot/output/build/avahi-0.6.31/.stamp_configured' failed
make: ***
[/home/joerg/git/buildroot/output/build/avahi-0.6.31/.stamp_configured] Error 1
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Buildroot] [git commit] avahi: fix avahi-ui build with libgtk3
2014-10-31 23:46 ` Jörg Krause
@ 2014-11-01 9:29 ` Peter Korsgaard
2014-11-01 19:13 ` Yann E. MORIN
1 sibling, 0 replies; 14+ messages in thread
From: Peter Korsgaard @ 2014-11-01 9:29 UTC (permalink / raw)
To: buildroot
>>>>> "J?rg" == J?rg Krause <jkrause@posteo.de> writes:
Hi,
>> @@ -16,6 +16,7 @@ AVAHI_SITE = http://www.avahi.org/download
>> AVAHI_LICENSE = LGPLv2.1+
>> AVAHI_LICENSE_FILES = LICENSE
>> AVAHI_INSTALL_STAGING = YES
>> +AVAHI_AUTORECONF = YES
>>
> This patch breaks building avahi for me. Is autoreconf really intended?
> Removing it fixed my build.
Yes, the patch modifies Makefile.am, so autoreconf must be done. Odd, it built
here without problems.
I'll take a closer look.
--
Venlig hilsen,
Peter Korsgaard
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Buildroot] [git commit] avahi: fix avahi-ui build with libgtk3
2014-10-31 23:46 ` Jörg Krause
2014-11-01 9:29 ` Peter Korsgaard
@ 2014-11-01 19:13 ` Yann E. MORIN
2014-11-02 20:11 ` Jörg Krause
2014-11-03 9:55 ` Jörg Krause
1 sibling, 2 replies; 14+ messages in thread
From: Yann E. MORIN @ 2014-11-01 19:13 UTC (permalink / raw)
To: buildroot
J?rg, All,
On 2014-11-01 00:46 +0100, J?rg Krause spake thusly:
> On Fr, 2014-10-31 at 12:50 +0100, Peter Korsgaard wrote:
> > commit: http://git.buildroot.net/buildroot/commit/?id=e6c04e6daae674f8983ec2fb106fb897c6803c32
> > branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master
> >
> > Fixes:
> > http://autobuild.buildroot.net/results/daa/daad247db16818f25ab33402e26e27257defbe13/
> > http://autobuild.buildroot.net/results/720/720e2c8a5eab8b47d2510fe03b4a90ec8beafc17/
> > http://autobuild.buildroot.net/results/02b/02b4ab9ee07707ee4a4d4ea2b9c67bee91b1392d/
> > http://autobuild.buildroot.net/results/819/81914317ce82dc1321484d8c2b65647f92aa6929/
> >
> > And many others.
[--SNIP--]
> This patch breaks building avahi for me. Is autoreconf really intended?
> Removing it fixed my build.
>
> >>> avahi 0.6.31 Autoreconfiguring
[--SNIP--]
> configure.ac:419: error: possibly undefined macro:
> AM_GLIB_GNU_GETTEXT
> If this token and others are legitimate, please use
> m4_pattern_allow.
It seems it requires gettext.
J?rg, care to test adding this to avahi.mk (just below AUTORECONF):
AVAHI_GETTEXTIZE = YES
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Buildroot] [git commit] avahi: fix avahi-ui build with libgtk3
2014-11-01 19:13 ` Yann E. MORIN
@ 2014-11-02 20:11 ` Jörg Krause
2014-11-02 20:16 ` Peter Korsgaard
2014-11-03 9:55 ` Jörg Krause
1 sibling, 1 reply; 14+ messages in thread
From: Jörg Krause @ 2014-11-02 20:11 UTC (permalink / raw)
To: buildroot
Yann, Peter, All,
On Sa, 2014-11-01 at 20:13 +0100, Yann E. MORIN wrote:
> J?rg, All,
>
> On 2014-11-01 00:46 +0100, J?rg Krause spake thusly:
> > On Fr, 2014-10-31 at 12:50 +0100, Peter Korsgaard wrote:
> > > commit: http://git.buildroot.net/buildroot/commit/?id=e6c04e6daae674f8983ec2fb106fb897c6803c32
> > > branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master
> > >
> > > Fixes:
> > > http://autobuild.buildroot.net/results/daa/daad247db16818f25ab33402e26e27257defbe13/
> > > http://autobuild.buildroot.net/results/720/720e2c8a5eab8b47d2510fe03b4a90ec8beafc17/
> > > http://autobuild.buildroot.net/results/02b/02b4ab9ee07707ee4a4d4ea2b9c67bee91b1392d/
> > > http://autobuild.buildroot.net/results/819/81914317ce82dc1321484d8c2b65647f92aa6929/
> > >
> > > And many others.
> [--SNIP--]
> > This patch breaks building avahi for me. Is autoreconf really intended?
> > Removing it fixed my build.
> >
> > >>> avahi 0.6.31 Autoreconfiguring
> [--SNIP--]
> > configure.ac:419: error: possibly undefined macro:
> > AM_GLIB_GNU_GETTEXT
> > If this token and others are legitimate, please use
> > m4_pattern_allow.
>
> It seems it requires gettext.
>
> J?rg, care to test adding this to avahi.mk (just below AUTORECONF):
>
> AVAHI_GETTEXTIZE = YES
this doesn't help. The problem is the AM_GLIB_GNU_GETTEXT macro at
configure.ac:419. If I enable glibc avahi builds without errors. I've
also found some old posts about this issue, e.g:
http://blogs.gnome.org/jjardon/2010/10/08/use-upstream-gettext-instead-the-glib-one/
I followed this suggestions and replaced AM_GLIB_GNU_GETTEXT with:
AM_GNU_GETTEXT_VERSION([0.19.3])
AM_GNU_GETTEXT([external])
and it works for me.
I am not sure about the version number I should use for gettext. The
most recent one?
I am not an expert about autotools. So what do you think about this? May
I submit a patch for this issue?
Many thanks
J?rg
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Buildroot] [git commit] avahi: fix avahi-ui build with libgtk3
2014-11-02 20:11 ` Jörg Krause
@ 2014-11-02 20:16 ` Peter Korsgaard
2014-11-02 21:03 ` Jörg Krause
0 siblings, 1 reply; 14+ messages in thread
From: Peter Korsgaard @ 2014-11-02 20:16 UTC (permalink / raw)
To: buildroot
>>>>> "J?rg" == J?rg Krause <jkrause@posteo.de> writes:
Hi,
> Yann, Peter, All,
>> It seems it requires gettext.
>>
>> J?rg, care to test adding this to avahi.mk (just below AUTORECONF):
>>
>> AVAHI_GETTEXTIZE = YES
> this doesn't help. The problem is the AM_GLIB_GNU_GETTEXT macro at
> configure.ac:419. If I enable glibc avahi builds without errors.
glib, not glibc.
> I've also found some old posts about this issue, e.g:
> http://blogs.gnome.org/jjardon/2010/10/08/use-upstream-gettext-instead-the-glib-one/
> I followed this suggestions and replaced AM_GLIB_GNU_GETTEXT with:
> AM_GNU_GETTEXT_VERSION([0.19.3])
> AM_GNU_GETTEXT([external])
> and it works for me.
> I am not sure about the version number I should use for gettext. The
> most recent one?
Sorry, don't know.
> I am not an expert about autotools. So what do you think about this? May
> I submit a patch for this issue?
Either that, or we simply forget about patching Makefile.am / running
autoreconf and just strip the CFLAGS arguments in Makefile.in instead.
--
Venlig hilsen,
Peter Korsgaard
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Buildroot] [git commit] avahi: fix avahi-ui build with libgtk3
2014-11-02 20:16 ` Peter Korsgaard
@ 2014-11-02 21:03 ` Jörg Krause
0 siblings, 0 replies; 14+ messages in thread
From: Jörg Krause @ 2014-11-02 21:03 UTC (permalink / raw)
To: buildroot
On So, 2014-11-02 at 21:16 +0100, Peter Korsgaard wrote:
> >>>>> "J?rg" == J?rg Krause <jkrause@posteo.de> writes:
>
> Hi,
>
> > Yann, Peter, All,
>
> >> It seems it requires gettext.
> >>
> >> J?rg, care to test adding this to avahi.mk (just below AUTORECONF):
> >>
> >> AVAHI_GETTEXTIZE = YES
>
> > this doesn't help. The problem is the AM_GLIB_GNU_GETTEXT macro at
> > configure.ac:419. If I enable glibc avahi builds without errors.
>
> glib, not glibc.
You're right, it's glib, of course.
>
> > I've also found some old posts about this issue, e.g:
> > http://blogs.gnome.org/jjardon/2010/10/08/use-upstream-gettext-instead-the-glib-one/
>
> > I followed this suggestions and replaced AM_GLIB_GNU_GETTEXT with:
> > AM_GNU_GETTEXT_VERSION([0.19.3])
> > AM_GNU_GETTEXT([external])
> > and it works for me.
>
> > I am not sure about the version number I should use for gettext. The
> > most recent one?
>
> Sorry, don't know.
There is also another solution which works: Updating intltool and
removing AM_GLIB_GNU_GETTEXT:
diff --git a/configure.ac b/configure.ac
index 9debce2..9222c6f 100644
--- a/configure.ac
+++ b/configure.ac
@@ -413,11 +413,10 @@ if test "x$have_kqueue" = "xyes" ; then
AC_DEFINE([HAVE_KQUEUE], 1, [Enable BSD kqueue() usage])
fi
-IT_PROG_INTLTOOL([0.35.0])
+IT_PROG_INTLTOOL([0.50.2])
GETTEXT_PACKAGE=avahi
AC_SUBST([GETTEXT_PACKAGE])
AC_DEFINE_UNQUOTED([GETTEXT_PACKAGE],["$GETTEXT_PACKAGE"],[Gettext package])
-AM_GLIB_GNU_GETTEXT
avahilocaledir='${prefix}/${DATADIRNAME}/locale'
AC_SUBST(avahilocaledir)
--
I got this from:
https://mail.gnome.org/archives/commits-list/2014-April/msg04208.html
https://mail.gnome.org/archives/commits-list/2014-April/msg04208.html
>
> > I am not an expert about autotools. So what do you think about this? May
> > I submit a patch for this issue?
>
> Either that, or we simply forget about patching Makefile.am / running
> autoreconf and just strip the CFLAGS arguments in Makefile.in instead.
>
Since I've already created a patch I can submit it. I was just wondering
about the patch name policy in avahi and unsure how to name?
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Buildroot] [git commit] avahi: fix avahi-ui build with libgtk3
2014-11-01 19:13 ` Yann E. MORIN
2014-11-02 20:11 ` Jörg Krause
@ 2014-11-03 9:55 ` Jörg Krause
2014-11-03 20:54 ` Arnout Vandecappelle
1 sibling, 1 reply; 14+ messages in thread
From: Jörg Krause @ 2014-11-03 9:55 UTC (permalink / raw)
To: buildroot
Yann, Peter,
On Sa, 2014-11-01 at 20:13 +0100, Yann E. MORIN wrote:
> J?rg, All,
>
> On 2014-11-01 00:46 +0100, J?rg Krause spake thusly:
> > On Fr, 2014-10-31 at 12:50 +0100, Peter Korsgaard wrote:
> > > commit: http://git.buildroot.net/buildroot/commit/?id=e6c04e6daae674f8983ec2fb106fb897c6803c32
> > > branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master
> > >
> > > Fixes:
> > > http://autobuild.buildroot.net/results/daa/daad247db16818f25ab33402e26e27257defbe13/
> > > http://autobuild.buildroot.net/results/720/720e2c8a5eab8b47d2510fe03b4a90ec8beafc17/
> > > http://autobuild.buildroot.net/results/02b/02b4ab9ee07707ee4a4d4ea2b9c67bee91b1392d/
> > > http://autobuild.buildroot.net/results/819/81914317ce82dc1321484d8c2b65647f92aa6929/
> > >
> > > And many others.
> [--SNIP--]
> > This patch breaks building avahi for me. Is autoreconf really intended?
> > Removing it fixed my build.
> >
> > >>> avahi 0.6.31 Autoreconfiguring
> [--SNIP--]
> > configure.ac:419: error: possibly undefined macro:
> > AM_GLIB_GNU_GETTEXT
> > If this token and others are legitimate, please use
> > m4_pattern_allow.
>
> It seems it requires gettext.
>
> J?rg, care to test adding this to avahi.mk (just below AUTORECONF):
>
> AVAHI_GETTEXTIZE = YES
I'd like to discuss some possibilities to solve this issue:
1) forget about patching Makefile.am / running
autoreconf and just strip the CFLAGS arguments in Makefile.in as Peter
suggested
2) replace AM_GLIB_GNU_GETTEXT by AM_GNU_GETTEXT([external]) and update
gettext to a recent version (and maybe intltool too)
3) remove AM_GLIB_GNU_GETTEXT entirely and use only intltool
(additionally update to recent version)
4) add dependency on glib (or glib-gettext, if possible)
My thoughts:
2) I'm not sure why glib version instead of gettext is used here. Maybe
for historical reasons. In autogen this piece of code is used:
# Evil, evil, evil, evil hack
sed 's/read dummy/\#/' `which gettextize` | sh -s -- --copy
--force
which uses GNU gettextize instead of glib-gettextize.
3) I've found some threads about conflicts of using intltool and gettext
together, eg:
https://mail.gnome.org/archives/gtk-devel-list/2012-September/msg00022.html
[Quote] "intltool is a sort-of wrapper around xgetext which interferes
with gettext's own way of setting up po/."
I've tested 2, 3, and 4 and all are building successfully. I've
additionally checked if the .mo files are created in
target/usr/share/locale/.
Best regards
J?rg
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Buildroot] [git commit] avahi: fix avahi-ui build with libgtk3
2014-11-03 9:55 ` Jörg Krause
@ 2014-11-03 20:54 ` Arnout Vandecappelle
2014-11-03 21:04 ` Peter Korsgaard
0 siblings, 1 reply; 14+ messages in thread
From: Arnout Vandecappelle @ 2014-11-03 20:54 UTC (permalink / raw)
To: buildroot
On 03/11/14 10:55, J?rg Krause wrote:
> Yann, Peter,
>
> On Sa, 2014-11-01 at 20:13 +0100, Yann E. MORIN wrote:
>> J?rg, All,
>>
>> On 2014-11-01 00:46 +0100, J?rg Krause spake thusly:
>>> On Fr, 2014-10-31 at 12:50 +0100, Peter Korsgaard wrote:
>>>> commit: http://git.buildroot.net/buildroot/commit/?id=e6c04e6daae674f8983ec2fb106fb897c6803c32
>>>> branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master
>>>>
>>>> Fixes:
>>>> http://autobuild.buildroot.net/results/daa/daad247db16818f25ab33402e26e27257defbe13/
>>>> http://autobuild.buildroot.net/results/720/720e2c8a5eab8b47d2510fe03b4a90ec8beafc17/
>>>> http://autobuild.buildroot.net/results/02b/02b4ab9ee07707ee4a4d4ea2b9c67bee91b1392d/
>>>> http://autobuild.buildroot.net/results/819/81914317ce82dc1321484d8c2b65647f92aa6929/
>>>>
>>>> And many others.
>> [--SNIP--]
>>> This patch breaks building avahi for me. Is autoreconf really intended?
>>> Removing it fixed my build.
>>>
>>> >>> avahi 0.6.31 Autoreconfiguring
>> [--SNIP--]
>>> configure.ac:419: error: possibly undefined macro:
>>> AM_GLIB_GNU_GETTEXT
>>> If this token and others are legitimate, please use
>>> m4_pattern_allow.
>>
>> It seems it requires gettext.
>>
>> J?rg, care to test adding this to avahi.mk (just below AUTORECONF):
>>
>> AVAHI_GETTEXTIZE = YES
>
> I'd like to discuss some possibilities to solve this issue:
>
> 1) forget about patching Makefile.am / running
> autoreconf and just strip the CFLAGS arguments in Makefile.in as Peter
> suggested
I think this one is the most practical. Patching the .am is generally better
because then it's upstreamable, but that's not relevant here.
> 2) replace AM_GLIB_GNU_GETTEXT by AM_GNU_GETTEXT([external]) and update
> gettext to a recent version (and maybe intltool too)
Updating gettext/intltool is nice, but may have far-reaching effects...
As to replacing AM_GLIB_GNU_GETTEXT, as far as I understand that was already
proposed upstream and rejected, so I don't think that's a good idea.
> 3) remove AM_GLIB_GNU_GETTEXT entirely and use only intltool
> (additionally update to recent version)
Same consideration about upstream rejection.
> 4) add dependency on glib (or glib-gettext, if possible)
That is certainly not nice - libglib2 takes a long time to build so if we can
avoid that...
Regards,
Arnout
>
> My thoughts:
> 2) I'm not sure why glib version instead of gettext is used here. Maybe
> for historical reasons. In autogen this piece of code is used:
> # Evil, evil, evil, evil hack
> sed 's/read dummy/\#/' `which gettextize` | sh -s -- --copy
> --force
> which uses GNU gettextize instead of glib-gettextize.
> 3) I've found some threads about conflicts of using intltool and gettext
> together, eg:
> https://mail.gnome.org/archives/gtk-devel-list/2012-September/msg00022.html
> [Quote] "intltool is a sort-of wrapper around xgetext which interferes
> with gettext's own way of setting up po/."
>
> I've tested 2, 3, and 4 and all are building successfully. I've
> additionally checked if the .mo files are created in
> target/usr/share/locale/.
>
> Best regards
> J?rg
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Buildroot] [git commit] avahi: fix avahi-ui build with libgtk3
2014-11-03 20:54 ` Arnout Vandecappelle
@ 2014-11-03 21:04 ` Peter Korsgaard
0 siblings, 0 replies; 14+ messages in thread
From: Peter Korsgaard @ 2014-11-03 21:04 UTC (permalink / raw)
To: buildroot
>>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes:
Hi,
> On 03/11/14 10:55, J?rg Krause wrote:
>> I'd like to discuss some possibilities to solve this issue:
>>
>> 1) forget about patching Makefile.am / running
>> autoreconf and just strip the CFLAGS arguments in Makefile.in as Peter
>> suggested
> I think this one is the most practical. Patching the .am is generally better
> because then it's upstreamable, but that's not relevant here.
Yeah, definately for 2014.11. I'll go and rework the patch now.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2014-11-03 21:04 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-31 11:50 [Buildroot] [git commit] avahi: fix avahi-ui build with libgtk3 Peter Korsgaard
2014-10-31 12:40 ` Thomas Petazzoni
2014-10-31 13:19 ` Peter Korsgaard
2014-10-31 13:30 ` Thomas Petazzoni
2014-10-31 16:18 ` Peter Korsgaard
2014-10-31 23:46 ` Jörg Krause
2014-11-01 9:29 ` Peter Korsgaard
2014-11-01 19:13 ` Yann E. MORIN
2014-11-02 20:11 ` Jörg Krause
2014-11-02 20:16 ` Peter Korsgaard
2014-11-02 21:03 ` Jörg Krause
2014-11-03 9:55 ` Jörg Krause
2014-11-03 20:54 ` Arnout Vandecappelle
2014-11-03 21:04 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox