* [Buildroot] [PATCH] package: libpng: don't append prefix to symbol names in the version script file
@ 2013-12-30 10:35 sonic.adi at gmail.com
2014-01-06 2:14 ` Sonic Zhang
2014-01-14 22:01 ` Peter Korsgaard
0 siblings, 2 replies; 3+ messages in thread
From: sonic.adi at gmail.com @ 2013-12-30 10:35 UTC (permalink / raw)
To: buildroot
From: Sonic Zhang <sonic.zhang@analog.com>
Even if Blackfin GNU toolchain add prefix '_' to all symbols,
symbol prefix is not accepted in the link flag --version-script.
Don't append prefix in the symbols in the version script file.
Signed-off-by: Sonic Zhang <sonic.zhang@analog.com>
---
.../libpng/libpng-02-ingore-symbol-prefix.patch | 26 ++++++++++++++++++++
1 file changed, 26 insertions(+)
create mode 100644 package/libpng/libpng-02-ingore-symbol-prefix.patch
diff --git a/package/libpng/libpng-02-ingore-symbol-prefix.patch b/package/libpng/libpng-02-ingore-symbol-prefix.patch
new file mode 100644
index 0000000..7f2cfff
--- /dev/null
+++ b/package/libpng/libpng-02-ingore-symbol-prefix.patch
@@ -0,0 +1,26 @@
+Even if Blackfin GNU toolchain add prefix '_' to all symbols,
+symbol prefix is not accepted in the link flag --version-script.
+Don't append prefix in the symbols in the version script file.
+
+--- libpng-1.6.8/Makefile.am 2013-12-30 18:23:08.261797417 +0800
++++ libpng-1.6.8.bak/Makefile.am 2013-12-30 18:22:15.565795726 +0800
+@@ -225,7 +225,7 @@
+ # interfering with the symbol file format.
+ SYMBOL_CFLAGS = -DPNGLIB_LIBNAME='PNG at PNGLIB_MAJOR@@PNGLIB_MINOR at _0'\
+ -DPNGLIB_VERSION='@PNGLIB_VERSION@'\
+- -DSYMBOL_PREFIX='$(SYMBOL_PREFIX)'\
++ -DSYMBOL_PREFIX=''\
+ -DPNG_NO_USE_READ_MACROS -DPNG_BUILDING_SYMBOL_TABLE
+
+ if DO_PNG_PREFIX
+--- libpng-1.6.8/Makefile.in 2013-12-30 18:23:08.261797417 +0800
++++ libpng-1.6.8.bak/Makefile.in 2013-12-30 18:22:09.853794547 +0800
+@@ -698,7 +698,7 @@
+ # interfering with the symbol file format.
+ SYMBOL_CFLAGS = -DPNGLIB_LIBNAME='PNG at PNGLIB_MAJOR@@PNGLIB_MINOR at _0' \
+ -DPNGLIB_VERSION='@PNGLIB_VERSION@' \
+- -DSYMBOL_PREFIX='$(SYMBOL_PREFIX)' -DPNG_NO_USE_READ_MACROS \
++ -DSYMBOL_PREFIX='' -DPNG_NO_USE_READ_MACROS \
+ -DPNG_BUILDING_SYMBOL_TABLE $(am__append_5)
+ all: $(BUILT_SOURCES) config.h
+ $(MAKE) $(AM_MAKEFLAGS) all-am
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] package: libpng: don't append prefix to symbol names in the version script file
2013-12-30 10:35 [Buildroot] [PATCH] package: libpng: don't append prefix to symbol names in the version script file sonic.adi at gmail.com
@ 2014-01-06 2:14 ` Sonic Zhang
2014-01-14 22:01 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Sonic Zhang @ 2014-01-06 2:14 UTC (permalink / raw)
To: buildroot
Ping
Sonic Zhang
On Mon, Dec 30, 2013 at 6:35 PM, <sonic.adi@gmail.com> wrote:
> From: Sonic Zhang <sonic.zhang@analog.com>
>
> Even if Blackfin GNU toolchain add prefix '_' to all symbols,
> symbol prefix is not accepted in the link flag --version-script.
> Don't append prefix in the symbols in the version script file.
>
> Signed-off-by: Sonic Zhang <sonic.zhang@analog.com>
> ---
> .../libpng/libpng-02-ingore-symbol-prefix.patch | 26 ++++++++++++++++++++
> 1 file changed, 26 insertions(+)
> create mode 100644 package/libpng/libpng-02-ingore-symbol-prefix.patch
>
> diff --git a/package/libpng/libpng-02-ingore-symbol-prefix.patch b/package/libpng/libpng-02-ingore-symbol-prefix.patch
> new file mode 100644
> index 0000000..7f2cfff
> --- /dev/null
> +++ b/package/libpng/libpng-02-ingore-symbol-prefix.patch
> @@ -0,0 +1,26 @@
> +Even if Blackfin GNU toolchain add prefix '_' to all symbols,
> +symbol prefix is not accepted in the link flag --version-script.
> +Don't append prefix in the symbols in the version script file.
> +
> +--- libpng-1.6.8/Makefile.am 2013-12-30 18:23:08.261797417 +0800
> ++++ libpng-1.6.8.bak/Makefile.am 2013-12-30 18:22:15.565795726 +0800
> +@@ -225,7 +225,7 @@
> + # interfering with the symbol file format.
> + SYMBOL_CFLAGS = -DPNGLIB_LIBNAME='PNG at PNGLIB_MAJOR@@PNGLIB_MINOR at _0'\
> + -DPNGLIB_VERSION='@PNGLIB_VERSION@'\
> +- -DSYMBOL_PREFIX='$(SYMBOL_PREFIX)'\
> ++ -DSYMBOL_PREFIX=''\
> + -DPNG_NO_USE_READ_MACROS -DPNG_BUILDING_SYMBOL_TABLE
> +
> + if DO_PNG_PREFIX
> +--- libpng-1.6.8/Makefile.in 2013-12-30 18:23:08.261797417 +0800
> ++++ libpng-1.6.8.bak/Makefile.in 2013-12-30 18:22:09.853794547 +0800
> +@@ -698,7 +698,7 @@
> + # interfering with the symbol file format.
> + SYMBOL_CFLAGS = -DPNGLIB_LIBNAME='PNG at PNGLIB_MAJOR@@PNGLIB_MINOR at _0' \
> + -DPNGLIB_VERSION='@PNGLIB_VERSION@' \
> +- -DSYMBOL_PREFIX='$(SYMBOL_PREFIX)' -DPNG_NO_USE_READ_MACROS \
> ++ -DSYMBOL_PREFIX='' -DPNG_NO_USE_READ_MACROS \
> + -DPNG_BUILDING_SYMBOL_TABLE $(am__append_5)
> + all: $(BUILT_SOURCES) config.h
> + $(MAKE) $(AM_MAKEFLAGS) all-am
> --
> 1.7.9.5
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] package: libpng: don't append prefix to symbol names in the version script file
2013-12-30 10:35 [Buildroot] [PATCH] package: libpng: don't append prefix to symbol names in the version script file sonic.adi at gmail.com
2014-01-06 2:14 ` Sonic Zhang
@ 2014-01-14 22:01 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2014-01-14 22:01 UTC (permalink / raw)
To: buildroot
>>>>> "sonic" == sonic adi <sonic.adi@gmail.com> writes:
> From: Sonic Zhang <sonic.zhang@analog.com>
> Even if Blackfin GNU toolchain add prefix '_' to all symbols,
> symbol prefix is not accepted in the link flag --version-script.
> Don't append prefix in the symbols in the version script file.
> Signed-off-by: Sonic Zhang <sonic.zhang@analog.com>
> ---
> .../libpng/libpng-02-ingore-symbol-prefix.patch | 26 ++++++++++++++++++++
> 1 file changed, 26 insertions(+)
> create mode 100644 package/libpng/libpng-02-ingore-symbol-prefix.patch
> diff --git a/package/libpng/libpng-02-ingore-symbol-prefix.patch b/package/libpng/libpng-02-ingore-symbol-prefix.patch
> new file mode 100644
> index 0000000..7f2cfff
> --- /dev/null
> +++ b/package/libpng/libpng-02-ingore-symbol-prefix.patch
Committed with the filename typo fixed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-01-14 22:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-30 10:35 [Buildroot] [PATCH] package: libpng: don't append prefix to symbol names in the version script file sonic.adi at gmail.com
2014-01-06 2:14 ` Sonic Zhang
2014-01-14 22:01 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox