* [Buildroot] [PATCH] redis: fix build with ccache enabled
@ 2013-08-28 13:40 Thomas De Schampheleire
2013-08-28 14:20 ` Peter Korsgaard
0 siblings, 1 reply; 2+ messages in thread
From: Thomas De Schampheleire @ 2013-08-28 13:40 UTC (permalink / raw)
To: buildroot
Some parts of redis fail to build when ccache is enabled, due to one of our
own patches. The construct
make CC=$(CC) target1 target2
would result in
make CC=ccache <tuple>-gcc target1 target2
and here <tuple>-gcc would be treated as a target and the compiler used
would be just 'ccache'.
Reported-by: Johan Sagaert <sagaert.johan@skynet.be>
Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
---
I think this should still be applied for 2013.08.
package/redis/redis-001-uclibc.patch | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/package/redis/redis-001-uclibc.patch b/package/redis/redis-001-uclibc.patch
--- a/package/redis/redis-001-uclibc.patch
+++ b/package/redis/redis-001-uclibc.patch
@@ -39,7 +39,7 @@ diff -ur old/src/Makefile new/src/Makefi
echo PREV_FINAL_CFLAGS=$(FINAL_CFLAGS) >> .make-settings
echo PREV_FINAL_LDFLAGS=$(FINAL_LDFLAGS) >> .make-settings
- -(cd ../deps && $(MAKE) $(DEPENDENCY_TARGETS))
-+ -(cd ../deps && $(MAKE) CC=$(CC) $(DEPENDENCY_TARGETS))
++ -(cd ../deps && $(MAKE) CC="$(CC)" $(DEPENDENCY_TARGETS))
.PHONY: persist-settings
^ permalink raw reply [flat|nested] 2+ messages in thread
* [Buildroot] [PATCH] redis: fix build with ccache enabled
2013-08-28 13:40 [Buildroot] [PATCH] redis: fix build with ccache enabled Thomas De Schampheleire
@ 2013-08-28 14:20 ` Peter Korsgaard
0 siblings, 0 replies; 2+ messages in thread
From: Peter Korsgaard @ 2013-08-28 14:20 UTC (permalink / raw)
To: buildroot
>>>>> "Thomas" == Thomas De Schampheleire <patrickdepinguin+buildroot@gmail.com> writes:
Thomas> Some parts of redis fail to build when ccache is enabled, due to one of our
Thomas> own patches. The construct
Thomas> make CC=$(CC) target1 target2
Thomas> would result in
Thomas> make CC=ccache <tuple>-gcc target1 target2
Thomas> and here <tuple>-gcc would be treated as a target and the compiler used
Thomas> would be just 'ccache'.
Thomas> Reported-by: Johan Sagaert <sagaert.johan@skynet.be>
Thomas> Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
Thomas> ---
Thomas> I think this should still be applied for 2013.08.
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-08-28 14:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-28 13:40 [Buildroot] [PATCH] redis: fix build with ccache enabled Thomas De Schampheleire
2013-08-28 14:20 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox