[Buildroot] [git commit] e2fsprogs: Add missing dependency of tst_uuid.o on uuid.h

[Buildroot] [git commit] e2fsprogs: Add missing dependency of tst_uuid.o on uuid.h

[Peter Korsgaard]

commit: http://git.buildroot.net/buildroot/commit/?id=0af4136c544aecf7950a76996fd76cc8c208d604
branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master

The missing dependency used to break parallel builds.

Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
---
 ...rogs-1.41.9-add-missing-dep-of-tst_uuid-o.patch |   18 ++++++++++++++++++
 1 files changed, 18 insertions(+), 0 deletions(-)
 create mode 100644 package/e2fsprogs/e2fsprogs-1.41.9-add-missing-dep-of-tst_uuid-o.patch

diff --git a/package/e2fsprogs/e2fsprogs-1.41.9-add-missing-dep-of-tst_uuid-o.patch b/package/e2fsprogs/e2fsprogs-1.41.9-add-missing-dep-of-tst_uuid-o.patch
new file mode 100644
index 0000000..3a60e89
--- /dev/null
+++ b/package/e2fsprogs/e2fsprogs-1.41.9-add-missing-dep-of-tst_uuid-o.patch
@@ -0,0 +1,18 @@
+Add missing dependency of tst_uuid.o on uuid.h
+
+The missing dependency used to break parallel builds.
+
+Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
+---
+diff -Nrup e2fsprogs.orig//lib/uuid/Makefile.in e2fsprogs-1.41.14//lib/uuid/Makefile.in
+--- e2fsprogs.orig//lib/uuid/Makefile.in	2010-06-14 05:07:36.000000000 +0200
++++ e2fsprogs-1.41.14//lib/uuid/Makefile.in	2011-07-18 13:44:58.000000000 +0200
+@@ -76,7 +76,7 @@ uuid.h: $(srcdir)/uuid.h.in
+ $(top_builddir)/lib/uuid/uuid_types.h: $(srcdir)/uuid_types.h.in $(top_builddir)/config.status
+ 	cd $(top_builddir); CONFIG_FILES=$(my_dir)/uuid_types.h ./config.status
+ 
+-tst_uuid.o: $(srcdir)/tst_uuid.c
++tst_uuid.o: $(srcdir)/tst_uuid.c uuid.h
+ 	$(E) "	CC $@"
+ 	$(Q) $(CC) $(ALL_CFLAGS) -c $(srcdir)/tst_uuid.c -o tst_uuid.o
+ 
-- 
1.7.3.4

[Buildroot] [git commit] e2fsprogs: Add missing dependency of tst_uuid.o on uuid.h

[Alexjan Carraturo]

2011/7/25 Peter Korsgaard <jacmet@sunsite.dk>:
>
> commit: http://git.buildroot.net/buildroot/commit/?id=0af4136c544aecf7950a76996fd76cc8c208d604
> branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master
>
> The missing dependency used to break parallel builds.
>
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
> ---
> ?...rogs-1.41.9-add-missing-dep-of-tst_uuid-o.patch | ? 18 ++++++++++++++++++
> ?1 files changed, 18 insertions(+), 0 deletions(-)
> ?create mode 100644 package/e2fsprogs/e2fsprogs-1.41.9-add-missing-dep-of-tst_uuid-o.patch
>
> diff --git a/package/e2fsprogs/e2fsprogs-1.41.9-add-missing-dep-of-tst_uuid-o.patch b/package/e2fsprogs/e2fsprogs-1.41.9-add-missing-dep-of-tst_uuid-o.patch
> new file mode 100644
> index 0000000..3a60e89
> --- /dev/null
> +++ b/package/e2fsprogs/e2fsprogs-1.41.9-add-missing-dep-of-tst_uuid-o.patch
> @@ -0,0 +1,18 @@
> +Add missing dependency of tst_uuid.o on uuid.h
> +
> +The missing dependency used to break parallel builds.
> +
> +Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> +---
> +diff -Nrup e2fsprogs.orig//lib/uuid/Makefile.in e2fsprogs-1.41.14//lib/uuid/Makefile.in
> +--- e2fsprogs.orig//lib/uuid/Makefile.in ? ? ? 2010-06-14 05:07:36.000000000 +0200
> ++++ e2fsprogs-1.41.14//lib/uuid/Makefile.in ? ?2011-07-18 13:44:58.000000000 +0200
> +@@ -76,7 +76,7 @@ uuid.h: $(srcdir)/uuid.h.in
> + $(top_builddir)/lib/uuid/uuid_types.h: $(srcdir)/uuid_types.h.in $(top_builddir)/config.status
> + ? ? ? cd $(top_builddir); CONFIG_FILES=$(my_dir)/uuid_types.h ./config.status
> +
> +-tst_uuid.o: $(srcdir)/tst_uuid.c
> ++tst_uuid.o: $(srcdir)/tst_uuid.c uuid.h
> + ? ? ? $(E) " ?CC $@"
> + ? ? ? $(Q) $(CC) $(ALL_CFLAGS) -c $(srcdir)/tst_uuid.c -o tst_uuid.o
> +
> --
> 1.7.3.4




There is the possibility that, the problem about uuid.h that you have
with e2fsprogs is similar to what I'm having on my version of
buildroot (snapshot of 22 July)

/usr/bin/make BUILDDIR=/home/buildroot/buildroot-20110722/buildroot/output/build/host-mtd-1.4.5/$d
-C $d $t
make[2]: Entering directory
`/home/buildroot/buildroot-20110722/buildroot/output/build/host-mtd-1.4.5/mkfs.ubifs'
gcc -I../include -I../ubi-utils/include   -D_FILE_OFFSET_BITS=64 -O2
-g -Wall -Wextra -Wwrite-strings -Wno-sign-compare -ffunction-sections
-fdata-sections -Wl,--gc-sections -c -o
/home/buildroot/buildroot-20110722/buildroot/output/build/host-mtd-1.4.5/mkfs.ubifs/mkfs.ubifs.o
mkfs.ubifs.c -g
-Wp,-MD,/home/buildroot/buildroot-20110722/buildroot/output/build/host-mtd-1.4.5/mkfs.ubifs/.mkfs.ubifs.c.dep
In file included from mkfs.ubifs.c:23:0:
mkfs.ubifs.h:48:23: fatal error: uuid/uuid.h: File o directory non esistente
compilation terminated.
make[2]: *** [/home/buildroot/buildroot-20110722/buildroot/output/build/host-mtd-1.4.5/mkfs.ubifs/mkfs.ubifs.o]
Errore 1
make[2]: Leaving directory
`/home/buildroot/buildroot-20110722/buildroot/output/build/host-mtd-1.4.5/mkfs.ubifs'
make[1]: *** [subdirs_mkfs.ubifs_install] Errore 2
make[1]: Leaving directory
`/home/buildroot/buildroot-20110722/buildroot/output/build/host-mtd-1.4.5'
make: *** [/home/buildroot/buildroot-20110722/buildroot/output/build/host-mtd-1.4.5/.stamp_host_installed]
Errore 2



Seems searching a uuid/uuid.h, but doesn't seems to find it. Does it
is a problem similar to your

Thank you
Alexjan


-- 
Alexjan Carraturo
--
Free Software User Group Italia administrator (http://www.fsugitalia.org)
Fedora/OpenSUSE Ambassador
member of FSFE Italian Team

Twitter/Facebook/Identica: axjslack
Blog: http://axjslack.wordpress.com
--

[Buildroot] [git commit] e2fsprogs: Add missing dependency of tst_uuid.o on uuid.h

[Peter Korsgaard]

>>>>> "Alexjan" == Alexjan Carraturo <axjslack@gmail.com> writes:

Hi,

 Alexjan> There is the possibility that, the problem about uuid.h that you have
 Alexjan> with e2fsprogs is similar to what I'm having on my version of
 Alexjan> buildroot (snapshot of 22 July)

 Alexjan> /usr/bin/make BUILDDIR=/home/buildroot/buildroot-20110722/buildroot/output/build/host-mtd-1.4.5/$d
 Alexjan> -C $d $t
 Alexjan> make[2]: Entering directory
 Alexjan> `/home/buildroot/buildroot-20110722/buildroot/output/build/host-mtd-1.4.5/mkfs.ubifs'
 Alexjan> gcc -I../include -I../ubi-utils/include   -D_FILE_OFFSET_BITS=64 -O2
 Alexjan> -g -Wall -Wextra -Wwrite-strings -Wno-sign-compare -ffunction-sections
 Alexjan> -fdata-sections -Wl,--gc-sections -c -o
 Alexjan> /home/buildroot/buildroot-20110722/buildroot/output/build/host-mtd-1.4.5/mkfs.ubifs/mkfs.ubifs.o
 Alexjan> mkfs.ubifs.c -g
 Alexjan> -Wp,-MD,/home/buildroot/buildroot-20110722/buildroot/output/build/host-mtd-1.4.5/mkfs.ubifs/.mkfs.ubifs.c.dep
 Alexjan> In file included from mkfs.ubifs.c:23:0:
 Alexjan> mkfs.ubifs.h:48:23: fatal error: uuid/uuid.h: File o directory non esistente

Strange, for some reason you are missing the -I$(HOST_DIR)/usr/include
from your cflags. I have:

gcc -I../include -I../ubi-utils/include   -D_FILE_OFFSET_BITS=64 -O2 -I/home/peko/source/buildroot/output/host/include -I/home/peko/source/buildroot/output/host/usr/include -Wall -Wextra -Wwrite-strings -Wno-sign-compare -ffunction-sections -fdata-sections -Wl,--gc-sections -Wall -Wextra -Wwrite-strings -Wno-sign-compare -ffunction-sections -fdata-sections -Wl,--gc-sections -c -o /home/peko/source/buildroot/output/build/host-mtd-1.4.5/mkfs.ubifs/mkfs.ubifs.o mkfs.ubifs.c -g -Wp,-MD,/home/peko/source/buildroot/output/build/host-mtd-1.4.5/mkfs.ubifs/.mkfs.ubifs.c.dep

Do you have a custom HOST_CFLAGS defined in your environment or on the
make cmdline by any chance?

-- 
Bye, Peter Korsgaard

[Buildroot] [git commit] e2fsprogs: Add missing dependency of tst_uuid.o on uuid.h

[Alexjan Carraturo]

2011/7/25 Peter Korsgaard <jacmet@sunsite.dk>:
>>>>>> "Alexjan" == Alexjan Carraturo <axjslack@gmail.com> writes:
>
> Hi,
>
> ?Alexjan> There is the possibility that, the problem about uuid.h that you have
> ?Alexjan> with e2fsprogs is similar to what I'm having on my version of
> ?Alexjan> buildroot (snapshot of 22 July)
>
> ?Alexjan> /usr/bin/make BUILDDIR=/home/buildroot/buildroot-20110722/buildroot/output/build/host-mtd-1.4.5/$d
> ?Alexjan> -C $d $t
> ?Alexjan> make[2]: Entering directory
> ?Alexjan> `/home/buildroot/buildroot-20110722/buildroot/output/build/host-mtd-1.4.5/mkfs.ubifs'
> ?Alexjan> gcc -I../include -I../ubi-utils/include ? -D_FILE_OFFSET_BITS=64 -O2
> ?Alexjan> -g -Wall -Wextra -Wwrite-strings -Wno-sign-compare -ffunction-sections
> ?Alexjan> -fdata-sections -Wl,--gc-sections -c -o
> ?Alexjan> /home/buildroot/buildroot-20110722/buildroot/output/build/host-mtd-1.4.5/mkfs.ubifs/mkfs.ubifs.o
> ?Alexjan> mkfs.ubifs.c -g
> ?Alexjan> -Wp,-MD,/home/buildroot/buildroot-20110722/buildroot/output/build/host-mtd-1.4.5/mkfs.ubifs/.mkfs.ubifs.c.dep
> ?Alexjan> In file included from mkfs.ubifs.c:23:0:
> ?Alexjan> mkfs.ubifs.h:48:23: fatal error: uuid/uuid.h: File o directory non esistente
>
> Strange, for some reason you are missing the -I$(HOST_DIR)/usr/include
> from your cflags. I have:
>
> gcc -I../include -I../ubi-utils/include ? -D_FILE_OFFSET_BITS=64 -O2 -I/home/peko/source/buildroot/output/host/include -I/home/peko/source/buildroot/output/host/usr/include -Wall -Wextra -Wwrite-strings -Wno-sign-compare -ffunction-sections -fdata-sections -Wl,--gc-sections -Wall -Wextra -Wwrite-strings -Wno-sign-compare -ffunction-sections -fdata-sections -Wl,--gc-sections -c -o /home/peko/source/buildroot/output/build/host-mtd-1.4.5/mkfs.ubifs/mkfs.ubifs.o mkfs.ubifs.c -g -Wp,-MD,/home/peko/source/buildroot/output/build/host-mtd-1.4.5/mkfs.ubifs/.mkfs.ubifs.c.dep
>
> Do you have a custom HOST_CFLAGS defined in your environment or on the
> make cmdline by any chance?
>


No I doesn't define custum CFLAGS. I'm pretty sure about this. May I
found some workaround about this?

Thank you

> --
> Bye, Peter Korsgaard
>

regards
Alexjan

-- 
Alexjan Carraturo
--
Free Software User Group Italia administrator (http://www.fsugitalia.org)
Fedora/OpenSUSE Ambassador
member of FSFE Italian Team

Twitter/Facebook/Identica: axjslack
Blog: http://axjslack.wordpress.com
--

[Buildroot] [git commit] e2fsprogs: Add missing dependency of tst_uuid.o on uuid.h

[Peter Korsgaard]

>>>>> "Alexjan" == Alexjan Carraturo <axjslack@gmail.com> writes:

 >> Do you have a custom HOST_CFLAGS defined in your environment or on the
 >> make cmdline by any chance?

 Alexjan> No I doesn't define custum CFLAGS. I'm pretty sure about this. May I
 Alexjan> found some workaround about this?

Well, could you send me the output of:

set|grep CFLAGS

And then apply this little patch:

diff --git a/package/Makefile.in b/package/Makefile.in
index c3af5d3..fa01d1b 100644
--- a/package/Makefile.in
+++ b/package/Makefile.in
@@ -140,6 +140,12 @@ HOST_CFLAGS   ?= -O2
 HOST_CFLAGS   += -I$(HOST_DIR)/include -I$(HOST_DIR)/usr/include
 HOST_CXXFLAGS += -I$(HOST_DIR)/include -I$(HOST_DIR)/usr/include
 HOST_LDFLAGS  += -L$(HOST_DIR)/lib -L$(HOST_DIR)/usr/lib -Wl,-rpath,$(HOST_DIR)
+
+debug:
+       @echo CFLAGS=$(HOST_CFLAGS)
+       @echo CXXFLAGS=$(HOST_CXXFLAGS)
+       @echo LDFLAGS=$(HOST_LDFLAGS)
+
 HOST_PATH=$(HOST_DIR)/bin:$(HOST_DIR)/usr/bin:$(PATH)
 
 # hostcc version as an integer - E.G. 4.3.2 => 432

And send me the output of make debug

-- 
Bye, Peter Korsgaard

[Buildroot] [git commit] e2fsprogs: Add missing dependency of tst_uuid.o on uuid.h

[Alexjan Carraturo]

2011/7/25 Peter Korsgaard <jacmet@sunsite.dk>:
>>>>>> "Alexjan" == Alexjan Carraturo <axjslack@gmail.com> writes:
>
> ?>> Do you have a custom HOST_CFLAGS defined in your environment or on the
> ?>> make cmdline by any chance?
>
> ?Alexjan> No I doesn't define custum CFLAGS. I'm pretty sure about this. May I
> ?Alexjan> found some workaround about this?
>
> Well, could you send me the output of:
>
> set|grep CFLAGS
>
> And then apply this little patch:
>
> diff --git a/package/Makefile.in b/package/Makefile.in
> index c3af5d3..fa01d1b 100644
> --- a/package/Makefile.in
> +++ b/package/Makefile.in
> @@ -140,6 +140,12 @@ HOST_CFLAGS ? ?= -O2
> ?HOST_CFLAGS ? += -I$(HOST_DIR)/include -I$(HOST_DIR)/usr/include
> ?HOST_CXXFLAGS += -I$(HOST_DIR)/include -I$(HOST_DIR)/usr/include
> ?HOST_LDFLAGS ?+= -L$(HOST_DIR)/lib -L$(HOST_DIR)/usr/lib -Wl,-rpath,$(HOST_DIR)
> +
> +debug:
> + ? ? ? @echo CFLAGS=$(HOST_CFLAGS)
> + ? ? ? @echo CXXFLAGS=$(HOST_CXXFLAGS)
> + ? ? ? @echo LDFLAGS=$(HOST_LDFLAGS)
> +
> ?HOST_PATH=$(HOST_DIR)/bin:$(HOST_DIR)/usr/bin:$(PATH)
>
> ?# hostcc version as an integer - E.G. 4.3.2 => 432
>
> And send me the output of make debug
>


set|grep CFLAGS

(null) no output


make debug (with your patch)

package/Makefile.in:144: *** separatore  assente.  Stop.


Note: Separatore assente means "missing separator"


Thanks and regards
Alexjan.


> --
> Bye, Peter Korsgaard
>



-- 
Alexjan Carraturo
--
Free Software User Group Italia administrator (http://www.fsugitalia.org)
Fedora/OpenSUSE Ambassador
member of FSFE Italian Team

Twitter/Facebook/Identica: axjslack
Blog: http://axjslack.wordpress.com
--

[Buildroot] [git commit] e2fsprogs: Add missing dependency of tst_uuid.o on uuid.h

[Peter Korsgaard]

>>>>> "Alexjan" == Alexjan Carraturo <axjslack@gmail.com> writes:

Hi,

 Alexjan> make debug (with your patch)

 Alexjan> package/Makefile.in:144: *** separatore  assente.  Stop.


 Alexjan> Note: Separatore assente means "missing separator"

Then something probably went wrong with the patch - The @echo lines have
to be indented with a <tab>.

Care to try again?

-- 
Bye, Peter Korsgaard

[Buildroot] [git commit] e2fsprogs: Add missing dependency of tst_uuid.o on uuid.h

[Alexjan Carraturo]

2011/7/25 Peter Korsgaard <jacmet@sunsite.dk>:
>>>>>> "Alexjan" == Alexjan Carraturo <axjslack@gmail.com> writes:
>
> Hi,
>
> ?Alexjan> make debug (with your patch)
>
> ?Alexjan> package/Makefile.in:144: *** separatore ?assente. ?Stop.
>
>
> ?Alexjan> Note: Separatore assente means "missing separator"
>
> Then something probably went wrong with the patch - The @echo lines have
> to be indented with a <tab>.
>
> Care to try again?
>

Ok... now I had the tab manually and seems working

CFLAGS=-O2 -I/home/buildroot/buildroot-20110722/buildroot/output/host/include
-I/home/buildroot/buildroot-20110722/buildroot/output/host/usr/include
CXXFLAGS=-I/home/buildroot/buildroot-20110722/buildroot/output/host/include
-I/home/buildroot/buildroot-20110722/buildroot/output/host/usr/include
LDFLAGS=-L/home/buildroot/buildroot-20110722/buildroot/output/host/lib
-L/home/buildroot/buildroot-20110722/buildroot/output/host/usr/lib
-Wl,-rpath,/home/buildroot/buildroot-20110722/buildroot/output/host/usr/lib


> --
> Bye, Peter Korsgaard
>



-- 
Alexjan Carraturo
--
Free Software User Group Italia administrator (http://www.fsugitalia.org)
Fedora/OpenSUSE Ambassador
member of FSFE Italian Team

Twitter/Facebook/Identica: axjslack
Blog: http://axjslack.wordpress.com
--

[Buildroot] [git commit] e2fsprogs: Add missing dependency of tst_uuid.o on uuid.h

[Peter Korsgaard]

>>>>> "Alexjan" == Alexjan Carraturo <axjslack@gmail.com> writes:

Hi,

 Alexjan> Ok... now I had the tab manually and seems working

 Alexjan> CFLAGS=-O2 -I/home/buildroot/buildroot-20110722/buildroot/output/host/include
 Alexjan> -I/home/buildroot/buildroot-20110722/buildroot/output/host/usr/include
 Alexjan> CXXFLAGS=-I/home/buildroot/buildroot-20110722/buildroot/output/host/include
 Alexjan> -I/home/buildroot/buildroot-20110722/buildroot/output/host/usr/include
 Alexjan> LDFLAGS=-L/home/buildroot/buildroot-20110722/buildroot/output/host/lib
 Alexjan> -L/home/buildroot/buildroot-20110722/buildroot/output/host/usr/lib
 Alexjan> -Wl,-rpath,/home/buildroot/buildroot-20110722/buildroot/output/host/usr/lib

Ok, that looks good. So far so good, could you send me (in private) the
output of the host-mtd build? E.G.

rm -rf output/build/host-mtd-*
make host-mtd >/tmp/log.txt 2>&1

and send me /tmp/log.txt

-- 
Bye, Peter Korsgaard