[Buildroot] [PATCH 1/1] package/fio: remove native build to fix crashes

[Buildroot] [PATCH 1/1] package/fio: remove native build to fix crashes

[Jens Maus via buildroot]

Per default, the fio package uses the "-march=native" GCC option. This,
however can result in "illegal instructions" when fio is compiled in a
cross compile environment where the target machine will have a different
cpu feature set than the compilation environment. Thus we make sure fio
will not use that compiler option by adding --disable-native to
FIO_OPTS.

Signed-off-by: Jens Maus <mail@jens-maus.de>
---
 package/fio/fio.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/fio/fio.mk b/package/fio/fio.mk
index b1763d6c73..f6e7b036bb 100644
--- a/package/fio/fio.mk
+++ b/package/fio/fio.mk
@@ -9,7 +9,7 @@ FIO_SITE = http://brick.kernel.dk/snaps
 FIO_LICENSE = GPL-2.0
 FIO_LICENSE_FILES = COPYING MORAL-LICENSE
 
-FIO_OPTS = --cc="$(TARGET_CC)" --extra-cflags="$(TARGET_CFLAGS)"
+FIO_OPTS = --disable-native --cc="$(TARGET_CC)" --extra-cflags="$(TARGET_CFLAGS)"
 
 ifeq ($(BR2_PACKAGE_LIBAIO),y)
 FIO_DEPENDENCIES += libaio
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/fio: remove native build to fix crashes

[Arnout Vandecappelle via buildroot]

On 17/09/2023 22:29, Jens Maus via buildroot wrote:
> Per default, the fio package uses the "-march=native" GCC option. This,
> however can result in "illegal instructions" when fio is compiled in a
> cross compile environment where the target machine will have a different
> cpu feature set than the compilation environment. Thus we make sure fio
> will not use that compiler option by adding --disable-native to
> FIO_OPTS.
> 
> Signed-off-by: Jens Maus <mail@jens-maus.de>

  Applied to master, thanks.

  I changed the subject line of the commit message to

package/fio: remove -march=native

The subject line should give a short summary of _what_ is changed, the why is 
for in the body (and explained pretty well there).

  I also changed the body of the commit message a little.

  Regards,
  Arnout

> ---
>   package/fio/fio.mk | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/fio/fio.mk b/package/fio/fio.mk
> index b1763d6c73..f6e7b036bb 100644
> --- a/package/fio/fio.mk
> +++ b/package/fio/fio.mk
> @@ -9,7 +9,7 @@ FIO_SITE = http://brick.kernel.dk/snaps
>   FIO_LICENSE = GPL-2.0
>   FIO_LICENSE_FILES = COPYING MORAL-LICENSE
>   
> -FIO_OPTS = --cc="$(TARGET_CC)" --extra-cflags="$(TARGET_CFLAGS)"
> +FIO_OPTS = --disable-native --cc="$(TARGET_CC)" --extra-cflags="$(TARGET_CFLAGS)"
>   
>   ifeq ($(BR2_PACKAGE_LIBAIO),y)
>   FIO_DEPENDENCIES += libaio
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/fio: remove native build to fix crashes

[Peter Korsgaard]

>>>>> "Jens" == Jens Maus via buildroot <buildroot@buildroot.org> writes:

 > Per default, the fio package uses the "-march=native" GCC option. This,
 > however can result in "illegal instructions" when fio is compiled in a
 > cross compile environment where the target machine will have a different
 > cpu feature set than the compilation environment. Thus we make sure fio
 > will not use that compiler option by adding --disable-native to
 > FIO_OPTS.

 > Signed-off-by: Jens Maus <mail@jens-maus.de>

Committed to 2023.02.x, 2023.05.x and 2023.08.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot