Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 5/5] libcanfestival: new package
Date: Sun, 17 Mar 2013 23:05:45 +0100	[thread overview]
Message-ID: <87r4jd3cna.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <2e13931db1a39313732a16c48f923eb4445dc3d3.1363063832.git.s.martin49@gmail.com> (Samuel Martin's message of "Tue, 12 Mar 2013 05:58:43 +0100")

>>>>> "Samuel" == Samuel Martin <s.martin49@gmail.com> writes:

 Samuel> Cc: Eric Jarrige <eric.jarrige@armadeus.org>
 Samuel> Signed-off-by: Samuel Martin <s.martin49@gmail.com>

 Samuel> ---
 Samuel> Changes since v1:
 Samuel> - clean/fix *.mk
 Samuel> ---
 Samuel>  package/Config.in                                  |   1 +
 Samuel>  package/libcanfestival/Config.in                   |  90 +++
 Samuel>  .../libcanfestival-allow-to-set-DESTDIR.patch      | 717 +++++++++++++++++++++
 Samuel>  package/libcanfestival/libcanfestival.mk           |  43 ++
 Samuel>  4 files changed, 851 insertions(+)
 Samuel>  create mode 100644 package/libcanfestival/Config.in
 Samuel>  create mode 100644 package/libcanfestival/libcanfestival-allow-to-set-DESTDIR.patch
 Samuel>  create mode 100644 package/libcanfestival/libcanfestival.mk

 Samuel> diff --git a/package/Config.in b/package/Config.in
 Samuel> index 7d66b75..edfd4c4 100644
 Samuel> --- a/package/Config.in
 Samuel> +++ b/package/Config.in
 Samuel> @@ -495,6 +495,7 @@ endmenu
 
 Samuel>  menu "Networking"
 Samuel>  source "package/glib-networking/Config.in"
 Samuel> +source "package/libcanfestival/Config.in"
 Samuel>  source "package/libcgi/Config.in"
 Samuel>  source "package/libcgicc/Config.in"
 Samuel>  source "package/libcurl/Config.in"
 Samuel> diff --git a/package/libcanfestival/Config.in b/package/libcanfestival/Config.in
 Samuel> new file mode 100644
 Samuel> index 0000000..0be45cf
 Samuel> --- /dev/null
 Samuel> +++ b/package/libcanfestival/Config.in
 Samuel> @@ -0,0 +1,90 @@
 Samuel> +config BR2_PACKAGE_LIBCANFESTIVAL
 Samuel> +	bool "CanFestival"
 Samuel> +	help
 Samuel> +	  CanFestival is an OpenSource CANOpen framework, licensed with GPLv2
 Samuel> +	  and LGPLv2.

Licensed under.

 Samuel> +
 Samuel> +	  http://www.canfestival.org
 Samuel> +
 Samuel> +if BR2_PACKAGE_LIBCANFESTIVAL
 Samuel> +
 Samuel> +config BR2_PACKAGE_LIBCANFESTIVAL_NBMMAXCAN
 Samuel> +	string "Number of can bus to use"
 Samuel> +	default "4"

Number of can busses to use.

Any specific reason why you set this to 4? Upstream seems to set it to
1, and as far as I can see it isn't used anywhere in the code.

 Samuel> +
 Samuel> +choice
 Samuel> +	prompt "Driver to use"
 Samuel> +	default BR2_PACKAGE_LIBCANFESTIVAL_SOCKET
 Samuel> +
 Samuel> +config	BR2_PACKAGE_LIBCANFESTIVAL_ANAGATE_LINUX
 Samuel> +	bool "anagate_linux"
 Samuel> +	help
 Samuel> +	  AnaGate CAN(duo) driver for linux
 Samuel> +
 Samuel> +config	BR2_PACKAGE_LIBCANFESTIVAL_PEAK_LINUX

It's supposed to be 'config<space>BLAH', not 'config<tab>BLAH'.

 Samuel> +	bool "peak_linux"
 Samuel> +	help
 Samuel> +	  Linux build host installed Peak driver and library
 Samuel> +
 Samuel> +	  http://www.peak-system.com/linux/
 Samuel> +
 Samuel> +config	BR2_PACKAGE_LIBCANFESTIVAL_VIRTUAL
 Samuel> +	bool "virtual"
 Samuel> +	help
 Samuel> +	  Unix pipe based virtual can driver
 Samuel> +
 Samuel> +config	BR2_PACKAGE_LIBCANFESTIVAL_VIRTUAL_KERNEL
 Samuel> +	bool "virtual_kernel"
 Samuel> +	help
 Samuel> +	  Kernel module virtual can driver
 Samuel> +
 Samuel> +config	BR2_PACKAGE_LIBCANFESTIVAL_SOCKET
 Samuel> +	bool "socket"
 Samuel> +	help
 Samuel> +	  Socket-can
 Samuel> +
 Samuel> +	  http://developer.berlios.de/projects/socketcan/
 Samuel> +

Might be good to mention that this is the "normal" mainline CAN bus
interface.

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2013-03-17 22:05 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-12  4:58 [Buildroot] [pull request v2] Pull request for branch for-master/armadeus/new-pkgs Samuel Martin
2013-03-12  4:58 ` [Buildroot] [PATCH 1/5] openobex: new package Samuel Martin
2013-03-13  7:42   ` Thomas Petazzoni
2013-03-13 23:06   ` Peter Korsgaard
2013-03-12  4:58 ` [Buildroot] [PATCH 2/5] ussp-push: " Samuel Martin
2013-03-13  7:45   ` Thomas Petazzoni
2013-03-13 23:07   ` Peter Korsgaard
2013-03-12  4:58 ` [Buildroot] [PATCH 3/5] urg: " Samuel Martin
2013-03-17 21:33   ` Peter Korsgaard
2013-03-12  4:58 ` [Buildroot] [PATCH 4/5] flite: " Samuel Martin
2013-03-17 21:48   ` Peter Korsgaard
2013-03-18  9:43     ` Thomas Petazzoni
2013-03-12  4:58 ` [Buildroot] [PATCH 5/5] libcanfestival: " Samuel Martin
2013-03-17 22:05   ` Peter Korsgaard [this message]
2013-03-18 10:30   ` Yegor Yefremov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r4jd3cna.fsf@dell.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox