Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 4/5] flite: new package
Date: Sun, 17 Mar 2013 22:48:39 +0100	[thread overview]
Message-ID: <87vc8p3dfs.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <359a800fb351cc1d10532e184d9dc7d30c5cd991.1363063832.git.s.martin49@gmail.com> (Samuel Martin's message of "Tue, 12 Mar 2013 05:58:42 +0100")

>>>>> "Samuel" == Samuel Martin <s.martin49@gmail.com> writes:

 Samuel> Cc: Eric Jarrige <eric.jarrige@armadeus.org>
 Samuel> Signed-off-by: Samuel Martin <s.martin49@gmail.com>

 Samuel> ---
 Samuel> Changes since v1:
 Samuel> - fix dependencies
 Samuel> ---
 Samuel>  package/multimedia/Config.in       |  1 +
 Samuel>  package/multimedia/flite/Config.in | 15 ++++++++++
 Samuel>  package/multimedia/flite/flite.mk  | 58 ++++++++++++++++++++++++++++++++++++++
 Samuel>  3 files changed, 74 insertions(+)
 Samuel>  create mode 100644 package/multimedia/flite/Config.in
 Samuel>  create mode 100644 package/multimedia/flite/flite.mk

 Samuel> diff --git a/package/multimedia/Config.in b/package/multimedia/Config.in
 Samuel> @@ -0,0 +1,58 @@
 Samuel> +#############################################################
 Samuel> +#
 Samuel> +# flite
 Samuel> +#
 Samuel> +#############################################################
 Samuel> +
 Samuel> +FLITE_VERSION = 1.4
 Samuel> +FLITE_SOURCE = flite-$(FLITE_VERSION)-release.tar.bz2
 Samuel> +FLITE_SITE = http://www.speech.cs.cmu.edu/flite/packed/flite-$(FLITE_VERSION)
 Samuel> +FLITE_LICENSE = BSD-4c
 Samuel> +FLITE_LICENSE_FILES = COPYING
 Samuel> +
 Samuel> +FLITE_INSTALL_STAGING = YES
 Samuel> +
 Samuel> +# Sadly, Flite does not support parallel build,
 Samuel> +# especially when building its shared libraries.
 Samuel> +FLITE_MAKE = $(MAKE1)
 Samuel> +
 Samuel> +FLITE_CONF_OPT = \
 Samuel> +	$(if $(BR2_PREFER_STATIC_LIB),,--enable-shared)

We're already pass --enable-shared in the autotools infrastructure, so
why is this needed?

 Samuel> +
 Samuel> +FLITE_INSTALL_STAGING_OPT = \
 Samuel> +	INSTALLBINDIR=$(STAGING_DIR)/usr/bin \
 Samuel> +	INSTALLLIBDIR=$(STAGING_DIR)/usr/lib \
 Samuel> +	INSTALLINCDIR=$(STAGING_DIR)/usr/include/flite \
 Samuel> +	install
 Samuel> +
 Samuel> +FLITE_INSTALL_TARGET_OPT = \
 Samuel> +	INSTALLBINDIR=$(TARGET_DIR)/usr/bin \
 Samuel> +	INSTALLLIBDIR=$(TARGET_DIR)/usr/lib \
 Samuel> +	INSTALLINCDIR=$(TARGET_DIR)/usr/include/flite \
 Samuel> +	install

It could be good with a note about why this is needed (E.G. flite used a
handwritten a Makefile which doesn't handle DESTDIR even though it uses
autoconf).

 Samuel> +
 Samuel> +# Flite totally screw up their tarball generation, so that:
 Samuel> +#
 Samuel> +#   $ tar tf flite-1.4-release.tar.bz2

Argh :/

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2013-03-17 21:48 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-12  4:58 [Buildroot] [pull request v2] Pull request for branch for-master/armadeus/new-pkgs Samuel Martin
2013-03-12  4:58 ` [Buildroot] [PATCH 1/5] openobex: new package Samuel Martin
2013-03-13  7:42   ` Thomas Petazzoni
2013-03-13 23:06   ` Peter Korsgaard
2013-03-12  4:58 ` [Buildroot] [PATCH 2/5] ussp-push: " Samuel Martin
2013-03-13  7:45   ` Thomas Petazzoni
2013-03-13 23:07   ` Peter Korsgaard
2013-03-12  4:58 ` [Buildroot] [PATCH 3/5] urg: " Samuel Martin
2013-03-17 21:33   ` Peter Korsgaard
2013-03-12  4:58 ` [Buildroot] [PATCH 4/5] flite: " Samuel Martin
2013-03-17 21:48   ` Peter Korsgaard [this message]
2013-03-18  9:43     ` Thomas Petazzoni
2013-03-12  4:58 ` [Buildroot] [PATCH 5/5] libcanfestival: " Samuel Martin
2013-03-17 22:05   ` Peter Korsgaard
2013-03-18 10:30   ` Yegor Yefremov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vc8p3dfs.fsf@dell.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox