Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] New package minicom
@ 2012-03-09 13:18 Simon Dawson
  2012-03-10 13:26 ` Arnout Vandecappelle
  2012-03-11 14:28 ` Peter Korsgaard
  0 siblings, 2 replies; 3+ messages in thread
From: Simon Dawson @ 2012-03-09 13:18 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Simon Dawson<spdawson@gmail.com>
---
 package/Config.in          |    1 +
 package/minicom/Config.in  |    9 +++++++++
 package/minicom/minicom.mk |   12 ++++++++++++
 3 files changed, 22 insertions(+), 0 deletions(-)
 create mode 100644 package/minicom/Config.in
 create mode 100644 package/minicom/minicom.mk

diff --git a/package/Config.in b/package/Config.in
index 41cbb8c..c582f8a 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -197,6 +197,7 @@ source "package/lvm2/Config.in"
 source "package/makedevs/Config.in"
 source "package/mdadm/Config.in"
 source "package/memtester/Config.in"
+source "package/minicom/Config.in"
 source "package/mtd/Config.in"
 source "package/ntfs-3g/Config.in"
 source "package/ntfsprogs/Config.in"
diff --git a/package/minicom/Config.in b/package/minicom/Config.in
new file mode 100644
index 0000000..9a69eb1
--- /dev/null
+++ b/package/minicom/Config.in
@@ -0,0 +1,9 @@
+config BR2_PACKAGE_MINICOM
+       bool "minicom"
+       select BR2_PACKAGE_LIBICONV
+       help
+         Minicom is a menu driven communications program.
+         It emulates ANSI and VT102 terminals. It has a
+         dialing directory and auto zmodem download.
+
+         http://alioth.debian.org/projects/minicom
diff --git a/package/minicom/minicom.mk b/package/minicom/minicom.mk
new file mode 100644
index 0000000..f6bcd6c
--- /dev/null
+++ b/package/minicom/minicom.mk
@@ -0,0 +1,12 @@
+#############################################################
+#
+# minicom
+#
+#############################################################
+MINICOM_VERSION = 2.6
+MINICOM_SOURCE = minicom-$(MINICOM_VERSION).tar.gz
+MINICOM_SITE = http://alioth.debian.org/frs/download.php/3689/
+
+MINICOM_DEPENDENCIES = libiconv
+
+$(eval $(call AUTOTARGETS))

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] New package minicom
  2012-03-09 13:18 [Buildroot] New package minicom Simon Dawson
@ 2012-03-10 13:26 ` Arnout Vandecappelle
  2012-03-11 14:28 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Arnout Vandecappelle @ 2012-03-10 13:26 UTC (permalink / raw)
  To: buildroot

On Friday 09 March 2012 14:18:03 Simon Dawson wrote:
> Signed-off-by: Simon Dawson<spdawson@gmail.com>
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

 Except for the missing space in the Signed-off-by line :-)
-- 
Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] New package minicom
  2012-03-09 13:18 [Buildroot] New package minicom Simon Dawson
  2012-03-10 13:26 ` Arnout Vandecappelle
@ 2012-03-11 14:28 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2012-03-11 14:28 UTC (permalink / raw)
  To: buildroot

>>>>> "Simon" == Simon Dawson <spdawson@gmail.com> writes:

 Simon> Signed-off-by: Simon Dawson<spdawson@gmail.com>
 Simon> ---
 Simon>  package/Config.in          |    1 +
 Simon>  package/minicom/Config.in  |    9 +++++++++
 Simon>  package/minicom/minicom.mk |   12 ++++++++++++
 Simon>  3 files changed, 22 insertions(+), 0 deletions(-)
 Simon>  create mode 100644 package/minicom/Config.in
 Simon>  create mode 100644 package/minicom/minicom.mk

 Simon> diff --git a/package/Config.in b/package/Config.in
 Simon> index 41cbb8c..c582f8a 100644
 Simon> --- a/package/Config.in
 Simon> +++ b/package/Config.in
 Simon> @@ -197,6 +197,7 @@ source "package/lvm2/Config.in"
 Simon>  source "package/makedevs/Config.in"
 Simon>  source "package/mdadm/Config.in"
 Simon>  source "package/memtester/Config.in"
 Simon> +source "package/minicom/Config.in"
 Simon>  source "package/mtd/Config.in"
 Simon>  source "package/ntfs-3g/Config.in"
 Simon>  source "package/ntfsprogs/Config.in"
 Simon> diff --git a/package/minicom/Config.in b/package/minicom/Config.in
 Simon> new file mode 100644
 Simon> index 0000000..9a69eb1
 Simon> --- /dev/null
 Simon> +++ b/package/minicom/Config.in
 Simon> @@ -0,0 +1,9 @@
 Simon> +config BR2_PACKAGE_MINICOM
 Simon> +       bool "minicom"

These lines should be idented with a <tab> instead of spaces.

 Simon> +       select BR2_PACKAGE_LIBICONV

libiconv is only needed if the toolchain doesn't have locale (E.G. has
iconv support), so this should be

select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE

It also needs WCHAR support in the toolchain, and uses ncurses, so those
needs to be depended on / selected as well.

 Simon> +       help
 Simon> +         Minicom is a menu driven communications program.
 Simon> +         It emulates ANSI and VT102 terminals. It has a
 Simon> +         dialing directory and auto zmodem download.

And help lines with <tab><space><space>.

 Simon> +
 Simon> +         http://alioth.debian.org/projects/minicom
 Simon> diff --git a/package/minicom/minicom.mk b/package/minicom/minicom.mk
 Simon> new file mode 100644
 Simon> index 0000000..f6bcd6c
 Simon> --- /dev/null
 Simon> +++ b/package/minicom/minicom.mk
 Simon> @@ -0,0 +1,12 @@
 Simon> +#############################################################
 Simon> +#
 Simon> +# minicom
 Simon> +#
 Simon> +#############################################################
 Simon> +MINICOM_VERSION = 2.6
 Simon> +MINICOM_SOURCE = minicom-$(MINICOM_VERSION).tar.gz
 Simon> +MINICOM_SITE = http://alioth.debian.org/frs/download.php/3689/
 Simon> +

The configure script uses pkg-config to detect if liblockdev is
available, so normally you need to depend on host-pkg-config. We don't
have liblockdev in BR (yet?), so I instead set PKG_CONFIG to /bin/false
as it takes a while to build pkg-config.

 Simon> +MINICOM_DEPENDENCIES = libiconv

libiconv should only be added for !BR2_ENABLE_LOCALE, and ncurses should
be added as well.

I've committed it with those fixes, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-03-11 14:28 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-09 13:18 [Buildroot] New package minicom Simon Dawson
2012-03-10 13:26 ` Arnout Vandecappelle
2012-03-11 14:28 ` Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox