Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] package: add openocd support
Date: Sun, 01 May 2011 18:20:42 +0200	[thread overview]
Message-ID: <87r58iv1d1.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <1304170969-30138-2-git-send-email-plagnioj@jcrosoft.com> (Jean-Christophe PLAGNIOL-VILLARD's message of "Sat, 30 Apr 2011 15:42:49 +0200")

>>>>> "Jean-Christophe" == Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com> writes:

 Jean-Christophe> with only usb option that depend only on libusb for now on
 Jean-Christophe> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
 Jean-Christophe> Cc: Nicolas Ferre <nicolas.ferre@atmel.com>
 Jean-Christophe> Cc: Patrice Vilchez <patrice.vilchez@atmel.com>
 Jean-Christophe> ---
 Jean-Christophe>  package/Config.in          |    1 +
 Jean-Christophe>  package/openocd/Config.in  |   85 ++++++++++++++++++++++++++++++++++++++++++++
 Jean-Christophe>  package/openocd/openocd.mk |   50 ++++++++++++++++++++++++++
 Jean-Christophe>  3 files changed, 136 insertions(+), 0 deletions(-)
 Jean-Christophe>  create mode 100644 package/openocd/Config.in
 Jean-Christophe>  create mode 100644 package/openocd/openocd.mk

 Jean-Christophe> diff --git a/package/Config.in b/package/Config.in
 Jean-Christophe> index cd89892..4f24595 100644
 Jean-Christophe> --- a/package/Config.in
 Jean-Christophe> +++ b/package/Config.in
 Jean-Christophe> @@ -362,6 +362,7 @@ endmenu
 
 Jean-Christophe>  menu "Miscellaneous"
 Jean-Christophe>  source "package/shared-mime-info/Config.in"
 Jean-Christophe> +source "package/openocd/Config.in"

I would think 'hardware handling' would be a better location. Don't
forget sort alphabetically.

 Jean-Christophe>  menu "Networking applications"
 Jean-Christophe> diff --git a/package/openocd/Config.in b/package/openocd/Config.in
 Jean-Christophe> new file mode 100644
 Jean-Christophe> index 0000000..3efa3e7
 Jean-Christophe> --- /dev/null
 Jean-Christophe> +++ b/package/openocd/Config.in
 Jean-Christophe> @@ -0,0 +1,85 @@
 Jean-Christophe> +menuconfig BR2_PACKAGE_OPENOCD
 Jean-Christophe> +	bool "OpenOCD"
 Jean-Christophe> +	select BR2_PACKAGE_LIBUSB
 Jean-Christophe> +	select BR2_PACKAGE_LIBUSB_COMPAT
 Jean-Christophe> +	select BR2_PACKAGE_JIMTCL
 Jean-Christophe> +	help
 Jean-Christophe> +	  OpenOCD - Open On-Chip Debugger
 Jean-Christophe> +
 Jean-Christophe> +	  http://openocd.berlios.de/web/
 Jean-Christophe> +
 Jean-Christophe> +if BR2_PACKAGE_OPENOCD
 Jean-Christophe> +
 Jean-Christophe> +choice
 Jean-Christophe> +	prompt "OPENOCD Git"
 Jean-Christophe> +	default BR2_TARGET_OPENOCD_GIT
 Jean-Christophe> +	help
 Jean-Christophe> +	  Select the specific OpenOCD Git you want to use

Again, do we really need the version / git location options?

 Jean-Christophe> +config BR2_PACKAGE_OPENOCD_ETM
 Jean-Christophe> +	bool "OpenOCD+trace ETM capture hardware"
 Jean-Christophe> +	help
 Jean-Christophe> +	  OpenOCD+trace ETM capture hardware for some prototype

That help text could use some work I think.

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2011-05-01 16:20 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-30 13:42 [Buildroot] [PATCH 1/2] package: add jimtcl support Jean-Christophe PLAGNIOL-VILLARD
2011-04-30 13:42 ` [Buildroot] [PATCH 2/2] package: add openocd support Jean-Christophe PLAGNIOL-VILLARD
2011-05-01 16:20   ` Peter Korsgaard [this message]
2011-05-01 16:45     ` Jean-Christophe PLAGNIOL-VILLARD
2011-05-01 12:35 ` [Buildroot] [PATCH 1/2] package: add jimtcl support Jean-Christophe PLAGNIOL-VILLARD
2011-05-01 15:59 ` Peter Korsgaard
2011-05-01 16:43   ` Jean-Christophe PLAGNIOL-VILLARD
2011-05-01 17:49     ` Peter Korsgaard
2011-05-02  5:41       ` Jean-Christophe PLAGNIOL-VILLARD
2011-05-02  6:44         ` Thomas Petazzoni
2011-05-02 15:47           ` Jean-Christophe PLAGNIOL-VILLARD
  -- strict thread matches above, loose matches on Subject: below --
2011-08-09 17:39 [Buildroot] [PATCH 1/2] package: add libftdi support Jean-Christophe PLAGNIOL-VILLARD
2011-08-09 17:39 ` [Buildroot] [PATCH 2/2] package: add openocd support Jean-Christophe PLAGNIOL-VILLARD
2011-08-15 13:54   ` Jean-Christophe PLAGNIOL-VILLARD
2011-08-17 10:57   ` Thomas Petazzoni
2011-08-17 17:32     ` Jean-Christophe PLAGNIOL-VILLARD
2011-09-11  9:17   ` Peter Korsgaard
2011-09-17 19:37     ` Jean-Christophe PLAGNIOL-VILLARD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r58iv1d1.fsf@macbook.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox