From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] package: add jimtcl support
Date: Sun, 01 May 2011 17:59:37 +0200 [thread overview]
Message-ID: <87vcxuv2c6.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <1304170969-30138-1-git-send-email-plagnioj@jcrosoft.com> (Jean-Christophe PLAGNIOL-VILLARD's message of "Sat, 30 Apr 2011 15:42:48 +0200")
>>>>> "Jean-Christophe" == Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com> writes:
Jean-Christophe> you will download it via git
Jean-Christophe> and can specify which repos and/or which commit
Jean-Christophe> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Jean-Christophe> Cc: Nicolas Ferre <nicolas.ferre@atmel.com>
Jean-Christophe> Cc: Patrice Vilchez <patrice.vilchez@atmel.com>
Jean-Christophe> ---
Jean-Christophe> package/Config.in | 1 +
Jean-Christophe> package/jimtcl/Config.in | 65 ++++++++++++++++++++++++++++++++++++++++++++++
Jean-Christophe> package/jimtcl/jimtcl.mk | 30 +++++++++++++++++++++
Jean-Christophe> 3 files changed, 96 insertions(+), 0 deletions(-)
Jean-Christophe> create mode 100644 package/jimtcl/Config.in
Jean-Christophe> create mode 100644 package/jimtcl/jimtcl.mk
Jean-Christophe> diff --git a/package/Config.in b/package/Config.in
Jean-Christophe> index 76b2076..cd89892 100644
Jean-Christophe> --- a/package/Config.in
Jean-Christophe> +++ b/package/Config.in
Jean-Christophe> @@ -231,6 +231,7 @@ source "package/php/Config.in"
Jean-Christophe> source "package/python/Config.in"
Jean-Christophe> source "package/ruby/Config.in"
Jean-Christophe> source "package/tcl/Config.in"
Jean-Christophe> +source "package/jimtcl/Config.in"
Please sort alphabetically.
Jean-Christophe> endmenu
Jean-Christophe> menu "Libraries"
Jean-Christophe> diff --git a/package/jimtcl/Config.in b/package/jimtcl/Config.in
Jean-Christophe> new file mode 100644
Jean-Christophe> index 0000000..7847d19
Jean-Christophe> --- /dev/null
Jean-Christophe> +++ b/package/jimtcl/Config.in
Jean-Christophe> @@ -0,0 +1,65 @@
Jean-Christophe> +menuconfig BR2_PACKAGE_JIMTCL
Jean-Christophe> + bool "jimtcl"
Jean-Christophe> + help
Jean-Christophe> + Small footprint implementation of Tcl programming language
Jean-Christophe> +
Jean-Christophe> + http://jim.berlios.de/
Jean-Christophe> +
Jean-Christophe> +if BR2_PACKAGE_JIMTCL
Jean-Christophe> +
Jean-Christophe> +choice
Jean-Christophe> + prompt "JIMTCL Version"
You have a mix of jimtcl/JIMTCL/Jimtcl - Please use the same
capitalization everywhere.
Jean-Christophe> + default BR2_TARGET_JIMTCL_GIT
Jean-Christophe> + help
Jean-Christophe> + Select the specific jimtcl version you want to use
Jean-Christophe> +
Jean-Christophe> +config BR2_TARGET_JIMTCL_GIT
Jean-Christophe> + bool "Official git"
Jean-Christophe> +
Jean-Christophe> +config BR2_TARGET_JIMTCL_GIT_CUSTOM
Jean-Christophe> + bool "Custom"
Is there really a need to support anything else than 0.70? We prefer to
only have 1 version as that simplified implementation and testing.
Jean-Christophe> +#############################################################
Jean-Christophe> +#
Jean-Christophe> +# jimtcl
Jean-Christophe> +#
Jean-Christophe> +#############################################################
Jean-Christophe> +JIMTCL_VERSION:=$(call qstrip,$(BR2_TARGET_JIMTCL_VERSION))
Jean-Christophe> +JIMTCL_SITE_METHOD:=git
Please use ' = ' rather than ':=' unless you have a special need for the
direct expansion.
Jean-Christophe> +DL_TOOLS_DEPENDENCIES += git
That's handled automatically.
Jean-Christophe> +JIMTCL_INSTALL_STAGING = YES
Jean-Christophe> +JIMTCL_INSTALL_TARGET = NO
Why no installation on target?
Jean-Christophe> +
Jean-Christophe> +OPENOCD_AUTORECONF = YES
This is JIMTCL, not OPENOCD.
Jean-Christophe> +
Jean-Christophe> +JIMTCL_INSTALL_STAGING_OPT= DESTDIR=$(STAGING_DIR)/usr install
Does it really use autotools and have broken DESTDIR support?
Jean-Christophe> +$(eval $(call AUTOTARGETS,package,jimtcl))
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2011-05-01 15:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-30 13:42 [Buildroot] [PATCH 1/2] package: add jimtcl support Jean-Christophe PLAGNIOL-VILLARD
2011-04-30 13:42 ` [Buildroot] [PATCH 2/2] package: add openocd support Jean-Christophe PLAGNIOL-VILLARD
2011-05-01 16:20 ` Peter Korsgaard
2011-05-01 16:45 ` Jean-Christophe PLAGNIOL-VILLARD
2011-05-01 12:35 ` [Buildroot] [PATCH 1/2] package: add jimtcl support Jean-Christophe PLAGNIOL-VILLARD
2011-05-01 15:59 ` Peter Korsgaard [this message]
2011-05-01 16:43 ` Jean-Christophe PLAGNIOL-VILLARD
2011-05-01 17:49 ` Peter Korsgaard
2011-05-02 5:41 ` Jean-Christophe PLAGNIOL-VILLARD
2011-05-02 6:44 ` Thomas Petazzoni
2011-05-02 15:47 ` Jean-Christophe PLAGNIOL-VILLARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vcxuv2c6.fsf@macbook.be.48ers.dk \
--to=jacmet@uclibc.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox