* [Buildroot] [PATCH] cdrkit: fix build by adding zlib as dependency
@ 2010-06-06 21:43 Bjørn Forsman
2010-06-07 7:22 ` Thomas Petazzoni
0 siblings, 1 reply; 6+ messages in thread
From: Bjørn Forsman @ 2010-06-06 21:43 UTC (permalink / raw)
To: buildroot
cdrkit: fix build by adding zlib as dependency.
---
package/cdrkit/cdrkit.mk | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/package/cdrkit/cdrkit.mk b/package/cdrkit/cdrkit.mk
index a6a2e80..a23ffad 100644
--- a/package/cdrkit/cdrkit.mk
+++ b/package/cdrkit/cdrkit.mk
@@ -2,7 +2,7 @@ CDRKIT_VERSION=1.1.10
CDRKIT_SOURCE=cdrkit-$(CDRKIT_VERSION).tar.gz
CDRKIT_SITE=http://www.cdrkit.org/releases/
-CDRKIT_DEPENDENCIES=libcap bzip2 host-cmake
+CDRKIT_DEPENDENCIES=libcap bzip2 zlib host-cmake
HOST_CDRKIT_DEPENDENCIES=host-libcap host-cmake host-bzip2
ifeq ($(BR2_ENDIAN),"BIG")
--
1.7.0.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] cdrkit: fix build by adding zlib as dependency
2010-06-06 21:43 Bjørn Forsman
@ 2010-06-07 7:22 ` Thomas Petazzoni
2010-06-07 9:08 ` Thomas Petazzoni
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Petazzoni @ 2010-06-07 7:22 UTC (permalink / raw)
To: buildroot
On Sun, 6 Jun 2010 23:43:20 +0200
Bj?rn Forsman <bjorn.forsman@gmail.com> wrote:
> -CDRKIT_DEPENDENCIES=libcap bzip2 host-cmake
> +CDRKIT_DEPENDENCIES=libcap bzip2 zlib host-cmake
> HOST_CDRKIT_DEPENDENCIES=host-libcap host-cmake host-bzip2
If zlib is indeed needed on the target, we also need to add it on the
host as well, ie:
HOST_CDRKIT_DEPENDENCIES=host-libcap host-cmake host-bzip2 host-zlib
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] cdrkit: fix build by adding zlib as dependency
2010-06-07 7:22 ` Thomas Petazzoni
@ 2010-06-07 9:08 ` Thomas Petazzoni
2010-06-07 9:12 ` Bjørn Forsman
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Petazzoni @ 2010-06-07 9:08 UTC (permalink / raw)
To: buildroot
On Mon, 7 Jun 2010 09:22:01 +0200
Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote:
> > -CDRKIT_DEPENDENCIES=libcap bzip2 host-cmake
> > +CDRKIT_DEPENDENCIES=libcap bzip2 zlib host-cmake
> > HOST_CDRKIT_DEPENDENCIES=host-libcap host-cmake host-bzip2
>
> If zlib is indeed needed on the target, we also need to add it on the
> host as well, ie:
>
> HOST_CDRKIT_DEPENDENCIES=host-libcap host-cmake host-bzip2 host-zlib
I confirm that zlib is indeed needed to build cdrkit. Can you resend
your patches with the host-zlib addition ?
In that case, your patch would have my
Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Thanks!
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] cdrkit: fix build by adding zlib as dependency
2010-06-07 9:08 ` Thomas Petazzoni
@ 2010-06-07 9:12 ` Bjørn Forsman
0 siblings, 0 replies; 6+ messages in thread
From: Bjørn Forsman @ 2010-06-07 9:12 UTC (permalink / raw)
To: buildroot
On 7 June 2010 11:08, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> On Mon, 7 Jun 2010 09:22:01 +0200
> Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote:
>
>> > -CDRKIT_DEPENDENCIES=libcap bzip2 host-cmake
>> > +CDRKIT_DEPENDENCIES=libcap bzip2 zlib host-cmake
>> > ?HOST_CDRKIT_DEPENDENCIES=host-libcap host-cmake host-bzip2
>>
>> If zlib is indeed needed on the target, we also need to add it on the
>> host as well, ie:
>>
>> HOST_CDRKIT_DEPENDENCIES=host-libcap host-cmake host-bzip2 host-zlib
>
> I confirm that zlib is indeed needed to build cdrkit. Can you resend
> your patches with the host-zlib addition ?
>
> In that case, your patch would have my
>
> Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Thanks. I will send updated patch.
Best regards,
Bj?rn forsman
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] cdrkit: fix build by adding zlib as dependency
@ 2010-06-07 11:37 Bjørn Forsman
2010-06-08 20:43 ` Peter Korsgaard
0 siblings, 1 reply; 6+ messages in thread
From: Bjørn Forsman @ 2010-06-07 11:37 UTC (permalink / raw)
To: buildroot
cdrkit: fix build by adding zlib as dependency.
Signed-off-by: Bj?rn Forsman <bjorn.forsman@gmail.com>
---
package/cdrkit/cdrkit.mk | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/package/cdrkit/cdrkit.mk b/package/cdrkit/cdrkit.mk
index a6a2e80..f7e21b0 100644
--- a/package/cdrkit/cdrkit.mk
+++ b/package/cdrkit/cdrkit.mk
@@ -2,8 +2,8 @@ CDRKIT_VERSION=1.1.10
CDRKIT_SOURCE=cdrkit-$(CDRKIT_VERSION).tar.gz
CDRKIT_SITE=http://www.cdrkit.org/releases/
-CDRKIT_DEPENDENCIES=libcap bzip2 host-cmake
-HOST_CDRKIT_DEPENDENCIES=host-libcap host-cmake host-bzip2
+CDRKIT_DEPENDENCIES=libcap bzip2 host-cmake zlib
+HOST_CDRKIT_DEPENDENCIES=host-libcap host-cmake host-bzip2 host-zlib
ifeq ($(BR2_ENDIAN),"BIG")
CMAKE_ENDIAN_OPT=-DBITFIELDS_HTOL=1
--
1.7.0.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] cdrkit: fix build by adding zlib as dependency
2010-06-07 11:37 [Buildroot] [PATCH] cdrkit: fix build by adding zlib as dependency Bjørn Forsman
@ 2010-06-08 20:43 ` Peter Korsgaard
0 siblings, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2010-06-08 20:43 UTC (permalink / raw)
To: buildroot
>>>>> "Bj?rn" == Bj?rn Forsman <bjorn.forsman@gmail.com> writes:
Bj?rn> cdrkit: fix build by adding zlib as dependency.
Committed, thanks.
-
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-06-08 20:43 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-07 11:37 [Buildroot] [PATCH] cdrkit: fix build by adding zlib as dependency Bjørn Forsman
2010-06-08 20:43 ` Peter Korsgaard
-- strict thread matches above, loose matches on Subject: below --
2010-06-06 21:43 Bjørn Forsman
2010-06-07 7:22 ` Thomas Petazzoni
2010-06-07 9:08 ` Thomas Petazzoni
2010-06-07 9:12 ` Bjørn Forsman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox