From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] jffs2: let makedevs create device files
Date: Sat, 05 Jun 2010 21:23:51 +0200 [thread overview]
Message-ID: <87r5klnv08.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <5682fe13ee493517e0d0007caa2f61ed676f2789.1275751113.git.thomas.petazzoni@free-electrons.com> (Thomas Petazzoni's message of "Sat, 5 Jun 2010 17:18:40 +0200")
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
Thomas> The common filesystem infrastructure in fs/common.mk uses a smart
Thomas> combination of makedevs and fakeroot to create the device files in the
Thomas> target filesystem images without being root. This technique is applied
Thomas> to all filesystem formats that rely on this common infrastructure, and
Thomas> JFFS2 is one of them.
Thomas> Therefore, using the -D option of mkfs.jffs2, which allows to specify
Thomas> a device table, is redundant with the usage of makedevs. And it is
Thomas> worst than redundant: for some reason, -D does not create all device
Thomas> files with the correct major and minor numbers, as reported in bug
Thomas> For coherence, we just remove the usage of mkfs.jffs2 -D option, and
Thomas> rely on makedevs/fakeroot to create the device files.
Thomas> This commit fixes bug #1771.
Committed, thanks!
--
Bye, Peter Korsgaard
prev parent reply other threads:[~2010-06-05 19:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-05 15:18 [Buildroot] [pull request] Pull request for branch jffs2-fix-bug-1771 Thomas Petazzoni
2010-06-05 15:18 ` [Buildroot] [PATCH 1/1] jffs2: let makedevs create device files Thomas Petazzoni
2010-06-05 19:23 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r5klnv08.fsf@macbook.be.48ers.dk \
--to=jacmet@uclibc.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox