[Buildroot] [pull request] Pull request for branch jffs2-fix-bug-1771

[Buildroot] [pull request] Pull request for branch jffs2-fix-bug-1771

[Thomas Petazzoni]

The following changes since commit e1a7d916e9eeaa215551740de40c055130d6c073:
  Peter Korsgaard (1):
        Revert "Add -rpath option for host package compilation"

are available in the git repository at:

  git://git.busybox.net/~tpetazzoni/git/buildroot jffs2-fix-bug-1771

Thomas Petazzoni (1):
      jffs2: let makedevs create device files

 fs/jffs2/jffs2.mk |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

Thanks,
-- 
Thomas Petazzoni

[Buildroot] [PATCH 1/1] jffs2: let makedevs create device files

[Thomas Petazzoni]

The common filesystem infrastructure in fs/common.mk uses a smart
combination of makedevs and fakeroot to create the device files in the
target filesystem images without being root. This technique is applied
to all filesystem formats that rely on this common infrastructure, and
JFFS2 is one of them.

Therefore, using the -D option of mkfs.jffs2, which allows to specify
a device table, is redundant with the usage of makedevs. And it is
worst than redundant: for some reason, -D does not create all device
files with the correct major and minor numbers, as reported in bug

For coherence, we just remove the usage of mkfs.jffs2 -D option, and
rely on makedevs/fakeroot to create the device files.

This commit fixes bug #1771.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 fs/jffs2/jffs2.mk |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/fs/jffs2/jffs2.mk b/fs/jffs2/jffs2.mk
index 36be037..fd5da0c 100644
--- a/fs/jffs2/jffs2.mk
+++ b/fs/jffs2/jffs2.mk
@@ -32,10 +32,6 @@ JFFS2_OPTS += -n
 SUMTOOL_OPTS += -n
 endif
 
-ifneq ($(ROOTFS_DEVICE_TABLE),)
-JFFS2_OPTS += -D $(ROOTFS_DEVICE_TABLE)
-endif
-
 ROOTFS_JFFS2_DEPENDENCIES = host-mtd
 
 ifneq ($(BR2_TARGET_ROOTFS_JFFS2_SUMMARY),)
-- 
1.7.0.4

[Buildroot] [PATCH 1/1] jffs2: let makedevs create device files

[Peter Korsgaard]

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 Thomas> The common filesystem infrastructure in fs/common.mk uses a smart
 Thomas> combination of makedevs and fakeroot to create the device files in the
 Thomas> target filesystem images without being root. This technique is applied
 Thomas> to all filesystem formats that rely on this common infrastructure, and
 Thomas> JFFS2 is one of them.

 Thomas> Therefore, using the -D option of mkfs.jffs2, which allows to specify
 Thomas> a device table, is redundant with the usage of makedevs. And it is
 Thomas> worst than redundant: for some reason, -D does not create all device
 Thomas> files with the correct major and minor numbers, as reported in bug

 Thomas> For coherence, we just remove the usage of mkfs.jffs2 -D option, and
 Thomas> rely on makedevs/fakeroot to create the device files.

 Thomas> This commit fixes bug #1771.

Committed, thanks!

-- 
Bye, Peter Korsgaard