* [Buildroot] svn commit: trunk/buildroot/package/multimedia/mpg123
@ 2009-01-24 10:15 ulf at uclibc.org
2009-01-24 10:31 ` Peter Korsgaard
2009-01-24 10:37 ` Peter Korsgaard
0 siblings, 2 replies; 9+ messages in thread
From: ulf at uclibc.org @ 2009-01-24 10:15 UTC (permalink / raw)
To: buildroot
Author: ulf
Date: 2009-01-24 10:15:05 +0000 (Sat, 24 Jan 2009)
New Revision: 24999
Log:
Add fix to mpg123 for bug in ARM release toolchain causing segment violation, bug reported to gcc bugzilla
Added:
trunk/buildroot/package/multimedia/mpg123/mpg123-0.66-arm-unroll.patch
Modified:
trunk/buildroot/package/multimedia/mpg123/Config.in
trunk/buildroot/package/multimedia/mpg123/mpg123.mk
Changeset:
Sorry, the patch is too large to include (2181 lines).
Please use ViewCVS to see it!
http://uclibc.org/cgi-bin/viewcvs.cgi?view=rev&root=svn&rev=24999
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] svn commit: trunk/buildroot/package/multimedia/mpg123
2009-01-24 10:15 [Buildroot] svn commit: trunk/buildroot/package/multimedia/mpg123 ulf at uclibc.org
@ 2009-01-24 10:31 ` Peter Korsgaard
2009-01-24 10:57 ` Ulf Samuelsson
2009-01-24 10:37 ` Peter Korsgaard
1 sibling, 1 reply; 9+ messages in thread
From: Peter Korsgaard @ 2009-01-24 10:31 UTC (permalink / raw)
To: buildroot
>>>>> "ulf" == ulf <ulf@uclibc.org> writes:
ulf> Author: ulf
ulf> Date: 2009-01-24 10:15:05 +0000 (Sat, 24 Jan 2009)
ulf> New Revision: 24999
ulf> Log:
ulf> Add fix to mpg123 for bug in ARM release toolchain causing segment violation, bug reported to gcc bugzilla
So the toolchain patch you checked in didn't fix the issue? Should it
then be reverted?
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] svn commit: trunk/buildroot/package/multimedia/mpg123
@ 2009-01-24 10:31 jacmet at uclibc.org
0 siblings, 0 replies; 9+ messages in thread
From: jacmet at uclibc.org @ 2009-01-24 10:31 UTC (permalink / raw)
To: buildroot
Author: jacmet
Date: 2009-01-24 10:31:32 +0000 (Sat, 24 Jan 2009)
New Revision: 25003
Log:
mpg123: remove unused legacy patch
Removed:
trunk/buildroot/package/multimedia/mpg123/mpg123-0.59r-cross.patch
Changeset:
Deleted: trunk/buildroot/package/multimedia/mpg123/mpg123-0.59r-cross.patch
===================================================================
--- trunk/buildroot/package/multimedia/mpg123/mpg123-0.59r-cross.patch 2009-01-24 10:23:00 UTC (rev 25002)
+++ trunk/buildroot/package/multimedia/mpg123/mpg123-0.59r-cross.patch 2009-01-24 10:31:32 UTC (rev 25003)
@@ -1,44 +0,0 @@
-diff -ruN mpg123-0.59r.orig/Makefile mpg123-0.59r/Makefile
---- mpg123-0.59r.orig/Makefile 1999-06-15 22:39:06.000000000 +0200
-+++ mpg123-0.59r/Makefile 2006-12-14 15:52:44.000000000 +0100
-@@ -103,14 +103,14 @@
- mpg123-make
-
- linux:
-- $(MAKE) CC=gcc LDFLAGS= \
-+ $(MAKE) LDFLAGS= \
- OBJECTS='decode_i386.o dct64_i386.o decode_i586.o \
- audio_oss.o term.o' \
- CFLAGS='-DI386_ASSEM -DPENTIUM_OPT -DREAL_IS_FLOAT -DLINUX \
- -DREAD_MMAP -DOSS -DTERM_CONTROL\
-- -Wall -O2 -m486 \
-+ -Wall \
- -fomit-frame-pointer -funroll-all-loops \
-- -finline-functions -ffast-math' \
-+ -finline-functions -ffast-math $(CFLAGS)' \
- mpg123-make
-
- linux-3dnow:
-@@ -246,6 +246,22 @@
- -finline-functions -ffast-math' \
- mpg123-make
-
-+linux-bigend:
-+ $(MAKE) LDFLAGS= OBJECTS='decode.o dct64.o audio_oss.o' \
-+ CFLAGS+='-DREAL_IS_FLOAT -DLINUX -DREAD_MMAP \
-+ -DOSS -DOSS_BIG_ENDIAN -Wall \
-+ -fomit-frame-pointer -funroll-loops \
-+ -finline-functions -ffast-math $(CFLAGS)' \
-+ mpg123-make
-+
-+linux-littleend:
-+ $(MAKE) LDFLAGS= OBJECTS='decode.o dct64.o audio_oss.o' \
-+ CFLAGS='-DREAL_IS_FLOAT -DLINUX -DREAD_MMAP \
-+ -DOSS -Wall \
-+ -fomit-frame-pointer -funroll-loops \
-+ -finline-functions -ffast-math $(CFLAGS)' \
-+ mpg123-make
-+
- linux-sajber:
- @ $(MAKE) FRONTEND=sajberplay-make linux-frontend
-
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] svn commit: trunk/buildroot/package/multimedia/mpg123
2009-01-24 10:15 [Buildroot] svn commit: trunk/buildroot/package/multimedia/mpg123 ulf at uclibc.org
2009-01-24 10:31 ` Peter Korsgaard
@ 2009-01-24 10:37 ` Peter Korsgaard
1 sibling, 0 replies; 9+ messages in thread
From: Peter Korsgaard @ 2009-01-24 10:37 UTC (permalink / raw)
To: buildroot
>>>>> "ulf" == ulf <ulf@uclibc.org> writes:
ulf> Author: ulf
ulf> Date: 2009-01-24 10:15:05 +0000 (Sat, 24 Jan 2009)
ulf> New Revision: 24999
ulf> Log:
ulf> Add fix to mpg123 for bug in ARM release toolchain causing segment violation, bug reported to gcc bugzilla
ulf> Added:
ulf> trunk/buildroot/package/multimedia/mpg123/mpg123-0.66-arm-unroll.patch
ulf> Modified:
ulf> trunk/buildroot/package/multimedia/mpg123/Config.in
ulf> trunk/buildroot/package/multimedia/mpg123/mpg123.mk
And if it is needed, then handle it in the Makefile and don't
introduce a new config symbol for it.
Default values are only taken into consideration if the symbols are
unknown, so with your approach an existing .config will keep on
enabling that workaround if the user changes the gcc version.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] svn commit: trunk/buildroot/package/multimedia/mpg123
2009-01-24 10:31 ` Peter Korsgaard
@ 2009-01-24 10:57 ` Ulf Samuelsson
2009-01-24 11:46 ` Peter Korsgaard
0 siblings, 1 reply; 9+ messages in thread
From: Ulf Samuelsson @ 2009-01-24 10:57 UTC (permalink / raw)
To: buildroot
l?r 2009-01-24 klockan 11:31 +0100 skrev Peter Korsgaard:
> >>>>> "ulf" == ulf <ulf@uclibc.org> writes:
>
> ulf> Author: ulf
> ulf> Date: 2009-01-24 10:15:05 +0000 (Sat, 24 Jan 2009)
> ulf> New Revision: 24999
>
> ulf> Log:
> ulf> Add fix to mpg123 for bug in ARM release toolchain causing segment violation, bug reported to gcc bugzilla
>
> So the toolchain patch you checked in didn't fix the issue? Should it
> then be reverted?
It fixes a similar problem, but apparently not my problem.
Why revert?
do we want really want to run into the problem which it fixes?
BR
Ulf Samuelsson.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] svn commit: trunk/buildroot/package/multimedia/mpg123
2009-01-24 10:57 ` Ulf Samuelsson
@ 2009-01-24 11:46 ` Peter Korsgaard
0 siblings, 0 replies; 9+ messages in thread
From: Peter Korsgaard @ 2009-01-24 11:46 UTC (permalink / raw)
To: buildroot
>>>>> "Ulf" == Ulf Samuelsson <ulf.samuelsson@atmel.com> writes:
Hi,
Ulf> It fixes a similar problem, but apparently not my problem.
Ulf> Why revert?
Ulf> do we want really want to run into the problem which it fixes?
Well, it depends. Where is it from? What problem exactly does it fix?
What is the risk that it breaks something else?
E.G. if it's in the tree for 4.3.3, then that's fine, otherwise we
might want to consider what to do ..
Please mention where patches are from if you didn't create them
yourself in the commit message, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] svn commit: trunk/buildroot/package/multimedia/mpg123
@ 2009-02-05 13:24 jacmet at uclibc.org
0 siblings, 0 replies; 9+ messages in thread
From: jacmet at uclibc.org @ 2009-02-05 13:24 UTC (permalink / raw)
To: buildroot
Author: jacmet
Date: 2009-02-05 13:24:01 +0000 (Thu, 05 Feb 2009)
New Revision: 25246
Log:
mpg123: cleanup after r19300 (don't introduce unneeded hidden configs)
Modified:
trunk/buildroot/package/multimedia/mpg123/Config.in
trunk/buildroot/package/multimedia/mpg123/mpg123.mk
Changeset:
Modified: trunk/buildroot/package/multimedia/mpg123/Config.in
===================================================================
--- trunk/buildroot/package/multimedia/mpg123/Config.in 2009-02-05 12:38:21 UTC (rev 25245)
+++ trunk/buildroot/package/multimedia/mpg123/Config.in 2009-02-05 13:24:01 UTC (rev 25246)
@@ -5,9 +5,3 @@
MPEG 1.0/2.0 layers 1, 2 and 3.
http://www.mpg123.de/
-
-config BR2_PACKAGE_MPG123_ALSA
- bool
- default y
- depends on BR2_PACKAGE_ALSA_LIB
-
Modified: trunk/buildroot/package/multimedia/mpg123/mpg123.mk
===================================================================
--- trunk/buildroot/package/multimedia/mpg123/mpg123.mk 2009-02-05 12:38:21 UTC (rev 25245)
+++ trunk/buildroot/package/multimedia/mpg123/mpg123.mk 2009-02-05 13:24:01 UTC (rev 25246)
@@ -13,7 +13,7 @@
# Check if ALSA is built, then we should configure after alsa-lib so
# ./configure can find alsa-lib.
-ifeq ($(BR2_PACKAGE_MPG123_ALSA),y)
+ifeq ($(BR2_PACKAGE_ALSA_LIB),y)
MPG123_USE_ALSA:=--with-audio=alsa
MPG123_ALSA_DEP:=alsa-lib
endif
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] svn commit: trunk/buildroot/package/multimedia/mpg123
@ 2009-02-05 13:24 jacmet at uclibc.org
0 siblings, 0 replies; 9+ messages in thread
From: jacmet at uclibc.org @ 2009-02-05 13:24 UTC (permalink / raw)
To: buildroot
Author: jacmet
Date: 2009-02-05 13:24:07 +0000 (Thu, 05 Feb 2009)
New Revision: 25247
Log:
mpg123: cleanup unused hunk after r25004
Modified:
trunk/buildroot/package/multimedia/mpg123/mpg123.mk
Changeset:
Modified: trunk/buildroot/package/multimedia/mpg123/mpg123.mk
===================================================================
--- trunk/buildroot/package/multimedia/mpg123/mpg123.mk 2009-02-05 13:24:01 UTC (rev 25246)
+++ trunk/buildroot/package/multimedia/mpg123/mpg123.mk 2009-02-05 13:24:07 UTC (rev 25247)
@@ -18,10 +18,6 @@
MPG123_ALSA_DEP:=alsa-lib
endif
-ifeq ($(BR2_PACKAGE_MPG123_ARM_UNROLL_FIX),y)
-MPG123_ARM_UNROLL_FIX:= -DMPG123_ARM_UNROLL_FIX
-endif
-
$(DL_DIR)/$(MPG123_SOURCE):
$(call DOWNLOAD,$(MPG123_SITE),$(MPG123_SOURCE))
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] svn commit: trunk/buildroot/package/multimedia/mpg123
@ 2009-02-05 13:24 jacmet at uclibc.org
0 siblings, 0 replies; 9+ messages in thread
From: jacmet at uclibc.org @ 2009-02-05 13:24 UTC (permalink / raw)
To: buildroot
Author: jacmet
Date: 2009-02-05 13:24:22 +0000 (Thu, 05 Feb 2009)
New Revision: 25251
Log:
mpg123: remove unused mpg123x target (debug?)
Modified:
trunk/buildroot/package/multimedia/mpg123/mpg123.mk
Changeset:
Modified: trunk/buildroot/package/multimedia/mpg123/mpg123.mk
===================================================================
--- trunk/buildroot/package/multimedia/mpg123/mpg123.mk 2009-02-05 13:24:18 UTC (rev 25250)
+++ trunk/buildroot/package/multimedia/mpg123/mpg123.mk 2009-02-05 13:24:22 UTC (rev 25251)
@@ -55,9 +55,6 @@
mpg123: uclibc $(MPG123_ALSA_DEP) $(TARGET_DIR)/$(MPG123_TARGET_BIN)
-mpg123x:
- touch $(MPG123_DIR)/.configured
-
mpg123-unpacked: $(MPG123_DIR)/.unpacked
mpg123-clean:
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2009-02-05 13:24 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-24 10:15 [Buildroot] svn commit: trunk/buildroot/package/multimedia/mpg123 ulf at uclibc.org
2009-01-24 10:31 ` Peter Korsgaard
2009-01-24 10:57 ` Ulf Samuelsson
2009-01-24 11:46 ` Peter Korsgaard
2009-01-24 10:37 ` Peter Korsgaard
-- strict thread matches above, loose matches on Subject: below --
2009-01-24 10:31 jacmet at uclibc.org
2009-02-05 13:24 jacmet at uclibc.org
2009-02-05 13:24 jacmet at uclibc.org
2009-02-05 13:24 jacmet at uclibc.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox