Re: [Buildroot] [PATCH v2] package/wpa_supplicant: add Smart card option

[Baruch Siach via buildroot <buildroot@buildroot.org>]

Hi Lars,

On Tue, Sep 03 2024, Lars Wikman wrote:
> This was the only initial assignment for DISABLE being made. And now
> it is conditional on the new option. What would be the preferred way
> to do it?
>
> Can DISABLE be left blank? Or left out until it is conditionally set?
>
> Happy to do it either way, it was not obvious to me how it should be
> handled so I did this.

Just remove the initial assignment as you did. No need to initialize to
blank. This is the common convention in Buildroot.

Thanks,
baruch

> On Tue, 3 Sep 2024 at 10:13, Baruch Siach <baruch@tkos.co.il> wrote:
>  On Tue, Sep 03 2024, Lars Wikman wrote:
>  > The existing line was = as it was the first reference to WPA_SUPPLICANT_CONFIG_DISABLE.
>  > So I kept it that way.
>
>  The existing line is first assignment that initializes
>  WPA_SUPPLICANT_CONFIG_DISABLE. All initial assignments use = in this
>  file and others.
>
>  Following conditional assignments should only add to existing value, not
>  overwrite it.
>
>  baruch
>
>  > Happy to change it if I should still. I'm not particularly used to
>  > these files or conventions.
>  >
>  > - Lars
>  >
>  > On Tue, Sep 3, 2024 at 9:51 AM Baruch Siach <baruch@tkos.co.il> wrote:
>  >  On Tue, Sep 03 2024, Lars Wikman wrote:
>  >  > diff --git a/package/wpa_supplicant/wpa_supplicant.mk⚠️⚠️ b/package/wpa_supplicant/wpa_supplicant.mk⚠️⚠️
>  >  > index 984959f679..a7b7800c99 100644
>  >  > --- a/package/wpa_supplicant/wpa_supplicant.mk⚠️⚠️
>  >  > +++ b/package/wpa_supplicant/wpa_supplicant.mk⚠️⚠️
>  >  > @@ -24,8 +24,11 @@ WPA_SUPPLICANT_CONFIG_ENABLE = \
>  >  >       CONFIG_INTERNAL_LIBTOMMATH \
>  >  >       CONFIG_MATCH_IFACE
>  >  >  
>  >  > -WPA_SUPPLICANT_CONFIG_DISABLE = \
>  >  > -     CONFIG_SMARTCARD
>  >  > +ifeq ($(BR2_PACKAGE_WPA_SUPPLICANT_SMARTCARD),y)
>  >  > +WPA_SUPPLICANT_CONFIG_ENABLE += CONFIG_SMARTCARD
>  >  > +else
>  >  > +WPA_SUPPLICANT_CONFIG_DISABLE = CONFIG_SMARTCARD
>  >
>  >  Should be += here. Otherwise WPA_SUPPLICANT_CONFIG_DISABLE is
>  >  overwritten.
>  >
>  >  baruch
>  >
>  >  > +endif
>  >  >  
>  >  >  # libnl-3 needs -lm (for rint) and -lpthread if linking statically
>  >  >  # And library order matters hence stick -lnl-3 first since it's appended

-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot