From: Baruch Siach via buildroot <buildroot@buildroot.org>
To: Lars Wikman <lars@underjord.io>
Cc: Sergey Matyukevich <geomatsi@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2] package/wpa_supplicant: add Smart card option
Date: Tue, 03 Sep 2024 11:13:37 +0300 [thread overview]
Message-ID: <87wmjtgnny.fsf@tarshish> (raw)
In-Reply-To: <CADqW+qn3TnF3LyUaYs3jfMSDT3wMC57q+r3gV0+UoOsxSVKYOA@mail.gmail.com> (Lars Wikman's message of "Tue, 3 Sep 2024 10:00:00 +0200")
Hi Lars,
On Tue, Sep 03 2024, Lars Wikman wrote:
> The existing line was = as it was the first reference to WPA_SUPPLICANT_CONFIG_DISABLE.
> So I kept it that way.
The existing line is first assignment that initializes
WPA_SUPPLICANT_CONFIG_DISABLE. All initial assignments use = in this
file and others.
Following conditional assignments should only add to existing value, not
overwrite it.
baruch
> Happy to change it if I should still. I'm not particularly used to
> these files or conventions.
>
> - Lars
>
> On Tue, Sep 3, 2024 at 9:51 AM Baruch Siach <baruch@tkos.co.il> wrote:
> On Tue, Sep 03 2024, Lars Wikman wrote:
> > diff --git a/package/wpa_supplicant/wpa_supplicant.mk⚠️ b/package/wpa_supplicant/wpa_supplicant.mk⚠️
> > index 984959f679..a7b7800c99 100644
> > --- a/package/wpa_supplicant/wpa_supplicant.mk⚠️
> > +++ b/package/wpa_supplicant/wpa_supplicant.mk⚠️
> > @@ -24,8 +24,11 @@ WPA_SUPPLICANT_CONFIG_ENABLE = \
> > CONFIG_INTERNAL_LIBTOMMATH \
> > CONFIG_MATCH_IFACE
> >
> > -WPA_SUPPLICANT_CONFIG_DISABLE = \
> > - CONFIG_SMARTCARD
> > +ifeq ($(BR2_PACKAGE_WPA_SUPPLICANT_SMARTCARD),y)
> > +WPA_SUPPLICANT_CONFIG_ENABLE += CONFIG_SMARTCARD
> > +else
> > +WPA_SUPPLICANT_CONFIG_DISABLE = CONFIG_SMARTCARD
>
> Should be += here. Otherwise WPA_SUPPLICANT_CONFIG_DISABLE is
> overwritten.
>
> baruch
>
> > +endif
> >
> > # libnl-3 needs -lm (for rint) and -lpthread if linking statically
> > # And library order matters hence stick -lnl-3 first since it's appended
--
~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-09-03 8:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-03 7:39 [Buildroot] [PATCH v2] package/wpa_supplicant: add Smart card option Lars Wikman
2024-09-03 7:51 ` Baruch Siach via buildroot
2024-09-03 8:00 ` Lars Wikman
2024-09-03 8:13 ` Baruch Siach via buildroot [this message]
2024-09-03 8:39 ` Lars Wikman
2024-09-03 8:44 ` Baruch Siach via buildroot
2024-09-03 9:03 ` Lars Wikman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wmjtgnny.fsf@tarshish \
--to=buildroot@buildroot.org \
--cc=baruch@tkos.co.il \
--cc=geomatsi@gmail.com \
--cc=lars@underjord.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox