From: Peter Korsgaard <peter@korsgaard.com>
To: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [Buildroot] [git commit] package/libzenoh-pico: disable on or1k
Date: Thu, 29 Feb 2024 16:20:13 +0100 [thread overview]
Message-ID: <87sf1bguvm.fsf@48ers.dk> (raw)
In-Reply-To: <20240205132229.6521F86C15@busybox.osuosl.org> (Thomas Petazzoni via buildroot's message of "Mon, 5 Feb 2024 14:22:21 +0100")
>>>>> "Thomas" == Thomas Petazzoni via buildroot <buildroot@buildroot.org> writes:
> commit: https://git.buildroot.net/buildroot/commit/?id=ead797bef768a7f3da7a76dd8510eef48181bb6a
> branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master
> The upstream libzenoh-pico code uses asm("nop"), which is completely
> bogus, and actually breaks build on or1k as the instruction does not
> exist.
> In upstream commit
> https://github.com/eclipse-zenoh/zenoh-pico/commit/7d79a14addcea972e801709413f5c9a5226e3ad3
> they made the asm("nop") thing "configurable" with ZP_ASM_NOP, but
> still that requires some special handling for or1k. The whole thing is
> a complete mess, and upstream should have to use any of that. Rather
> than stacking piles of bogus stuff on more bogus stuff, let's simply
> disable this package for or1k for now.
> Thanks a lot to Fabrice for all the investigation, and interaction
> with upstream. See
> https://patchwork.ozlabs.org/project/buildroot/patch/20240110215515.1263859-1-fontaine.fabrice@gmail.com/
> for example.
> Fixes:
> - http://autobuild.buildroot.org/results/fd0b2c666a1dc1537162d15b27743abd270243ed
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Committed to 2023.11.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2024-02-29 15:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-05 13:22 [Buildroot] [git commit] package/libzenoh-pico: disable on or1k Thomas Petazzoni via buildroot
2024-02-29 15:20 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sf1bguvm.fsf@48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@buildroot.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox