[Buildroot] [git commit] package/libzenoh-pico: disable on or1k

[Buildroot] [git commit] package/libzenoh-pico: disable on or1k

[Thomas Petazzoni via buildroot]

commit: https://git.buildroot.net/buildroot/commit/?id=ead797bef768a7f3da7a76dd8510eef48181bb6a
branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master

The upstream libzenoh-pico code uses asm("nop"), which is completely
bogus, and actually breaks build on or1k as the instruction does not
exist.

In upstream commit
https://github.com/eclipse-zenoh/zenoh-pico/commit/7d79a14addcea972e801709413f5c9a5226e3ad3
they made the asm("nop") thing "configurable" with ZP_ASM_NOP, but
still that requires some special handling for or1k. The whole thing is
a complete mess, and upstream should have to use any of that. Rather
than stacking piles of bogus stuff on more bogus stuff, let's simply
disable this package for or1k for now.

Thanks a lot to Fabrice for all the investigation, and interaction
with upstream. See
https://patchwork.ozlabs.org/project/buildroot/patch/20240110215515.1263859-1-fontaine.fabrice@gmail.com/
for example.

Fixes:
 - http://autobuild.buildroot.org/results/fd0b2c666a1dc1537162d15b27743abd270243ed

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
 package/libzenoh-pico/Config.in | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/libzenoh-pico/Config.in b/package/libzenoh-pico/Config.in
index 5f7e91c9f6..9dbb260c52 100644
--- a/package/libzenoh-pico/Config.in
+++ b/package/libzenoh-pico/Config.in
@@ -1,5 +1,8 @@
 config BR2_PACKAGE_LIBZENOH_PICO
 	bool "libzenoh-pico"
+	# upstream hardcodes using asm("nop"), which is bogus and
+	# doesn't work on or1k
+	depends on !BR2_or1k
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	help
 	  zenoh-pico is the Eclipse zenoh implementation that targets
@@ -11,4 +14,5 @@ config BR2_PACKAGE_LIBZENOH_PICO
 	  https://github.com/eclipse-zenoh/zenoh-pico
 
 comment "libzenoh-pico needs a toolchain w/ threads"
+	depends on !BR2_or1k
 	depends on !BR2_TOOLCHAIN_HAS_THREADS
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [git commit] package/libzenoh-pico: disable on or1k

[Peter Korsgaard]

>>>>> "Thomas" == Thomas Petazzoni via buildroot <buildroot@buildroot.org> writes:

 > commit: https://git.buildroot.net/buildroot/commit/?id=ead797bef768a7f3da7a76dd8510eef48181bb6a
 > branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master

 > The upstream libzenoh-pico code uses asm("nop"), which is completely
 > bogus, and actually breaks build on or1k as the instruction does not
 > exist.

 > In upstream commit
 > https://github.com/eclipse-zenoh/zenoh-pico/commit/7d79a14addcea972e801709413f5c9a5226e3ad3
 > they made the asm("nop") thing "configurable" with ZP_ASM_NOP, but
 > still that requires some special handling for or1k. The whole thing is
 > a complete mess, and upstream should have to use any of that. Rather
 > than stacking piles of bogus stuff on more bogus stuff, let's simply
 > disable this package for or1k for now.

 > Thanks a lot to Fabrice for all the investigation, and interaction
 > with upstream. See
 > https://patchwork.ozlabs.org/project/buildroot/patch/20240110215515.1263859-1-fontaine.fabrice@gmail.com/
 > for example.

 > Fixes:
 >  - http://autobuild.buildroot.org/results/fd0b2c666a1dc1537162d15b27743abd270243ed

 > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Committed to 2023.11.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot