[Buildroot] [PATCH 1/1] package/tio: needs threads

[Buildroot] [PATCH 1/1] package/tio: needs threads

[Fabrice Fontaine]

tio needs threads since version 2.4 and
https://github.com/tio/tio/commit/93e6efc00153e625e4ceb8a51e01b324247d312a
resulting in the following build failure since bump to version 2.7 in
commit 4b33d7a47dd41fed5364a398320c2b7d0687ba5e:

In file included from /home/autobuild/autobuild/instance-7/output-1/host/riscv64-buildroot-linux-uclibc/sysroot/usr/include/stdio.h:27,
                 from ../src/tty.c:23:
/home/autobuild/autobuild/instance-7/output-1/host/riscv64-buildroot-linux-uclibc/sysroot/usr/include/features.h:218:5: warning: #warning requested reentrant code, but thread support was disabled [-Wcpp]
  218 | #   warning requested reentrant code, but thread support was disabled
      |     ^~~~~~~
../src/tty.c:43:10: fatal error: pthread.h: No such file or directory
   43 | #include <pthread.h>
      |          ^~~~~~~~~~~

Fixes: 4b33d7a47dd41fed5364a398320c2b7d0687ba5e
 - http://autobuild.buildroot.org/results/9b20ff06a0ad24b7e7f4750ebe64e2077e36164a

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/tio/Config.in | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/package/tio/Config.in b/package/tio/Config.in
index a84daf8a24..e4241fa5e1 100644
--- a/package/tio/Config.in
+++ b/package/tio/Config.in
@@ -1,6 +1,7 @@
 config BR2_PACKAGE_TIO
 	bool "tio"
 	depends on !BR2_sparc64 && !BR2_sparc
+	depends on BR2_TOOLCHAIN_HAS_THREADS
 	select BR2_PACKAGE_INIH
 	help
 	  "tio" is a simple TTY terminal application which features a
@@ -14,3 +15,7 @@ config BR2_PACKAGE_TIO
 # fix or workaround for now
 comment "tio is disabled for sparc and sparc64 architectures"
 	depends on BR2_sparc64 || BR2_sparc
+
+comment "tio needs a toolchain w/ threads"
+	depends on !BR2_sparc64 && !BR2_sparc
+	depends on !BR2_TOOLCHAIN_HAS_THREADS
-- 
2.43.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/tio: needs threads

[Peter Korsgaard]

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > tio needs threads since version 2.4 and
 > https://github.com/tio/tio/commit/93e6efc00153e625e4ceb8a51e01b324247d312a
 > resulting in the following build failure since bump to version 2.7 in
 > commit 4b33d7a47dd41fed5364a398320c2b7d0687ba5e:

 > In file included from /home/autobuild/autobuild/instance-7/output-1/host/riscv64-buildroot-linux-uclibc/sysroot/usr/include/stdio.h:27,
 >                  from ../src/tty.c:23:
 > /home/autobuild/autobuild/instance-7/output-1/host/riscv64-buildroot-linux-uclibc/sysroot/usr/include/features.h:218:5: warning: #warning requested reentrant code, but thread support was disabled [-Wcpp]
 >   218 | #   warning requested reentrant code, but thread support was disabled
 >       |     ^~~~~~~
 > ../src/tty.c:43:10: fatal error: pthread.h: No such file or directory
 >    43 | #include <pthread.h>
 >       |          ^~~~~~~~~~~

 > Fixes: 4b33d7a47dd41fed5364a398320c2b7d0687ba5e
 >  - http://autobuild.buildroot.org/results/9b20ff06a0ad24b7e7f4750ebe64e2077e36164a

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot