[Buildroot] [PATCH v2, 1/1] package/libkrb5: fix BR2_SHARED_STATIC_LIBS build

[Buildroot] [PATCH v2, 1/1] package/libkrb5: fix BR2_SHARED_STATIC_LIBS build

[Fabrice Fontaine]

Fix the following build failure with BR2_SHARED_STATIC_LIBS raised since
the addition of the package in commit
7ae94b51ed5d51fb9fa3f5a931bb8435bcbfaa42 and
https://github.com/krb5/krb5/commit/bd13166a4098198832d921b8e50b97008b714b7b

configure: error: --enable-static must be specified with --disable-shared

Fixes:
 - http://autobuild.buildroot.org/results/dadbf9f77ffdcc4d4e48c6d7e6beb5da303a8074

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
Changes v1 -> v2:
 - Fix patch number

 package/libkrb5/libkrb5.mk | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/package/libkrb5/libkrb5.mk b/package/libkrb5/libkrb5.mk
index d14c464b39..0553e9bdb4 100644
--- a/package/libkrb5/libkrb5.mk
+++ b/package/libkrb5/libkrb5.mk
@@ -37,6 +37,11 @@ LIBKRB5_CONF_OPTS = \
 	--without-tcl \
 	--disable-rpath
 
+# Enabling static and shared at the same time is not supported
+ifeq ($(BR2_SHARED_STATIC_LIBS),y)
+LIBKRB5_CONF_OPTS = --disable-static
+endif
+
 ifeq ($(BR2_PACKAGE_OPENLDAP),y)
 LIBKRB5_CONF_OPTS += --with-ldap
 LIBKRB5_DEPENDENCIES += openldap
-- 
2.35.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2, 1/1] package/libkrb5: fix BR2_SHARED_STATIC_LIBS build

[Arnout Vandecappelle]

On 02/04/2022 15:00, Fabrice Fontaine wrote:
> Fix the following build failure with BR2_SHARED_STATIC_LIBS raised since
> the addition of the package in commit
> 7ae94b51ed5d51fb9fa3f5a931bb8435bcbfaa42 and
> https://github.com/krb5/krb5/commit/bd13166a4098198832d921b8e50b97008b714b7b
> 
> configure: error: --enable-static must be specified with --disable-shared
> 
> Fixes:
>   - http://autobuild.buildroot.org/results/dadbf9f77ffdcc4d4e48c6d7e6beb5da303a8074
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> Changes v1 -> v2:
>   - Fix patch number

  Not really necessary to respin just for that...

> 
>   package/libkrb5/libkrb5.mk | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/package/libkrb5/libkrb5.mk b/package/libkrb5/libkrb5.mk
> index d14c464b39..0553e9bdb4 100644
> --- a/package/libkrb5/libkrb5.mk
> +++ b/package/libkrb5/libkrb5.mk
> @@ -37,6 +37,11 @@ LIBKRB5_CONF_OPTS = \
>   	--without-tcl \
>   	--disable-rpath
>   
> +# Enabling static and shared at the same time is not supported
> +ifeq ($(BR2_SHARED_STATIC_LIBS),y)
> +LIBKRB5_CONF_OPTS = --disable-static
                      +=

  Caught by check-package, fortunately!

  Regards,
  Arnout

> +endif
> +
>   ifeq ($(BR2_PACKAGE_OPENLDAP),y)
>   LIBKRB5_CONF_OPTS += --with-ldap
>   LIBKRB5_DEPENDENCIES += openldap
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2, 1/1] package/libkrb5: fix BR2_SHARED_STATIC_LIBS build

[Peter Korsgaard]

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > Fix the following build failure with BR2_SHARED_STATIC_LIBS raised since
 > the addition of the package in commit
 > 7ae94b51ed5d51fb9fa3f5a931bb8435bcbfaa42 and
 > https://github.com/krb5/krb5/commit/bd13166a4098198832d921b8e50b97008b714b7b

 > configure: error: --enable-static must be specified with --disable-shared

 > Fixes:
 >  - http://autobuild.buildroot.org/results/dadbf9f77ffdcc4d4e48c6d7e6beb5da303a8074

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
 > ---
 > Changes v1 -> v2:
 >  - Fix patch number

Committed to 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot