* [Buildroot] [PATCH 1/1] package/python-aiohttp: add aiosignal runtime dependency
@ 2022-01-01 0:04 James Hilliard
2022-01-01 9:49 ` Yann E. MORIN
2022-01-26 14:36 ` Peter Korsgaard
0 siblings, 2 replies; 5+ messages in thread
From: James Hilliard @ 2022-01-01 0:04 UTC (permalink / raw)
To: buildroot; +Cc: James Hilliard, Asaf Kahlon
Fixes:
File "/usr/lib/python3.10/site-packages/aiohttp/__init__.py", line 6, in <module>
File "/usr/lib/python3.10/site-packages/aiohttp/client.py", line 88, in <module>
File "/usr/lib/python3.10/site-packages/aiohttp/tracing.py", line 5, in <module>
ModuleNotFoundError: No module named 'aiosignal'
Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
---
package/python-aiohttp/Config.in | 1 +
1 file changed, 1 insertion(+)
diff --git a/package/python-aiohttp/Config.in b/package/python-aiohttp/Config.in
index 9ffea088e4..85a6862141 100644
--- a/package/python-aiohttp/Config.in
+++ b/package/python-aiohttp/Config.in
@@ -2,6 +2,7 @@ config BR2_PACKAGE_PYTHON_AIOHTTP
bool "python-aiohttp"
depends on BR2_PACKAGE_PYTHON3
select BR2_PACKAGE_PYTHON_AIODNS # runtime
+ select BR2_PACKAGE_PYTHON_AIOSIGNAL # runtime
select BR2_PACKAGE_PYTHON_ASYNC_TIMEOUT # runtime
select BR2_PACKAGE_PYTHON_ATTRS # runtime
select BR2_PACKAGE_PYTHON_CCHARDET if BR2_INSTALL_LIBSTDCPP # runtime
--
2.25.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/python-aiohttp: add aiosignal runtime dependency
2022-01-01 0:04 [Buildroot] [PATCH 1/1] package/python-aiohttp: add aiosignal runtime dependency James Hilliard
@ 2022-01-01 9:49 ` Yann E. MORIN
2022-01-26 14:36 ` Peter Korsgaard
1 sibling, 0 replies; 5+ messages in thread
From: Yann E. MORIN @ 2022-01-01 9:49 UTC (permalink / raw)
To: James Hilliard; +Cc: Asaf Kahlon, buildroot
James, All,
On 2021-12-31 17:04 -0700, James Hilliard spake thusly:
> Fixes:
> File "/usr/lib/python3.10/site-packages/aiohttp/__init__.py", line 6, in <module>
> File "/usr/lib/python3.10/site-packages/aiohttp/client.py", line 88, in <module>
> File "/usr/lib/python3.10/site-packages/aiohttp/tracing.py", line 5, in <module>
> ModuleNotFoundError: No module named 'aiosignal'
What about a small runtime test to ensure we no longer miss any such
dependency in the future? ;-)
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
Applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> package/python-aiohttp/Config.in | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/package/python-aiohttp/Config.in b/package/python-aiohttp/Config.in
> index 9ffea088e4..85a6862141 100644
> --- a/package/python-aiohttp/Config.in
> +++ b/package/python-aiohttp/Config.in
> @@ -2,6 +2,7 @@ config BR2_PACKAGE_PYTHON_AIOHTTP
> bool "python-aiohttp"
> depends on BR2_PACKAGE_PYTHON3
> select BR2_PACKAGE_PYTHON_AIODNS # runtime
> + select BR2_PACKAGE_PYTHON_AIOSIGNAL # runtime
> select BR2_PACKAGE_PYTHON_ASYNC_TIMEOUT # runtime
> select BR2_PACKAGE_PYTHON_ATTRS # runtime
> select BR2_PACKAGE_PYTHON_CCHARDET if BR2_INSTALL_LIBSTDCPP # runtime
> --
> 2.25.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/python-aiohttp: add aiosignal runtime dependency
2022-01-01 0:04 [Buildroot] [PATCH 1/1] package/python-aiohttp: add aiosignal runtime dependency James Hilliard
2022-01-01 9:49 ` Yann E. MORIN
@ 2022-01-26 14:36 ` Peter Korsgaard
2022-01-26 17:44 ` James Hilliard
1 sibling, 1 reply; 5+ messages in thread
From: Peter Korsgaard @ 2022-01-26 14:36 UTC (permalink / raw)
To: James Hilliard; +Cc: Asaf Kahlon, buildroot
>>>>> "James" == James Hilliard <james.hilliard1@gmail.com> writes:
> Fixes:
> File "/usr/lib/python3.10/site-packages/aiohttp/__init__.py", line 6, in <module>
> File "/usr/lib/python3.10/site-packages/aiohttp/client.py", line 88, in <module>
> File "/usr/lib/python3.10/site-packages/aiohttp/tracing.py", line 5, in <module>
> ModuleNotFoundError: No module named 'aiosignal'
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
When was this introduced? Do we need to backport this to 2021.02.x /
2021.11.x?
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/python-aiohttp: add aiosignal runtime dependency
2022-01-26 14:36 ` Peter Korsgaard
@ 2022-01-26 17:44 ` James Hilliard
2022-01-26 18:36 ` Peter Korsgaard
0 siblings, 1 reply; 5+ messages in thread
From: James Hilliard @ 2022-01-26 17:44 UTC (permalink / raw)
To: Peter Korsgaard; +Cc: Asaf Kahlon, buildroot
On Wed, Jan 26, 2022 at 7:36 AM Peter Korsgaard <peter@korsgaard.com> wrote:
>
> >>>>> "James" == James Hilliard <james.hilliard1@gmail.com> writes:
>
> > Fixes:
> > File "/usr/lib/python3.10/site-packages/aiohttp/__init__.py", line 6, in <module>
> > File "/usr/lib/python3.10/site-packages/aiohttp/client.py", line 88, in <module>
> > File "/usr/lib/python3.10/site-packages/aiohttp/tracing.py", line 5, in <module>
> > ModuleNotFoundError: No module named 'aiosignal'
>
> > Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
>
> When was this introduced? Do we need to backport this to 2021.02.x /
> 2021.11.x?
Looks like it's required for aiohttp v3.8.0 and newer, so we shouldn't
need to backport.
>
> --
> Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/python-aiohttp: add aiosignal runtime dependency
2022-01-26 17:44 ` James Hilliard
@ 2022-01-26 18:36 ` Peter Korsgaard
0 siblings, 0 replies; 5+ messages in thread
From: Peter Korsgaard @ 2022-01-26 18:36 UTC (permalink / raw)
To: James Hilliard; +Cc: Asaf Kahlon, buildroot
>>>>> "James" == James Hilliard <james.hilliard1@gmail.com> writes:
> On Wed, Jan 26, 2022 at 7:36 AM Peter Korsgaard <peter@korsgaard.com> wrote:
>>
>> >>>>> "James" == James Hilliard <james.hilliard1@gmail.com> writes:
>>
>> > Fixes:
>> > File "/usr/lib/python3.10/site-packages/aiohttp/__init__.py", line 6, in <module>
>> > File "/usr/lib/python3.10/site-packages/aiohttp/client.py", line 88, in <module>
>> > File "/usr/lib/python3.10/site-packages/aiohttp/tracing.py", line 5, in <module>
>> > ModuleNotFoundError: No module named 'aiosignal'
>>
>> > Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
>>
>> When was this introduced? Do we need to backport this to 2021.02.x /
>> 2021.11.x?
> Looks like it's required for aiohttp v3.8.0 and newer, so we shouldn't
> need to backport.
Ok, great. It is quite helpful to mention such things in the commit
messages.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-01-26 18:36 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-01 0:04 [Buildroot] [PATCH 1/1] package/python-aiohttp: add aiosignal runtime dependency James Hilliard
2022-01-01 9:49 ` Yann E. MORIN
2022-01-26 14:36 ` Peter Korsgaard
2022-01-26 17:44 ` James Hilliard
2022-01-26 18:36 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox