Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH v2] iputils: new package
@ 2013-09-19 15:17 Matt Weber
  2013-09-19 19:02 ` Peter Korsgaard
  0 siblings, 1 reply; 3+ messages in thread
From: Matt Weber @ 2013-09-19 15:17 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Matt Weber <mlweber1@rockwellcollins.com>
---
Changes v1 -> v2:
  * Updated depends in Config.in and added comment
    (Suggested by Thomas/Arnout)
  * Adjusted version to include "s" as part of version
    (Suggested by Arnout)
  * Removed dependency on file capabilities (libcap)
    and sysfs.  Commented that file capabilities is disabled
  * Cleaned up CFLAGS to have minimal complexity
    (Suggested by Arnout)

 package/Config.in          |    1 +
 package/iputils/Config.in  |    8 ++++++
 package/iputils/iputils.mk |   53 ++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 62 insertions(+), 0 deletions(-)
 create mode 100644 package/iputils/Config.in
 create mode 100644 package/iputils/iputils.mk

diff --git a/package/Config.in b/package/Config.in
index 56c316e..254145a 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -793,6 +793,7 @@ source "package/iproute2/Config.in"
 source "package/ipsec-tools/Config.in"
 source "package/ipset/Config.in"
 source "package/iptables/Config.in"
+source "package/iputils/Config.in"
 source "package/iw/Config.in"
 source "package/kismet/Config.in"
 source "package/knock/Config.in"
diff --git a/package/iputils/Config.in b/package/iputils/Config.in
new file mode 100644
index 0000000..0c77b5f
--- /dev/null
+++ b/package/iputils/Config.in
@@ -0,0 +1,9 @@
+config BR2_PACKAGE_IPUTILS
+	bool "iputils"
+	select BR2_OPENSSL if BR2_INET_IPV6
+	help
+	  This package is set of small useful utilities for Linux networking.
+	  It includes complete versions of ping, traceroute, etc.
+
+	  http://sourceforge.net/projects/iputils/
diff --git a/package/iputils/iputils.mk b/package/iputils/iputils.mk
new file mode 100644
index 0000000..5836430
--- /dev/null
+++ b/package/iputils/iputils.mk
@@ -0,0 +1,53 @@
+################################################################################
+#
+# iputils
+#
+################################################################################
+
+IPUTILS_VERSION = s20121011
+IPUTILS_SITE = http://www.skbuff.net/iputils/
+IPUTILS_SOURCE = iputils-$(IPUTILS_VERSION).tar.bz2
+IPUTILS_LICENSE = GPLv2+ BSD-3c
+# Only included a license file for BSD.
+IPUTILS_LICENSE_FILES = COPYING
+
+# Build after busybox so target ends up with this package's full
+# versions of the applications instead of busybox applets.
+ifeq ($(BR2_PACKAGE_BUSYBOX),y)
+IPUTILS_DEPENDENCIES += busybox
+endif
+
+# Disabling CAP_SETPCAP (file capabilities)
+IPUTILS_MAKE_OPT = $(TARGET_CONFIGURE_OPTS) USE_CAP=no USE_SYSFS=no\
+	CFLAGS="$(TARGET_CFLAGS) -D_GNU_SOURCE" \
+	arping clockdiff ping rarpd rdisc tftpd tracepath
+
+ifeq ($(BR2_INET_IPV6),y)
+# To support md5 for ping6
+IPUTILS_DEPENDENCIES += openssl
+
+IPUTILS_MAKE_OPT += ping6 tracepath6 traceroute6
+
+define IPUTILS_IPV6_INSTALL_TARGET_CMDS
+	$(INSTALL) -D -m 755 $(@D)/ping6       $(TARGET_DIR)/bin/ping6
+	$(INSTALL) -D -m 755 $(@D)/tracepath6  $(TARGET_DIR)/bin/tracepath6
+	$(INSTALL) -D -m 755 $(@D)/traceroute6 $(TARGET_DIR)/bin/traceroute6
+endef
+endif
+
+define IPUTILS_BUILD_CMDS
+	$(MAKE) -C $(@D) $(IPUTILS_MAKE_OPT)
+endef
+
+define IPUTILS_INSTALL_TARGET_CMDS
+	$(INSTALL) -D -m 755 $(@D)/arping      $(TARGET_DIR)/sbin/arping
+	$(INSTALL) -D -m 755 $(@D)/clockdiff   $(TARGET_DIR)/bin/clockdiff
+	$(INSTALL) -D -m 755 $(@D)/ping        $(TARGET_DIR)/bin/ping
+	$(INSTALL) -D -m 755 $(@D)/rarpd       $(TARGET_DIR)/sbin/rarpd
+	$(INSTALL) -D -m 755 $(@D)/rdisc       $(TARGET_DIR)/sbin/rdisc
+	$(INSTALL) -D -m 755 $(@D)/tftpd       $(TARGET_DIR)/usr/sbin/in.tftpd
+	$(INSTALL) -D -m 755 $(@D)/tracepath   $(TARGET_DIR)/bin/tracepath
+	$(IPUTILS_IPV6_INSTALL_TARGET_CMDS)
+endef
+
+$(eval $(generic-package))
-- 
1.7.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH v2] iputils: new package
  2013-09-19 15:17 [Buildroot] [PATCH v2] iputils: new package Matt Weber
@ 2013-09-19 19:02 ` Peter Korsgaard
  2013-09-19 19:52   ` mlweber1 at rockwellcollins.com
  0 siblings, 1 reply; 3+ messages in thread
From: Peter Korsgaard @ 2013-09-19 19:02 UTC (permalink / raw)
  To: buildroot

>>>>> "Matt" == Matt Weber <mlweber1@rockwellcollins.com> writes:

 Matt> Signed-off-by: Matt Weber <mlweber1@rockwellcollins.com>
 Matt> ---
 Matt> Changes v1 -> v2:
 Matt>   * Updated depends in Config.in and added comment
 Matt>     (Suggested by Thomas/Arnout)
 Matt>   * Adjusted version to include "s" as part of version
 Matt>     (Suggested by Arnout)
 Matt>   * Removed dependency on file capabilities (libcap)
 Matt>     and sysfs.  Commented that file capabilities is disabled
 Matt>   * Cleaned up CFLAGS to have minimal complexity
 Matt>     (Suggested by Arnout)

 Matt>  package/Config.in          |    1 +
 Matt>  package/iputils/Config.in  |    8 ++++++
 Matt>  package/iputils/iputils.mk |   53 ++++++++++++++++++++++++++++++++++++++++++++
 Matt>  3 files changed, 62 insertions(+), 0 deletions(-)
 Matt>  create mode 100644 package/iputils/Config.in
 Matt>  create mode 100644 package/iputils/iputils.mk

 Matt> diff --git a/package/iputils/Config.in b/package/iputils/Config.in
 Matt> new file mode 100644
 Matt> index 0000000..0c77b5f
 Matt> --- /dev/null
 Matt> +++ b/package/iputils/Config.in
 Matt> @@ -0,0 +1,9 @@
 Matt> +config BR2_PACKAGE_IPUTILS
 Matt> +	bool "iputils"
 Matt> +	select BR2_OPENSSL if BR2_INET_IPV6
 Matt> +	help
 Matt> +	  This package is set of small useful utilities for Linux networking.
 Matt> +	  It includes complete versions of ping, traceroute, etc.
 Matt> +
 Matt> +	  http://sourceforge.net/projects/iputils/

Something apparently corrupted the patch on the way, as you only have 8
lines here. Did you edit the patch by hand afterwards?

 Matt> diff --git a/package/iputils/iputils.mk b/package/iputils/iputils.mk
 Matt> new file mode 100644
 Matt> index 0000000..5836430
 Matt> --- /dev/null
 Matt> +++ b/package/iputils/iputils.mk
 Matt> @@ -0,0 +1,53 @@
 Matt> +################################################################################
 Matt> +#
 Matt> +# iputils
 Matt> +#
 Matt> +################################################################################
 Matt> +
 Matt> +IPUTILS_VERSION = s20121011
 Matt> +IPUTILS_SITE = http://www.skbuff.net/iputils/
 Matt> +IPUTILS_SOURCE = iputils-$(IPUTILS_VERSION).tar.bz2
 Matt> +IPUTILS_LICENSE = GPLv2+ BSD-3c
 Matt> +# Only included a license file for BSD.
 Matt> +IPUTILS_LICENSE_FILES = COPYING

There's no COPYING. I assume you meant ninfod/COPYING?

Committed with this fixed, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH v2] iputils: new package
  2013-09-19 19:02 ` Peter Korsgaard
@ 2013-09-19 19:52   ` mlweber1 at rockwellcollins.com
  0 siblings, 0 replies; 3+ messages in thread
From: mlweber1 at rockwellcollins.com @ 2013-09-19 19:52 UTC (permalink / raw)
  To: buildroot

Peter Korsgaard <jacmet@gmail.com> wrote on 09/19/2013 02:02:17 PM:

> From: Peter Korsgaard <jacmet@uclibc.org>
> To: Matt Weber <mlweber1@rockwellcollins.com>
> Cc: buildroot at busybox.net
> Date: 09/19/2013 02:02 PM
> Subject: Re: [PATCH v2] iputils: new package
> Sent by: Peter Korsgaard <jacmet@gmail.com>
> 
> >>>>> "Matt" == Matt Weber <mlweber1@rockwellcollins.com> writes:
> 
>  Matt> Signed-off-by: Matt Weber <mlweber1@rockwellcollins.com>
>  Matt> ---
>  Matt> Changes v1 -> v2:
>  Matt>   * Updated depends in Config.in and added comment
>  Matt>     (Suggested by Thomas/Arnout)
>  Matt>   * Adjusted version to include "s" as part of version
>  Matt>     (Suggested by Arnout)
>  Matt>   * Removed dependency on file capabilities (libcap)
>  Matt>     and sysfs.  Commented that file capabilities is disabled
>  Matt>   * Cleaned up CFLAGS to have minimal complexity
>  Matt>     (Suggested by Arnout)
> 
>  Matt>  package/Config.in          |    1 +
>  Matt>  package/iputils/Config.in  |    8 ++++++
>  Matt>  package/iputils/iputils.mk |   53 ++++++++++++++++++++++++++
> ++++++++++++++++++
>  Matt>  3 files changed, 62 insertions(+), 0 deletions(-)
>  Matt>  create mode 100644 package/iputils/Config.in
>  Matt>  create mode 100644 package/iputils/iputils.mk
> 
>  Matt> diff --git a/package/iputils/Config.in 
b/package/iputils/Config.in
>  Matt> new file mode 100644
>  Matt> index 0000000..0c77b5f
>  Matt> --- /dev/null
>  Matt> +++ b/package/iputils/Config.in
>  Matt> @@ -0,0 +1,9 @@
>  Matt> +config BR2_PACKAGE_IPUTILS
>  Matt> +   bool "iputils"
>  Matt> +   select BR2_OPENSSL if BR2_INET_IPV6
>  Matt> +   help
>  Matt> +     This package is set of small useful utilities for Linux
> networking.
>  Matt> +     It includes complete versions of ping, traceroute, etc.
>  Matt> +
>  Matt> +     http://sourceforge.net/projects/iputils/
> 
> Something apparently corrupted the patch on the way, as you only have 8
> lines here. Did you edit the patch by hand afterwards?

Yep, sorry about that, I should have made the change to the actual file 
and regenerated the patch.

> 
>  Matt> diff --git a/package/iputils/iputils.mk 
b/package/iputils/iputils.mk
>  Matt> new file mode 100644
>  Matt> index 0000000..5836430
>  Matt> --- /dev/null
>  Matt> +++ b/package/iputils/iputils.mk
>  Matt> @@ -0,0 +1,53 @@
>  Matt> 
> 
+################################################################################
>  Matt> +#
>  Matt> +# iputils
>  Matt> +#
>  Matt> 
> 
+################################################################################
>  Matt> +
>  Matt> +IPUTILS_VERSION = s20121011
>  Matt> +IPUTILS_SITE = http://www.skbuff.net/iputils/
>  Matt> +IPUTILS_SOURCE = iputils-$(IPUTILS_VERSION).tar.bz2
>  Matt> +IPUTILS_LICENSE = GPLv2+ BSD-3c
>  Matt> +# Only included a license file for BSD.
>  Matt> +IPUTILS_LICENSE_FILES = COPYING
> 
> There's no COPYING. I assume you meant ninfod/COPYING?

Yep

Thanks,
Matt

[snip]
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20130919/08eb9bdc/attachment.html>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-09-19 19:52 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-19 15:17 [Buildroot] [PATCH v2] iputils: new package Matt Weber
2013-09-19 19:02 ` Peter Korsgaard
2013-09-19 19:52   ` mlweber1 at rockwellcollins.com

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox