Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] libfreefare: add missing openssl dependency
@ 2012-06-17  9:07 spdawson at gmail.com
  2012-06-17 10:20 ` Peter Korsgaard
  0 siblings, 1 reply; 4+ messages in thread
From: spdawson at gmail.com @ 2012-06-17  9:07 UTC (permalink / raw)
  To: buildroot

From: Simon Dawson <spdawson@gmail.com>

If openssl is not selected, configuration fails for the libfreefare package
as follows.

  configure: error: Cannot find libcrypto.

This patch adds the missing dependency on openssl.

Signed-off-by: Simon Dawson <spdawson@gmail.com>
---
 package/libfreefare/Config.in      |    4 ++++
 package/libfreefare/libfreefare.mk |    2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/package/libfreefare/Config.in b/package/libfreefare/Config.in
index 2e11f7e..438bcbf 100644
--- a/package/libfreefare/Config.in
+++ b/package/libfreefare/Config.in
@@ -1,7 +1,11 @@
 config BR2_PACKAGE_LIBFREEFARE
 	bool "libfreefare"
+	depends on BR2_PACKAGE_OPENSSL
 	select BR2_PACKAGE_LIBNFC
 	help
 	  Library for high level manipulation of MIFARE cards.
 
 	  http://code.google.com/p/nfc-tools/wiki/libfreefare
+
+comment "libfreefare requires openssl"
+	depends on !BR2_PACKAGE_OPENSSL
diff --git a/package/libfreefare/libfreefare.mk b/package/libfreefare/libfreefare.mk
index 0499999..16ef8fb 100644
--- a/package/libfreefare/libfreefare.mk
+++ b/package/libfreefare/libfreefare.mk
@@ -5,6 +5,6 @@
 #############################################################
 LIBFREEFARE_VERSION = 0.3.2
 LIBFREEFARE_SITE = http://nfc-tools.googlecode.com/files
-LIBFREEFARE_DEPENDENCIES = libnfc
+LIBFREEFARE_DEPENDENCIES = libnfc openssl
 
 $(eval $(call AUTOTARGETS))
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH] libfreefare: add missing openssl dependency
  2012-06-17  9:07 [Buildroot] [PATCH] libfreefare: add missing openssl dependency spdawson at gmail.com
@ 2012-06-17 10:20 ` Peter Korsgaard
  2012-06-17 10:30   ` Baruch Siach
  0 siblings, 1 reply; 4+ messages in thread
From: Peter Korsgaard @ 2012-06-17 10:20 UTC (permalink / raw)
  To: buildroot

>>>>> "spdawson" == spdawson  <spdawson@gmail.com> writes:

 spdawson> From: Simon Dawson <spdawson@gmail.com>
 spdawson> If openssl is not selected, configuration fails for the libfreefare package
 spdawson> as follows.

 spdawson>   configure: error: Cannot find libcrypto.

 spdawson> This patch adds the missing dependency on openssl.

 spdawson> Signed-off-by: Simon Dawson <spdawson@gmail.com>
 spdawson> ---
 spdawson>  package/libfreefare/Config.in      |    4 ++++
 spdawson>  package/libfreefare/libfreefare.mk |    2 +-
 spdawson>  2 files changed, 5 insertions(+), 1 deletion(-)

 spdawson> diff --git a/package/libfreefare/Config.in b/package/libfreefare/Config.in
 spdawson> index 2e11f7e..438bcbf 100644
 spdawson> --- a/package/libfreefare/Config.in
 spdawson> +++ b/package/libfreefare/Config.in
 spdawson> @@ -1,7 +1,11 @@
 spdawson>  config BR2_PACKAGE_LIBFREEFARE
 spdawson>  	bool "libfreefare"
 spdawson> +	depends on BR2_PACKAGE_OPENSSL

We normally use 'depends on' for library dependencies (like libnfc), so
I've changed that and committed, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH] libfreefare: add missing openssl dependency
  2012-06-17 10:20 ` Peter Korsgaard
@ 2012-06-17 10:30   ` Baruch Siach
  2012-06-17 12:10     ` Peter Korsgaard
  0 siblings, 1 reply; 4+ messages in thread
From: Baruch Siach @ 2012-06-17 10:30 UTC (permalink / raw)
  To: buildroot

Hi Peter,

On Sun, Jun 17, 2012 at 12:20:03PM +0200, Peter Korsgaard wrote:
> >>>>> "spdawson" == spdawson  <spdawson@gmail.com> writes:
> 
>  spdawson> From: Simon Dawson <spdawson@gmail.com>
>  spdawson> If openssl is not selected, configuration fails for the libfreefare package
>  spdawson> as follows.
> 
>  spdawson>   configure: error: Cannot find libcrypto.
> 
>  spdawson> This patch adds the missing dependency on openssl.
> 
>  spdawson> Signed-off-by: Simon Dawson <spdawson@gmail.com>
>  spdawson> ---
>  spdawson>  package/libfreefare/Config.in      |    4 ++++
>  spdawson>  package/libfreefare/libfreefare.mk |    2 +-
>  spdawson>  2 files changed, 5 insertions(+), 1 deletion(-)
> 
>  spdawson> diff --git a/package/libfreefare/Config.in b/package/libfreefare/Config.in
>  spdawson> index 2e11f7e..438bcbf 100644
>  spdawson> --- a/package/libfreefare/Config.in
>  spdawson> +++ b/package/libfreefare/Config.in
>  spdawson> @@ -1,7 +1,11 @@
>  spdawson>  config BR2_PACKAGE_LIBFREEFARE
>  spdawson>  	bool "libfreefare"
>  spdawson> +	depends on BR2_PACKAGE_OPENSSL
> 
> We normally use 'depends on' for library dependencies (like libnfc), so
> I've changed that and committed, thanks.

s/depends on/select/

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH] libfreefare: add missing openssl dependency
  2012-06-17 10:30   ` Baruch Siach
@ 2012-06-17 12:10     ` Peter Korsgaard
  0 siblings, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2012-06-17 12:10 UTC (permalink / raw)
  To: buildroot

>>>>> "Baruch" == Baruch Siach <baruch@tkos.co.il> writes:

 spdawson> config BR2_PACKAGE_LIBFREEFARE
 spdawson> bool "libfreefare"
 spdawson> +	depends on BR2_PACKAGE_OPENSSL
 >> 
 >> We normally use 'depends on' for library dependencies (like libnfc), so
 >> I've changed that and committed, thanks.

 Baruch> s/depends on/select/

Yes ;)

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2012-06-17 12:10 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-17  9:07 [Buildroot] [PATCH] libfreefare: add missing openssl dependency spdawson at gmail.com
2012-06-17 10:20 ` Peter Korsgaard
2012-06-17 10:30   ` Baruch Siach
2012-06-17 12:10     ` Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox