Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] pkg-download.mk: Add missing argument when downloading from primary mirror (scp)
@ 2012-05-23 19:30 Thomas De Schampheleire
  2012-05-23 19:41 ` Thomas De Schampheleire
  2012-05-23 19:50 ` Peter Korsgaard
  0 siblings, 2 replies; 3+ messages in thread
From: Thomas De Schampheleire @ 2012-05-23 19:30 UTC (permalink / raw)
  To: buildroot

This problem was already fixed by Markos Chandras for wget, but not for scp.

Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>

---
 package/pkg-download.mk |  2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/package/pkg-download.mk b/package/pkg-download.mk
--- a/package/pkg-download.mk
+++ b/package/pkg-download.mk
@@ -206,7 +206,7 @@ endef
 define DOWNLOAD_INNER
 	$(Q)if test -n "$(call qstrip,$(BR2_PRIMARY_SITE))" ; then \
 		case "$(call geturischeme,$(BR2_PRIMARY_SITE))" in \
-			scp) $(call $(DL_MODE)_SCP,$(BR2_PRIMARY_SITE),$(2)) && exit ;; \
+			scp) $(call $(DL_MODE)_SCP,$(BR2_PRIMARY_SITE)/$(2),$(2)) && exit ;; \
 			*) $(call $(DL_MODE)_WGET,$(BR2_PRIMARY_SITE)/$(2),$(2)) && exit ;; \
 		esac ; \
 	fi ; \

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] pkg-download.mk: Add missing argument when downloading from primary mirror (scp)
  2012-05-23 19:30 [Buildroot] [PATCH] pkg-download.mk: Add missing argument when downloading from primary mirror (scp) Thomas De Schampheleire
@ 2012-05-23 19:41 ` Thomas De Schampheleire
  2012-05-23 19:50 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas De Schampheleire @ 2012-05-23 19:41 UTC (permalink / raw)
  To: buildroot

Hi,

On Wed, May 23, 2012 at 9:30 PM, Thomas De Schampheleire
<patrickdepinguin+buildroot@gmail.com> wrote:
> This problem was already fixed by Markos Chandras for wget, but not for scp.
>
> Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
>
> ---
> ?package/pkg-download.mk | ?2 +-
> ?1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/package/pkg-download.mk b/package/pkg-download.mk
> --- a/package/pkg-download.mk
> +++ b/package/pkg-download.mk
> @@ -206,7 +206,7 @@ endef
> ?define DOWNLOAD_INNER
> ? ? ? ?$(Q)if test -n "$(call qstrip,$(BR2_PRIMARY_SITE))" ; then \
> ? ? ? ? ? ? ? ?case "$(call geturischeme,$(BR2_PRIMARY_SITE))" in \
> - ? ? ? ? ? ? ? ? ? ? ? scp) $(call $(DL_MODE)_SCP,$(BR2_PRIMARY_SITE),$(2)) && exit ;; \
> + ? ? ? ? ? ? ? ? ? ? ? scp) $(call $(DL_MODE)_SCP,$(BR2_PRIMARY_SITE)/$(2),$(2)) && exit ;; \
> ? ? ? ? ? ? ? ? ? ? ? ?*) $(call $(DL_MODE)_WGET,$(BR2_PRIMARY_SITE)/$(2),$(2)) && exit ;; \
> ? ? ? ? ? ? ? ?esac ; \
> ? ? ? ?fi ; \

Since this is a regression (worked fine in 2012.02) I think this fix
should be in 2012.05.

Best regards,
Thomas

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] pkg-download.mk: Add missing argument when downloading from primary mirror (scp)
  2012-05-23 19:30 [Buildroot] [PATCH] pkg-download.mk: Add missing argument when downloading from primary mirror (scp) Thomas De Schampheleire
  2012-05-23 19:41 ` Thomas De Schampheleire
@ 2012-05-23 19:50 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2012-05-23 19:50 UTC (permalink / raw)
  To: buildroot

>>>>> "Thomas" == Thomas De Schampheleire <patrickdepinguin+buildroot@gmail.com> writes:

 Thomas> This problem was already fixed by Markos Chandras for wget, but
 Thomas> not for scp.

 Thomas> Signed-off-by: Thomas De Schampheleire
 Thomas> <thomas.de.schampheleire@gmail.com>

Committed, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-05-23 19:50 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-23 19:30 [Buildroot] [PATCH] pkg-download.mk: Add missing argument when downloading from primary mirror (scp) Thomas De Schampheleire
2012-05-23 19:41 ` Thomas De Schampheleire
2012-05-23 19:50 ` Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox