[Buildroot] [git commit] usbmount: depend on udev rather than selecting it

[Buildroot] [git commit] usbmount: depend on udev rather than selecting it

[Peter Korsgaard]

commit: http://git.buildroot.net/buildroot/commit/?id=1c1009d38d20885e7543da7e9af45a8265051311
branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master

udev is much more than a library, so we shouldn't use select to silently
enable it.

Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
---
 package/usbmount/Config.in |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/usbmount/Config.in b/package/usbmount/Config.in
index 6980c8c..30c7b5a 100644
--- a/package/usbmount/Config.in
+++ b/package/usbmount/Config.in
@@ -2,7 +2,7 @@ config BR2_PACKAGE_USBMOUNT
 	bool "usbmount"
 	depends on BR2_LARGEFILE # util-linux
 	depends on BR2_USE_WCHAR # util-linux
-	select BR2_PACKAGE_UDEV
+	depends on BR2_PACKAGE_UDEV
 	select BR2_PACKAGE_LOCKFILE_PROGS
 	select BR2_PACKAGE_UTIL_LINUX
 	select BR2_PACKAGE_UTIL_LINUX_LIBBLKID
@@ -13,4 +13,4 @@ config BR2_PACKAGE_USBMOUNT
 	  http://usbmount.alioth.debian.org/
 
 comment "usbmount requires a toolchain with LARGEFILE + WCHAR support"
-	depends on !(BR2_LARGEFILE && BR2_USE_WCHAR)
+	depends on !(BR2_LARGEFILE && BR2_USE_WCHAR) && BR2_PACKAGE_UDEV
-- 
1.7.3.4

[Buildroot] [git commit] usbmount: depend on udev rather than selecting it

[Baruch Siach]

Hi Peter,

On Mon, Aug 15, 2011 at 02:09:57PM +0200, Peter Korsgaard wrote:
> diff --git a/package/usbmount/Config.in b/package/usbmount/Config.in
> index 6980c8c..30c7b5a 100644
> --- a/package/usbmount/Config.in
> +++ b/package/usbmount/Config.in
> @@ -2,7 +2,7 @@ config BR2_PACKAGE_USBMOUNT
>  	bool "usbmount"
>  	depends on BR2_LARGEFILE # util-linux
>  	depends on BR2_USE_WCHAR # util-linux
> -	select BR2_PACKAGE_UDEV
> +	depends on BR2_PACKAGE_UDEV
>  	select BR2_PACKAGE_LOCKFILE_PROGS
>  	select BR2_PACKAGE_UTIL_LINUX
>  	select BR2_PACKAGE_UTIL_LINUX_LIBBLKID
> @@ -13,4 +13,4 @@ config BR2_PACKAGE_USBMOUNT
>  	  http://usbmount.alioth.debian.org/
>  
>  comment "usbmount requires a toolchain with LARGEFILE + WCHAR support"
> -	depends on !(BR2_LARGEFILE && BR2_USE_WCHAR)
> +	depends on !(BR2_LARGEFILE && BR2_USE_WCHAR) && BR2_PACKAGE_UDEV

Shouldn't the comment text be updated to indicate the udev dependency?

baruch

-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

[Buildroot] [git commit] usbmount: depend on udev rather than selecting it

[Peter Korsgaard]

>>>>> "Baruch" == Baruch Siach <baruch@tkos.co.il> writes:

 >> comment "usbmount requires a toolchain with LARGEFILE + WCHAR support"
 >> -	depends on !(BR2_LARGEFILE && BR2_USE_WCHAR)
 >> +	depends on !(BR2_LARGEFILE && BR2_USE_WCHAR) && BR2_PACKAGE_UDEV

 Baruch> Shouldn't the comment text be updated to indicate the udev dependency?

Well, we could - but we normally only show those comment lines for
toolchain dependencies  - E.G. you don't see 100s of comments for each
X11-related package if you haven't enabled Xorg.

udev is just above usbmount as well.

-- 
Bye, Peter Korsgaard