Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] dropbear: Create destination directories before use in install stage.
Date: Fri, 22 Jul 2011 13:34:15 +0200	[thread overview]
Message-ID: <87sjpyy2fc.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <1311332746-8143-1-git-send-email-quotientvremainder@gmail.com> (Quotient Remainder's message of "Fri, 22 Jul 2011 12:05:46 +0100")

>>>>> "Quotient" == Quotient Remainder <quotientvremainder@gmail.com> writes:

 Quotient> Signed-off-by: Quotient Remainder <quotientvremainder@gmail.com>

Real name please.

 Quotient> ---
 Quotient>  package/dropbear/dropbear.mk |    1 +
 Quotient>  1 files changed, 1 insertions(+), 0 deletions(-)

 Quotient> diff --git a/package/dropbear/dropbear.mk b/package/dropbear/dropbear.mk
 Quotient> index 6ef5dec..2127096 100644
 Quotient> --- a/package/dropbear/dropbear.mk
 Quotient> +++ b/package/dropbear/dropbear.mk
 Quotient> @@ -47,6 +47,7 @@ DROPBEAR_DEPENDENCIES += zlib
 Quotient>  endif
 
 Quotient>  define DROPBEAR_INSTALL_TARGET_CMDS
 Quotient> +	mkdir -p $(TARGET_DIR)/usr/bin $(TARGET_DIR)/usr/sbin
 Quotient>  	$(INSTALL) -m 755 $(@D)/dropbearmulti $(TARGET_DIR)/usr/sbin/dropbear

I would prefer to use install -D like elsewhere to ensure usr/sbin is
created, and then move the mkdir -p just above the _TARGET_BINS loop.

 Quotient>  	for f in $(DROPBEAR_TARGET_BINS); do \
 Quotient>  		ln -snf ../sbin/dropbear $(TARGET_DIR)/usr/bin/$$f ; \
 Quotient> -- 

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2011-07-22 11:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-22 11:05 [Buildroot] [PATCH] dropbear: Create destination directories before use in install stage Quotient Remainder
2011-07-22 11:34 ` Peter Korsgaard [this message]
2011-07-22 15:33   ` Quotient Remainder
2011-07-23  9:48     ` Peter Korsgaard
2011-07-22 15:49 ` [Buildroot] [PATCH v2] " Quotient Remainder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sjpyy2fc.fsf@macbook.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox