[Buildroot] [PATCH] dropbear: Create destination directories before use in install stage.

[Buildroot] [PATCH] dropbear: Create destination directories before use in install stage.

[Quotient Remainder]

Signed-off-by: Quotient Remainder <quotientvremainder@gmail.com>
---
 package/dropbear/dropbear.mk |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/package/dropbear/dropbear.mk b/package/dropbear/dropbear.mk
index 6ef5dec..2127096 100644
--- a/package/dropbear/dropbear.mk
+++ b/package/dropbear/dropbear.mk
@@ -47,6 +47,7 @@ DROPBEAR_DEPENDENCIES += zlib
 endif
 
 define DROPBEAR_INSTALL_TARGET_CMDS
+	mkdir -p $(TARGET_DIR)/usr/bin $(TARGET_DIR)/usr/sbin
 	$(INSTALL) -m 755 $(@D)/dropbearmulti $(TARGET_DIR)/usr/sbin/dropbear
 	for f in $(DROPBEAR_TARGET_BINS); do \
 		ln -snf ../sbin/dropbear $(TARGET_DIR)/usr/bin/$$f ; \
-- 
1.7.6

[Buildroot] [PATCH] dropbear: Create destination directories before use in install stage.

[Peter Korsgaard]

>>>>> "Quotient" == Quotient Remainder <quotientvremainder@gmail.com> writes:

 Quotient> Signed-off-by: Quotient Remainder <quotientvremainder@gmail.com>

Real name please.

 Quotient> ---
 Quotient>  package/dropbear/dropbear.mk |    1 +
 Quotient>  1 files changed, 1 insertions(+), 0 deletions(-)

 Quotient> diff --git a/package/dropbear/dropbear.mk b/package/dropbear/dropbear.mk
 Quotient> index 6ef5dec..2127096 100644
 Quotient> --- a/package/dropbear/dropbear.mk
 Quotient> +++ b/package/dropbear/dropbear.mk
 Quotient> @@ -47,6 +47,7 @@ DROPBEAR_DEPENDENCIES += zlib
 Quotient>  endif
 
 Quotient>  define DROPBEAR_INSTALL_TARGET_CMDS
 Quotient> +	mkdir -p $(TARGET_DIR)/usr/bin $(TARGET_DIR)/usr/sbin
 Quotient>  	$(INSTALL) -m 755 $(@D)/dropbearmulti $(TARGET_DIR)/usr/sbin/dropbear

I would prefer to use install -D like elsewhere to ensure usr/sbin is
created, and then move the mkdir -p just above the _TARGET_BINS loop.

 Quotient>  	for f in $(DROPBEAR_TARGET_BINS); do \
 Quotient>  		ln -snf ../sbin/dropbear $(TARGET_DIR)/usr/bin/$$f ; \
 Quotient> -- 

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH] dropbear: Create destination directories before use in install stage.

[Quotient Remainder]

Peter,

On Fri, 2011-07-22 at 13:34 +0200, Peter Korsgaard wrote:
>  Quotient> Signed-off-by: Quotient Remainder <quotientvremainder@gmail.com>
> 
> Real name please.

I accept fully that as the lead developer on BR you're free to choose
and enforce any set of rules as you see fit.  However, contributions
under pseudonyms have long been a part of Internet culture.  Isn't that
name just as valid as any other less suspicious-looking (but equally
unverified) names that are on any other patches?
Will you insist on this real name policy?

> I would prefer to use install -D like elsewhere to ensure usr/sbin is
> created, and then move the mkdir -p just above the _TARGET_BINS loop.

OK, v2 on the way.

[Buildroot] [PATCH] dropbear: Create destination directories before use in install stage.

[Peter Korsgaard]

>>>>> "Quotient" == Quotient Remainder <quotientvremainder@gmail.com> writes:

 >> Real name please.

 Quotient> I accept fully that as the lead developer on BR you're free
 Quotient> to choose and enforce any set of rules as you see fit.
 Quotient> However, contributions under pseudonyms have long been a part
 Quotient> of Internet culture.  Isn't that name just as valid as any
 Quotient> other less suspicious-looking (but equally unverified) names
 Quotient> that are on any other patches?  Will you insist on this real
 Quotient> name policy?

I'm afraid so. Signed-off-by's don't make any sense if they are clearly
made up names. I agree that we cannot ensure that people don't make up
names, but atleast we try.

This is nothing special to buildroot, you'll find lots of other projects
requiring it, expecially the ones doing kernel-style
signed-off-by's.

E.G. from the kernels Documentation/SubmittingPatches:

then you just add a line saying

        Signed-off-by: Random J Developer <random@developer.example.org>

using your real name (sorry, no pseudonyms or anonymous contributions.)

And U-Boot:

http://lists.denx.de/pipermail/u-boot/2011-January/085905.html

And anyway, it's an illusion to think that you can truly remain
anonymous on the internet. Based on your mail headers I would say you
work for Verifone in their London based office. That combined with the
fact that you use Evolution on FC15 probably narrows it down quite a
bit.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH v2] dropbear: Create destination directories before use in install stage.

[Quotient Remainder]

Signed-off-by: Quotient Remainder <quotientvremainder@gmail.com>
---
 package/dropbear/dropbear.mk |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/package/dropbear/dropbear.mk b/package/dropbear/dropbear.mk
index 6ef5dec..ba148b6 100644
--- a/package/dropbear/dropbear.mk
+++ b/package/dropbear/dropbear.mk
@@ -47,7 +47,8 @@ DROPBEAR_DEPENDENCIES += zlib
 endif
 
 define DROPBEAR_INSTALL_TARGET_CMDS
-	$(INSTALL) -m 755 $(@D)/dropbearmulti $(TARGET_DIR)/usr/sbin/dropbear
+	$(INSTALL) -D -m 755 $(@D)/dropbearmulti $(TARGET_DIR)/usr/sbin/dropbear
+	mkdir -p $(TARGET_DIR)/usr/bin
 	for f in $(DROPBEAR_TARGET_BINS); do \
 		ln -snf ../sbin/dropbear $(TARGET_DIR)/usr/bin/$$f ; \
 	done
-- 
1.7.6