Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [pull request] Pull request for branch genautotargets-conversion
@ 2010-07-25 14:53 Thomas Petazzoni
  2010-07-25 14:53 ` [Buildroot] [PATCH 1/4] ltrace: convert to gentargets and bump to 0.5.3 Thomas Petazzoni
                   ` (4 more replies)
  0 siblings, 5 replies; 9+ messages in thread
From: Thomas Petazzoni @ 2010-07-25 14:53 UTC (permalink / raw)
  To: buildroot

The following changes since commit 3435c1afb58307240be8e4607b5bb7d239fac4e9:
  Peter Korsgaard (1):
        kconfig: implement KCONFIG_PROBABILITY for rand{,package}config

are available in the git repository at:

  git://git.busybox.net/~tpetazzoni/git/buildroot genautotargets-conversion

Thomas Petazzoni (4):
      ltrace: convert to gentargets and bump to 0.5.3
      tftpd: convert to autotargets
      setserial: convert to autotargets and fix bug 2269
      Deprecate pcmcia and microwin packages

 package/ltrace/ltrace-0.5-00-susv3-legacy.patch    |   11 --
 package/ltrace/ltrace-0.5.3-configure-fixes.patch  |  128 ++++++++++++++++++++
 package/ltrace/ltrace-0.5.3-susv3-legacy.patch     |   20 +++
 package/ltrace/ltrace.mk                           |   90 ++++-----------
 package/microwin/Config.in                         |    2 +
 package/pcmcia/Config.in                           |    2 +
 .../setserial-2.17-build-system-fix.patch          |   28 +++++
 package/setserial/setserial.mk                     |   16 ++-
 package/tftpd/tftpd.mk                             |   83 ++-----------
 9 files changed, 220 insertions(+), 160 deletions(-)
 delete mode 100644 package/ltrace/ltrace-0.5-00-susv3-legacy.patch
 create mode 100644 package/ltrace/ltrace-0.5.3-configure-fixes.patch
 create mode 100644 package/ltrace/ltrace-0.5.3-susv3-legacy.patch
 create mode 100644 package/setserial/setserial-2.17-build-system-fix.patch

Thanks,
-- 
Thomas Petazzoni

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [Buildroot] [PATCH 1/4] ltrace: convert to gentargets and bump to 0.5.3
  2010-07-25 14:53 [Buildroot] [pull request] Pull request for branch genautotargets-conversion Thomas Petazzoni
@ 2010-07-25 14:53 ` Thomas Petazzoni
  2010-07-25 14:53 ` [Buildroot] [PATCH 2/4] tftpd: convert to autotargets Thomas Petazzoni
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 9+ messages in thread
From: Thomas Petazzoni @ 2010-07-25 14:53 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 package/ltrace/ltrace-0.5-00-susv3-legacy.patch   |   11 --
 package/ltrace/ltrace-0.5.3-configure-fixes.patch |  128 +++++++++++++++++++++
 package/ltrace/ltrace-0.5.3-susv3-legacy.patch    |   20 +++
 package/ltrace/ltrace.mk                          |   90 ++++-----------
 4 files changed, 170 insertions(+), 79 deletions(-)
 delete mode 100644 package/ltrace/ltrace-0.5-00-susv3-legacy.patch
 create mode 100644 package/ltrace/ltrace-0.5.3-configure-fixes.patch
 create mode 100644 package/ltrace/ltrace-0.5.3-susv3-legacy.patch

diff --git a/package/ltrace/ltrace-0.5-00-susv3-legacy.patch b/package/ltrace/ltrace-0.5-00-susv3-legacy.patch
deleted file mode 100644
index 7518124..0000000
--- a/package/ltrace/ltrace-0.5-00-susv3-legacy.patch
+++ /dev/null
@@ -1,11 +0,0 @@
---- ltrace-0.5.orig/read_config_file.c	2006-02-20 22:48:07.000000000 +0100
-+++ ltrace-0.5/read_config_file.c	2007-10-02 12:18:21.000000000 +0200
-@@ -57,7 +57,7 @@
- 
- 	while (tmp->name) {
- 		if (!strncmp(*str, tmp->name, strlen(tmp->name))
--		    && index(" ,)#", *(*str + strlen(tmp->name)))) {
-+		    && strchr(" ,)#", *(*str + strlen(tmp->name)))) {
- 			*str += strlen(tmp->name);
- 			return tmp->pt;
- 		}
diff --git a/package/ltrace/ltrace-0.5.3-configure-fixes.patch b/package/ltrace/ltrace-0.5.3-configure-fixes.patch
new file mode 100644
index 0000000..8d95883
--- /dev/null
+++ b/package/ltrace/ltrace-0.5.3-configure-fixes.patch
@@ -0,0 +1,128 @@
+Fix several issues with the configure script:
+
+ * Allow option values to contains equal signs, like
+   CC="/foo/arm-linux-gcc --sysroot=/foobar/usr"
+
+ * Parse the option before doing the tests so that CC/CFLAGS can be
+   used during the tests.
+
+Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
+---
+ configure |   72 +++++++++++++++++++++++++++++++-------------------------------
+ 1 file changed, 37 insertions(+), 35 deletions(-)
+
+Index: ltrace-0.5.3/configure
+===================================================================
+--- ltrace-0.5.3.orig/configure
++++ ltrace-0.5.3/configure
+@@ -6,6 +6,38 @@
+   exit 1
+ fi
+ 
++CC=gcc
++CPPFLAGS=' -I /usr/include/libelf'
++CFLAGS='-g -O2'
++LIBS='-lelf '
++INSTALL='/usr/bin/install -c'
++iquote='-iquote '
++iquoteend=''
++
++prefix=/usr/local
++sysconfdir='${prefix}/etc'
++bindir='${prefix}/bin'
++mandir='${prefix}/share/man'
++docdir='${prefix}/share/doc/ltrace'
++for x_option
++do
++  if test -n "$x_prev"; then
++    eval $x_prev=\$x_option
++    x_prev=
++    continue
++  fi
++  case $x_option in
++    --*=* | *=*)
++      x_var=`echo $x_option | sed 's/^--//' | sed 's/=.*//'`
++      x_val=`echo $x_option | sed 's/^[^=]*=//'`
++      eval $x_var=\"$x_val\"
++      ;;
++    --*)
++      x_prev=`echo $x_option | sed 's/^--//'`
++      ;;
++  esac
++done
++
+ echo -n "checking package name... "
+ PACKAGE_NAME='ltrace'
+ echo $PACKAGE_NAME
+@@ -30,9 +62,10 @@
+   return cplus_demangle();
+ }
+ EOF
+-if gcc conftest.c -liberty 2>/dev/null
++if $CC $CFLAGS conftest.c -liberty 2>/dev/null
+ then
+   HAVE_LIBIBERTY=1
++  LIBS="$LIBS -liberty"
+   echo "yes"
+ else
+   unset HAVE_LIBIBERTY
+@@ -48,9 +81,10 @@
+   return __cxa_demangle();
+ }
+ EOF
+-if gcc conftest.c -lsupc++ 2>/dev/null
++if $CC $CFLAGS conftest.c -lsupc++ 2>/dev/null
+ then
+   HAVE_LIBSUPC__=1
++  LIBS="$LIBS -lsupc++"
+   echo "yes"
+ else
+   unset HAVE_LIBSUPC__
+@@ -67,7 +101,7 @@
+   return 0;
+ }
+ EOF
+-if gcc conftest.c 2>/dev/null
++if $CC $CFLAGS conftest.c 2>/dev/null
+ then
+   HAVE_ELF_C_READ_MMAP=1
+   echo "yes"
+@@ -77,38 +111,6 @@
+ fi
+ rm -f conftest.c a.out
+ 
+-CC=gcc
+-CPPFLAGS=' -I /usr/include/libelf'
+-CFLAGS='-g -O2'
+-LIBS='-lelf -lsupc++ -liberty '
+-INSTALL='/usr/bin/install -c'
+-iquote='-iquote '
+-iquoteend=''
+-
+-prefix=/usr/local
+-sysconfdir='${prefix}/etc'
+-bindir='${prefix}/bin'
+-mandir='${prefix}/share/man'
+-docdir='${prefix}/share/doc/ltrace'
+-for x_option
+-do
+-  if test -n "$x_prev"; then
+-    eval $x_prev=\$x_option
+-    x_prev=
+-    continue
+-  fi
+-  case $x_option in
+-    --*=* | *=*)
+-      x_var=`echo $x_option | sed 's/^--//' | sed 's/=.*//'`
+-      x_val=`echo $x_option | sed 's/^.*=//'`
+-      eval $x_var=$x_val
+-      ;;
+-    --*)
+-      x_prev=`echo $x_option | sed 's/^--//'`
+-      ;;
+-  esac
+-done
+-
+ echo "configure: creating Makefile"
+ #
+ # Makefile.in -> Makefile
diff --git a/package/ltrace/ltrace-0.5.3-susv3-legacy.patch b/package/ltrace/ltrace-0.5.3-susv3-legacy.patch
new file mode 100644
index 0000000..4c9bb8a
--- /dev/null
+++ b/package/ltrace/ltrace-0.5.3-susv3-legacy.patch
@@ -0,0 +1,20 @@
+Use the strchr() function instead of the legacy index() function.
+
+Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
+---
+ read_config_file.c |    2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+Index: ltrace-0.5.3/read_config_file.c
+===================================================================
+--- ltrace-0.5.3.orig/read_config_file.c
++++ ltrace-0.5.3/read_config_file.c
+@@ -83,7 +83,7 @@
+ 
+ 	while (tmp->name) {
+ 		if (!strncmp(*str, tmp->name, strlen(tmp->name))
+-				&& index(" ,()#*;012345[", *(*str + strlen(tmp->name)))) {
++				&& strchr(" ,()#*;012345[", *(*str + strlen(tmp->name)))) {
+ 			*str += strlen(tmp->name);
+ 			return lookup_prototype(tmp->pt);
+ 		}
diff --git a/package/ltrace/ltrace.mk b/package/ltrace/ltrace.mk
index 4a6811d..756ef7e 100644
--- a/package/ltrace/ltrace.mk
+++ b/package/ltrace/ltrace.mk
@@ -3,13 +3,11 @@
 # ltrace
 #
 #############################################################
-LTRACE_VERSION=0.5
-LTRACE_SOURCE=ltrace_$(LTRACE_VERSION).orig.tar.gz
-LTRACE_PATCH=ltrace_$(LTRACE_VERSION)-3.1.diff.gz
-LTRACE_SITE=$(BR2_DEBIAN_MIRROR)/debian/pool/main/l/ltrace
-LTRACE_DIR=$(BUILD_DIR)/ltrace-$(LTRACE_VERSION)
-LTRACE_BINARY=ltrace
-LTRACE_TARGET_BINARY=usr/bin/ltrace
+LTRACE_VERSION      = 0.5.3
+LTRACE_SOURCE       = ltrace_$(LTRACE_VERSION).orig.tar.gz
+LTRACE_PATCH        = ltrace_$(LTRACE_VERSION)-2.1.diff.gz
+LTRACE_SITE         = $(BR2_DEBIAN_MIRROR)/debian/pool/main/l/ltrace
+LTRACE_DEPENDENCIES = libelf
 
 # ltrace uses arch=ppc for powerpc
 LTRACE_ARCH:=$(KERNEL_ARCH:powerpc=ppc)
@@ -17,71 +15,27 @@ ifeq ("$(strip $(ARCH))","armeb")
 LTRACE_ARCH:=arm
 endif
 
-$(DL_DIR)/$(LTRACE_SOURCE):
-	$(call DOWNLOAD,$(LTRACE_SITE),$(LTRACE_SOURCE))
+define LTRACE_CONFIGURE_CMDS
+	(cd $(@D) ; ./configure 		\
+		--prefix=/usr			\
+		CC='$(TARGET_CC)' 		\
+		CFLAGS='$(TARGET_CFLAGS)')
+endef
 
-ifneq ($(LTRACE_PATCH),)
-LTRACE_PATCH_FILE:=$(DL_DIR)/$(LTRACE_PATCH)
-$(LTRACE_PATCH_FILE):
-	$(call DOWNLOAD,$(LTRACE_SITE),$(LTRACE_PATCH))
+define LTRACE_BUILD_CMDS
+	$(MAKE) -C $(@D) ARCH=$(LTRACE_ARCH)
+endef
 
-else
-LTRACE_PATCH_FILE:=
-endif
-
-$(LTRACE_DIR)/.patched: $(DL_DIR)/$(LTRACE_SOURCE) $(LTRACE_PATCH_FILE)
-	$(ZCAT) $(DL_DIR)/$(LTRACE_SOURCE) | tar -C $(BUILD_DIR) $(TAR_OPTIONS) -
-ifneq ($(LTRACE_PATCH),)
-	$(ZCAT) $(LTRACE_PATCH_FILE) | patch -p1 -d $(LTRACE_DIR)
-endif
-	toolchain/patch-kernel.sh $(LTRACE_DIR) package/ltrace ltrace\*.patch
-	$(CONFIG_UPDATE) $(@D)
-	chmod +x $(LTRACE_DIR)/configure
-	touch $@
-
-$(LTRACE_DIR)/.configured: $(LTRACE_DIR)/.patched
-	(cd $(LTRACE_DIR); rm -rf config.cache; \
-		$(TARGET_CONFIGURE_OPTS) \
-		$(TARGET_CONFIGURE_ARGS) \
-		./configure $(QUIET) \
-		--target=$(GNU_TARGET_NAME) \
-		--host=$(GNU_TARGET_NAME) \
-		--build=$(GNU_HOST_NAME) \
-		--prefix=/usr \
-		--sysconfdir=/etc \
-		$(DISABLE_LARGEFILE) \
-	)
-	touch $@
-
-$(LTRACE_DIR)/$(LTRACE_BINARY): $(LTRACE_DIR)/.configured
-	$(MAKE) ARCH=$(LTRACE_ARCH) -C $(LTRACE_DIR)
-
-$(TARGET_DIR)/$(LTRACE_TARGET_BINARY): $(LTRACE_DIR)/$(LTRACE_BINARY)
-	#$(MAKE) DESTDIR=$(TARGET_DIR) ARCH=$(LTRACE_ARCH)  -C $(LTRACE_DIR) install
-	$(INSTALL) -D $(LTRACE_DIR)/$(LTRACE_BINARY) $@
 ifeq ($(BR2_HAVE_DOCUMENTATION),y)
-	$(INSTALL) -D $(LTRACE_DIR)/ltrace.1 \
+define LTRACE_INSTALL_DOCUMENTATION
+	$(INSTALL) -D $(@D)/ltrace.1 \
 		$(TARGET_DIR)/usr/share/man/man1/ltrace.1
+endef
 endif
-	$(STRIPCMD) $(STRIP_STRIP_ALL) $@
-
-ltrace: libelf $(TARGET_DIR)/$(LTRACE_TARGET_BINARY)
 
-ltrace-source: $(DL_DIR)/$(LTRACE_SOURCE) $(LTRACE_PATCH_FILE)
+define LTRACE_INSTALL_TARGET_CMDS
+	$(INSTALL) -D $(@D)/ltrace $(TARGET_DIR)/usr/bin
+	$(LTRACE_INSTALL_DOCUMENTATION)
+endef
 
-ltrace-clean:
-	-$(MAKE) -C $(LTRACE_DIR) clean
-	rm -f $(LTRACE_DIR)/$(LTRACE_BINARY) \
-		$(TARGET_DIR)/usr/share/man/man1/ltrace.1*
-
-ltrace-dirclean:
-	rm -rf $(LTRACE_DIR)
-
-#############################################################
-#
-# Toplevel Makefile options
-#
-#############################################################
-ifeq ($(BR2_PACKAGE_LTRACE),y)
-TARGETS+=ltrace
-endif
+$(eval $(call GENTARGETS,package,ltrace))
\ No newline at end of file
-- 
1.7.0.4

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [Buildroot] [PATCH 2/4] tftpd: convert to autotargets
  2010-07-25 14:53 [Buildroot] [pull request] Pull request for branch genautotargets-conversion Thomas Petazzoni
  2010-07-25 14:53 ` [Buildroot] [PATCH 1/4] ltrace: convert to gentargets and bump to 0.5.3 Thomas Petazzoni
@ 2010-07-25 14:53 ` Thomas Petazzoni
  2010-07-25 14:53 ` [Buildroot] [PATCH 3/4] setserial: convert to autotargets and fix bug 2269 Thomas Petazzoni
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 9+ messages in thread
From: Thomas Petazzoni @ 2010-07-25 14:53 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 package/tftpd/tftpd.mk |   83 +++++------------------------------------------
 1 files changed, 9 insertions(+), 74 deletions(-)

diff --git a/package/tftpd/tftpd.mk b/package/tftpd/tftpd.mk
index 795aab6..c4242f1 100644
--- a/package/tftpd/tftpd.mk
+++ b/package/tftpd/tftpd.mk
@@ -3,79 +3,14 @@
 # tftpd
 #
 #############################################################
-TFTP_HPA_VERSION:=0.40
-TFTP_HPA_SOURCE:=tftp-hpa-$(TFTP_HPA_VERSION).tar.bz2
-TFTP_HPA_SITE:=$(BR2_KERNEL_MIRROR)/software/network/tftp/
-TFTP_HPA_DIR:=$(BUILD_DIR)/tftp-hpa-$(TFTP_HPA_VERSION)
-TFTP_HPA_CAT:=$(BZCAT)
-TFTP_HPA_BINARY:=tftpd/tftpd
-TFTP_HPA_TARGET_BINARY:=usr/sbin/in.tftpd
+TFTPD_VERSION  = 5.0
+TFTPD_SOURCE   = tftp-hpa-$(TFTPD_VERSION).tar.bz2
+TFTPD_SITE     = $(BR2_KERNEL_MIRROR)/software/network/tftp/
+TFTPD_CONF_OPT = --without-tcpwrappers
 
-$(DL_DIR)/$(TFTP_HPA_SOURCE):
-	 $(call DOWNLOAD,$(TFTP_HPA_SITE),$(TFTP_HPA_SOURCE))
+define TFTPD_INSTALL_TARGET_CMDS
+	$(INSTALL) -D $(@D)/tftpd/tftpd $(TARGET_DIR)/usr/sbin/tftpd
+	$(INSTALL) -D package/tftpd/S80tftpd-hpa $(TARGET_DIR)/etc/init.d/
+endef
 
-tftpd-source: $(DL_DIR)/$(TFTP_HPA_SOURCE)
-
-$(TFTP_HPA_DIR)/.unpacked: $(DL_DIR)/$(TFTP_HPA_SOURCE)
-	$(TFTP_HPA_CAT) $(DL_DIR)/$(TFTP_HPA_SOURCE) | tar -C $(BUILD_DIR) $(TAR_OPTIONS) -
-	toolchain/patch-kernel.sh $(TFTP_HPA_DIR) package/tftpd/ tftpd\*.patch
-	touch $(TFTP_HPA_DIR)/.unpacked
-
-$(TFTP_HPA_DIR)/.configured: $(TFTP_HPA_DIR)/.unpacked
-	(cd $(TFTP_HPA_DIR); rm -rf config.cache; \
-		$(TARGET_CONFIGURE_OPTS) \
-		$(TARGET_CONFIGURE_ARGS) \
-		./configure $(QUIET) \
-		--target=$(GNU_TARGET_NAME) \
-		--host=$(GNU_TARGET_NAME) \
-		--build=$(GNU_HOST_NAME) \
-		--prefix=/usr \
-		--exec-prefix=/usr \
-		--bindir=/usr/bin \
-		--sbindir=/usr/sbin \
-		--libdir=/lib \
-		--libexecdir=/usr/lib \
-		--sysconfdir=/etc \
-		--datadir=/usr/share \
-		--localstatedir=/var \
-		--mandir=/usr/man \
-		--infodir=/usr/info \
-		$(DISABLE_LARGEFILE) \
-		--without-tcpwrappers \
-	)
-	touch $(TFTP_HPA_DIR)/.configured
-
-$(TFTP_HPA_DIR)/$(TFTP_HPA_BINARY): $(TFTP_HPA_DIR)/.configured
-	$(MAKE) -C $(TFTP_HPA_DIR)
-
-# This stuff is needed to work around GNU make deficiencies
-$(TARGET_DIR)/$(TFTP_HPA_TARGET_BINARY): $(TFTP_HPA_DIR)/$(TFTP_HPA_BINARY)
-	@if [ -L $(TARGET_DIR)/$(TFTP_HPA_TARGET_BINARY) ]; then \
-		rm -f $(TARGET_DIR)/$(TFTP_HPA_TARGET_BINARY); fi
-	@if [ ! -f $(TFTP_HPA_DIR)/$(TFTP_HPA_BINARY) -o $(TARGET_DIR)/$(TFTP_HPA_TARGET_BINARY) \
-	-ot $(TFTP_HPA_DIR)/$(TFTP_HPA_BINARY) ]; then \
-	    set -x; \
-	    rm -f $(TARGET_DIR)/$(TFTP_HPA_TARGET_BINARY); \
-	    cp -a $(TFTP_HPA_DIR)/$(TFTP_HPA_BINARY) $(TARGET_DIR)/$(TFTP_HPA_TARGET_BINARY); fi
-	@if [ ! -f $(TARGET_DIR)/etc/init.d/S80tftpd-hpa ]; then \
-		$(INSTALL) -m 0755 package/tftpd/S80tftpd-hpa $(TARGET_DIR)/etc/init.d; \
-	fi
-
-tftpd: $(TARGET_DIR)/$(TFTP_HPA_TARGET_BINARY)
-
-tftpd-clean:
-	rm -f $(TARGET_DIR)/etc/init.d/S80tftpd-hpa
-	rm -f $(TARGET_DIR)/usr/sbin/in.tftpd
-	-$(MAKE) -C $(TFTP_HPA_DIR) clean
-
-tftpd-dirclean:
-	rm -rf $(TFTP_HPA_DIR)
-
-#############################################################
-#
-# Toplevel Makefile options
-#
-#############################################################
-ifeq ($(BR2_PACKAGE_TFTPD),y)
-TARGETS+=tftpd
-endif
+$(eval $(call AUTOTARGETS,package,tftpd))
\ No newline at end of file
-- 
1.7.0.4

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [Buildroot] [PATCH 3/4] setserial: convert to autotargets and fix bug 2269
  2010-07-25 14:53 [Buildroot] [pull request] Pull request for branch genautotargets-conversion Thomas Petazzoni
  2010-07-25 14:53 ` [Buildroot] [PATCH 1/4] ltrace: convert to gentargets and bump to 0.5.3 Thomas Petazzoni
  2010-07-25 14:53 ` [Buildroot] [PATCH 2/4] tftpd: convert to autotargets Thomas Petazzoni
@ 2010-07-25 14:53 ` Thomas Petazzoni
  2010-07-26 22:50   ` Peter Korsgaard
  2010-07-25 14:53 ` [Buildroot] [PATCH 4/4] Deprecate pcmcia and microwin packages Thomas Petazzoni
  2010-07-26 22:52 ` [Buildroot] [pull request] Pull request for branch genautotargets-conversion Peter Korsgaard
  4 siblings, 1 reply; 9+ messages in thread
From: Thomas Petazzoni @ 2010-07-25 14:53 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 .../setserial-2.17-build-system-fix.patch          |   28 ++++++++++++++++++++
 package/setserial/setserial.mk                     |   16 ++++++-----
 2 files changed, 37 insertions(+), 7 deletions(-)
 create mode 100644 package/setserial/setserial-2.17-build-system-fix.patch

diff --git a/package/setserial/setserial-2.17-build-system-fix.patch b/package/setserial/setserial-2.17-build-system-fix.patch
new file mode 100644
index 0000000..598217e
--- /dev/null
+++ b/package/setserial/setserial-2.17-build-system-fix.patch
@@ -0,0 +1,28 @@
+Install the setserial program in /usr/bin instead of /bin, and make
+sure that the directories (especially the manpages directory) are
+created before installing files to them. This is similar to what
+automake does.
+
+Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
+---
+ Makefile.in |    6 ++++--
+ 1 file changed, 4 insertions(+), 2 deletions(-)
+
+Index: setserial-2.17/Makefile.in
+===================================================================
+--- setserial-2.17.orig/Makefile.in
++++ setserial-2.17/Makefile.in
+@@ -26,9 +26,11 @@
+ 	nroff -man setserial.8 > setserial.cat
+ 
+ install: setserial setserial.8
+-	$(INSTALL_PROGRAM) setserial $(DESTDIR)/bin
++	mkdir -p $(DESTDIR)/usr/bin
++	$(INSTALL_PROGRAM) setserial $(DESTDIR)/usr/bin
+ 	$(STRIP) $(DESTDIR)/bin/setserial
+-	$(INSTALL_DATA) setserial.8 $(DESTDIR)/usr/man/man8
++	mkdir -p $(DESTDIR)/usr/share/man/man8
++	$(INSTALL_DATA) setserial.8 $(DESTDIR)/usr/share/man/man8
+ 
+ clean:
+ 	$(RM) setserial setserial.o setserial.cat *~
diff --git a/package/setserial/setserial.mk b/package/setserial/setserial.mk
index 1c222a2..0b67346 100644
--- a/package/setserial/setserial.mk
+++ b/package/setserial/setserial.mk
@@ -3,16 +3,18 @@
 # Setserial
 #
 #############################################################
-SETSERIAL_VERSION:=2.17
-SETSERIAL_PATCH_VERSION:=.orig
-SETSERIAL_PATCH_FILE:=setserial_2.17-45.diff.gz
-SETSERIAL_SOURCE:=setserial_$(SETSERIAL_VERSION)$(SETSERIAL_PATCH_VERSION).tar.gz
-SETSERIAL_SITE:=$(BR2_DEBIAN_MIRROR)/debian/pool/main/s/setserial/
-SETSERIAL_INSTALL_TARGET_OPT=DESTDIR=$(TARGET_DIR) install
+SETSERIAL_VERSION            = 2.17
+SETSERIAL_PATCH              = setserial_2.17-45.2.diff.gz
+SETSERIAL_SOURCE             = setserial_$(SETSERIAL_VERSION).orig.tar.gz
+SETSERIAL_SITE               = $(BR2_DEBIAN_MIRROR)/debian/pool/main/s/setserial/
+SETSERIAL_INSTALL_TARGET_OPT = DESTDIR=$(TARGET_DIR) install
 
 define SETSERIAL_APPLY_DEBIAN_PATCHES
+	# Touching gorhack.h is needed for the Debian patch 18 to work
 	if [ -d $(@D)/debian/patches ]; then \
-		toolchain/patch-kernel.sh $(@D) $(@D)/debian/patches \*.patch; \
+		touch $(@D)/gorhack.h; \
+		rm $(@D)/debian/patches/01_makefile.dpatch; \
+		toolchain/patch-kernel.sh $(@D) $(@D)/debian/patches *.dpatch; \
 	fi
 endef
 
-- 
1.7.0.4

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [Buildroot] [PATCH 4/4] Deprecate pcmcia and microwin packages
  2010-07-25 14:53 [Buildroot] [pull request] Pull request for branch genautotargets-conversion Thomas Petazzoni
                   ` (2 preceding siblings ...)
  2010-07-25 14:53 ` [Buildroot] [PATCH 3/4] setserial: convert to autotargets and fix bug 2269 Thomas Petazzoni
@ 2010-07-25 14:53 ` Thomas Petazzoni
  2010-07-26 22:52 ` [Buildroot] [pull request] Pull request for branch genautotargets-conversion Peter Korsgaard
  4 siblings, 0 replies; 9+ messages in thread
From: Thomas Petazzoni @ 2010-07-25 14:53 UTC (permalink / raw)
  To: buildroot

It isn't worth the effort to convert these packages to the new package
infrastructure since they are deprecated.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 package/microwin/Config.in |    2 ++
 package/pcmcia/Config.in   |    2 ++
 2 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/package/microwin/Config.in b/package/microwin/Config.in
index 5445f6a..3dd1e37 100644
--- a/package/microwin/Config.in
+++ b/package/microwin/Config.in
@@ -1,5 +1,7 @@
 config BR2_PACKAGE_MICROWIN
 	bool "microwin"
+	# Old, unmaintained graphic stack
+	depends on BR2_DEPRECATED
 	help
 	 Microwindows Graphical User Interface for small and
 	 embedded enviroments.
diff --git a/package/pcmcia/Config.in b/package/pcmcia/Config.in
index fe26fa3..de1e33b 100644
--- a/package/pcmcia/Config.in
+++ b/package/pcmcia/Config.in
@@ -1,6 +1,8 @@
 config BR2_PACKAGE_PCMCIA
 	bool "pcmcia"
 	depends on BR2_PACKAGE_LINUX
+	# The website says it's deprecated after 2.4.x kernels
+	depends on BR2_DEPRECATED
 	help
 	  PCMCIA tools for Linux.
 
-- 
1.7.0.4

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [Buildroot] [PATCH 3/4] setserial: convert to autotargets and fix bug 2269
  2010-07-25 14:53 ` [Buildroot] [PATCH 3/4] setserial: convert to autotargets and fix bug 2269 Thomas Petazzoni
@ 2010-07-26 22:50   ` Peter Korsgaard
  2010-07-27  8:35     ` Thomas Petazzoni
  0 siblings, 1 reply; 9+ messages in thread
From: Peter Korsgaard @ 2010-07-26 22:50 UTC (permalink / raw)
  To: buildroot

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 Thomas> +Index: setserial-2.17/Makefile.in
 Thomas> +===================================================================
 Thomas> +--- setserial-2.17.orig/Makefile.in
 Thomas> ++++ setserial-2.17/Makefile.in
 Thomas> +@@ -26,9 +26,11 @@
 Thomas> + 	nroff -man setserial.8 > setserial.cat
 Thomas> + 
 Thomas> + install: setserial setserial.8
 Thomas> +-	$(INSTALL_PROGRAM) setserial $(DESTDIR)/bin
 Thomas> ++	mkdir -p $(DESTDIR)/usr/bin
 Thomas> ++	$(INSTALL_PROGRAM) setserial $(DESTDIR)/usr/bin
 Thomas> + 	$(STRIP) $(DESTDIR)/bin/setserial

That strip should go.

You're also not renaming setserial-tiocghayesesp-build-fix.patch, so
we're back with 5a2844c748.

Other than that it looks good.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [Buildroot] [pull request] Pull request for branch genautotargets-conversion
  2010-07-25 14:53 [Buildroot] [pull request] Pull request for branch genautotargets-conversion Thomas Petazzoni
                   ` (3 preceding siblings ...)
  2010-07-25 14:53 ` [Buildroot] [PATCH 4/4] Deprecate pcmcia and microwin packages Thomas Petazzoni
@ 2010-07-26 22:52 ` Peter Korsgaard
  4 siblings, 0 replies; 9+ messages in thread
From: Peter Korsgaard @ 2010-07-26 22:52 UTC (permalink / raw)
  To: buildroot

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 Thomas> The following changes since commit 3435c1afb58307240be8e4607b5bb7d239fac4e9:
 Thomas>   Peter Korsgaard (1):
 Thomas>         kconfig: implement KCONFIG_PROBABILITY for rand{,package}config

 Thomas> are available in the git repository at:

 Thomas>   git://git.busybox.net/~tpetazzoni/git/buildroot genautotargets-conversion

 Thomas> Thomas Petazzoni (4):
 Thomas>       ltrace: convert to gentargets and bump to 0.5.3
 Thomas>       tftpd: convert to autotargets
 Thomas>       setserial: convert to autotargets and fix bug 2269
 Thomas>       Deprecate pcmcia and microwin packages

Committed with minor modifications, thanks!

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [Buildroot] [PATCH 3/4] setserial: convert to autotargets and fix bug 2269
  2010-07-26 22:50   ` Peter Korsgaard
@ 2010-07-27  8:35     ` Thomas Petazzoni
  2010-07-27  8:53       ` Peter Korsgaard
  0 siblings, 1 reply; 9+ messages in thread
From: Thomas Petazzoni @ 2010-07-27  8:35 UTC (permalink / raw)
  To: buildroot

On Tue, 27 Jul 2010 00:50:58 +0200
Peter Korsgaard <jacmet@uclibc.org> wrote:

> >>>>> "Thomas" == Thomas Petazzoni
> >>>>> <thomas.petazzoni@free-electrons.com> writes:
> 
>  Thomas> +Index: setserial-2.17/Makefile.in
>  Thomas> +===================================================================
>  Thomas> +--- setserial-2.17.orig/Makefile.in
>  Thomas> ++++ setserial-2.17/Makefile.in
>  Thomas> +@@ -26,9 +26,11 @@
>  Thomas> + 	nroff -man setserial.8 > setserial.cat
>  Thomas> + 
>  Thomas> + install: setserial setserial.8
>  Thomas> +-	$(INSTALL_PROGRAM) setserial $(DESTDIR)/bin
>  Thomas> ++	mkdir -p $(DESTDIR)/usr/bin
>  Thomas> ++	$(INSTALL_PROGRAM) setserial $(DESTDIR)/usr/bin
>  Thomas> + 	$(STRIP) $(DESTDIR)/bin/setserial
> 
> That strip should go.

Well, it was here in the setserial Makefile. While I agree that we
shouldn't explicitly add strip commands in Buildroot .mk files, I don't
think it's worth the effort removing those strip commands from within
the package.

> You're also not renaming setserial-tiocghayesesp-build-fix.patch, so
> we're back with 5a2844c748.

Right, sorry.

Thanks for having fixed those issues.

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [Buildroot] [PATCH 3/4] setserial: convert to autotargets and fix bug 2269
  2010-07-27  8:35     ` Thomas Petazzoni
@ 2010-07-27  8:53       ` Peter Korsgaard
  0 siblings, 0 replies; 9+ messages in thread
From: Peter Korsgaard @ 2010-07-27  8:53 UTC (permalink / raw)
  To: buildroot

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

Hi,

 Thomas> + install: setserial setserial.8
 Thomas> +-	$(INSTALL_PROGRAM) setserial $(DESTDIR)/bin
 Thomas> ++	mkdir -p $(DESTDIR)/usr/bin
 Thomas> ++	$(INSTALL_PROGRAM) setserial $(DESTDIR)/usr/bin
 Thomas> + 	$(STRIP) $(DESTDIR)/bin/setserial
 >> 
 >> That strip should go.

 Thomas> Well, it was here in the setserial Makefile. While I agree that we
 Thomas> shouldn't explicitly add strip commands in Buildroot .mk files, I don't
 Thomas> think it's worth the effort removing those strip commands from within
 Thomas> the package.

No, but it was stripping bin/setserial, not usr/bin/setserial.


-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2010-07-27  8:53 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-25 14:53 [Buildroot] [pull request] Pull request for branch genautotargets-conversion Thomas Petazzoni
2010-07-25 14:53 ` [Buildroot] [PATCH 1/4] ltrace: convert to gentargets and bump to 0.5.3 Thomas Petazzoni
2010-07-25 14:53 ` [Buildroot] [PATCH 2/4] tftpd: convert to autotargets Thomas Petazzoni
2010-07-25 14:53 ` [Buildroot] [PATCH 3/4] setserial: convert to autotargets and fix bug 2269 Thomas Petazzoni
2010-07-26 22:50   ` Peter Korsgaard
2010-07-27  8:35     ` Thomas Petazzoni
2010-07-27  8:53       ` Peter Korsgaard
2010-07-25 14:53 ` [Buildroot] [PATCH 4/4] Deprecate pcmcia and microwin packages Thomas Petazzoni
2010-07-26 22:52 ` [Buildroot] [pull request] Pull request for branch genautotargets-conversion Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox