From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] svn commit: trunk/buildroot/package: multimedia/alsa-lib python
Date: Sat, 17 Jan 2009 08:54:14 +0100 [thread overview]
Message-ID: <87skni2wrd.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <20090117001907.6679477587@busybox.osuosl.org> (ulf@uclibc.org's message of "Sat\, 17 Jan 2009 00\:19\:07 +0000 \(UTC\)")
>>>>> "ulf" == ulf <ulf@uclibc.org> writes:
ulf> Author: ulf
ulf> Date: 2009-01-17 00:19:06 +0000 (Sat, 17 Jan 2009)
ulf> New Revision: 24893
ulf> Log:
ulf> Make alsa-lib depend on libpython, if new BR2_PACKAGE_ALSA_LIB_PYTHON is selected
ulf> Modified:
ulf> trunk/buildroot/package/multimedia/alsa-lib/Config.in
ulf> trunk/buildroot/package/multimedia/alsa-lib/alsa-lib.mk
ulf> trunk/buildroot/package/python/python.mk
ulf> Changeset:
ulf> Modified: trunk/buildroot/package/multimedia/alsa-lib/Config.in
ulf> ===================================================================
ulf> --- trunk/buildroot/package/multimedia/alsa-lib/Config.in 2009-01-16 22:45:31 UTC (rev 24892)
ulf> +++ trunk/buildroot/package/multimedia/alsa-lib/Config.in 2009-01-17 00:19:06 UTC (rev 24893)
ulf> @@ -5,3 +5,14 @@
ulf> functionality to the Linux operating system.
ulf> http://www.alsa-project.org/
ulf> +
ulf> +config BR2_PACKAGE_ALSA_LIB_PYTHON
ulf> + bool "Python support for alsa-lib"
ulf> + depends on BR2_PACKAGE_ALSA_LIB
ulf> + select BR2_PACKAGE_PYTHON
It would probably be goodt to add a 'default BR2_PACKAGE_PYTHON' line,
so it defaults to enabled if you have python support, and false
otherwise.
Alternatively it should depend on BR2_PACKAGE_PYTHON and just be
default y, as it's probably pretty unlikely someone wants python
support in alsa without having python enabled in the first place.
The 2nd option seems cleanest to me, what do you think?
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2009-01-17 7:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-17 0:19 [Buildroot] svn commit: trunk/buildroot/package: multimedia/alsa-lib python ulf at uclibc.org
2009-01-17 7:54 ` Peter Korsgaard [this message]
2009-01-26 15:40 ` Peter Korsgaard
2009-01-26 19:01 ` Ulf Samuelsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87skni2wrd.fsf@macbook.be.48ers.dk \
--to=jacmet@uclibc.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox