Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: Kanak Shilledar <kanak.shilledar@axis.com>
Cc: <buildroot@buildroot.org>,  Petr Vorel <petr.vorel@gmail.com>
Subject: Re: [Buildroot] [RESEND v3 1/1] support: kconfig: Fix compiler warnings
Date: Fri, 29 May 2026 12:43:53 +0200	[thread overview]
Message-ID: <87tsrqijh2.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20260512105602.83368-2-kanak.shilledar@axis.com> (Kanak Shilledar's message of "Tue, 12 May 2026 12:56:01 +0200")

>>>>> "Kanak" == Kanak Shilledar <kanak.shilledar@axis.com> writes:

 > Add a new patch to fix the compiler warning given on Ubuntu 24.04.4 in
 > `util.c` warning of `-Wformat-overflow=`.

 > ```
 > ./util.c: In function ‘file_write_dep’:
 > ./util.c:86:26: warning: ‘%s’ directive writing 10 or more bytes into
 > a region of size between 1 and 4097 [-Wformat-overflow=]
 >    86 |         sprintf(buf2, "%s%s", dir, name);
 >       |                          ^~
 > ./util.c:86:9: note: ‘sprintf’ output 11 or more bytes (assuming 4107)
 > into a destination of size 4097
 >    86 |         sprintf(buf2, "%s%s", dir, name);
 >       |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 > ```

 > Update `buf2` to `PATH_MAX+20` similar to `buf`, thus giving enough
 > headroom for the filename suffix.

 > --
 > Changes in v3:
 > * Updated the commit message
 > * Generated the patch using `git format-patch`, and added to the
 >   `series`.

 > --
 > Changes in v2:
 > * Changed from direct file fix to patch based fix.

Given that the issue was introduced in commit 324612d68e09d0db4 which
did NOT add a patch I have instead applied:

https://patchwork.ozlabs.org/project/buildroot/patch/20260507123534.318763-1-thomas@devoogdt.com/

And marked this patch as superseeded.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      parent reply	other threads:[~2026-05-29 10:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-12 10:56 [Buildroot] [RESEND v3 0/1] support: kconfig: Fix compiler warnings Kanak Shilledar
2026-05-12 10:56 ` [Buildroot] [RESEND v3 1/1] " Kanak Shilledar
2026-05-12 13:36   ` Edgar Bonet via buildroot
2026-05-12 21:16     ` Petr Vorel
2026-05-18 14:15       ` Kanak Shilledar
2026-05-29 10:43   ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tsrqijh2.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@buildroot.org \
    --cc=kanak.shilledar@axis.com \
    --cc=petr.vorel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox